feat(engine): cli argument to disable state cache #20143
+87
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
requested review from
fgimenez,
klkvr and
mediocregopher
as code owners
joshieDo
approved these changes
Dec 5, 2025
| } | ||
|
|
||
| /// Setter for whether to disable state cache. | ||
| pub const fn without_state_cache(mut self, disable_state_cache: bool) -> Self { |
Collaborator
There was a problem hiding this comment.
without is weird to me but i see its used by others as well
mattsse
reviewed
Dec 5, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
doesnt this still handle cache updates after execution?
shekhirin
force-pushed
the
alexey/engine-disable-state-cache
branch
from
02f8aa0 to
b82afb8
Compare
shekhirin
force-pushed
the
alexey/engine-disable-state-cache
branch
3 times, most recently
from
c58b06a to
b82afb8
Compare
mattsse
reviewed
Dec 8, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this feels a bit messy
how does prewarm behave if caching is disabled?
should we even do prewarm if we don't make use of the shared cache or only for the proof prep?
Comment on lines
+282
to
+283
| let elapsed = start.elapsed(); | ||
| debug!(target: "engine::caching", parent_hash=?hash, elapsed=?elapsed, "Updated execution cache"); |
Collaborator
There was a problem hiding this comment.
these are now misleading if there's no cache
Collaborator
Author
There was a problem hiding this comment.
it's gated behind if let Some(saved_cache) = saved_cache which is triggered only if we use state cache
Collaborator
Author
|
@mattsse prewarm is used for proofs even without the state cache, yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ability to disable cached state provider by passing
--engine.disable-state-cacheCLI argument.