review fixes

Author: klkvr

crates/engine/tree/src/tree/payload_processor/mod.rs

@@ -349,9 +349,10 @@ where
                     let _ = execute_tx.send(tx);
                     next_for_execution += 1;
 
-                    while queue.first_key_value().is_some_and(|(idx, _)| *idx == next_for_execution)
+                    while let Some(entry) = queue.first_entry() &&
+                        *entry.key() == next_for_execution
                     {
-                        let _ = execute_tx.send(queue.pop_first().unwrap().1);
+                        let _ = execute_tx.send(entry.remove());
                         next_for_execution += 1;
                     }
                 } else {

crates/engine/tree/src/tree/payload_validator.rs

@@ -226,13 +226,8 @@ where
                     convert(tx).map(Either::Left).map_err(Either::Left)
                 };
 
-                Ok((
-                    iter,
-                    Box::new(convert)
-                        as Box<
-                            dyn Fn(Either<_, _>) -> Result<Either<_, _>, _> + Send + Sync + 'static,
-                        >,
-                ))
+                // Box the closure to satisfy the `Fn` bound both here and in the branch below
+                Ok((iter, Box::new(convert) as Box<dyn Fn(_) -> _ + Send + Sync + 'static>))
             }
             BlockOrPayload::Block(block) => {
                 let iter =

crates/evm/evm/src/engine.rs

@@ -23,6 +23,9 @@ pub trait ConfigureEngineEvm<ExecutionData>: ConfigureEvm {
 /// parallelize heavy work like decoding or recovery.
 pub trait ExecutableTxTuple: Into<(Self::Iter, Self::Convert)> + Send + 'static {
     /// Raw transaction that can be converted to an [`ExecutableTxIterator::Tx`]
+    ///
+    /// This can be any type that can be converted to an [`ExecutableTxIterator::Tx`]. For example,
+    /// an unrecovered transaction or just the transaction bytes.
     type RawTx: Send + Sync + 'static;
     /// The executable transaction type iterator yields.
     type Tx: Clone + Send + Sync + 'static;