-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Unpin Python version in the development environment #61585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If we don't pin to the minimum supported version, I fear contributors will submit code that is only supported on higher versions and then have to debug-via-CI. That is not a good experience. I think we should continue to push contributors to use the minimum Python version by pinning it rather than removing the pin. |
Thanks for the feedback @rhshadrach. Personally I think the CI will prevent any issue, and I'm not sure how often people code things that only work in the latest versions of Python. At the same time, it's not a big deal to keep updating the Python version in |
I've lost track - when are we dropping 3.10 support? Do we have discussion on this? |
#60059 and Matt mentioned it in the last dev call too |
Thanks! I'm good with pinning the environment to 3.11 in that case even before we drop 3.10 fully on main. But I do think we should prefer this over no pin. |
xref #61555
Our base conda environment
environment.yml
is used locally by pandas developers (contributors and maintainers), and for some CI jobs, like building the documentation. For stability, we pinned the version of Python to a specific version (currentlypython=3.10
). As new versions of Python are released, this is becoming outdated, and for no particular reason we're now going building our docs and creating our development environments in a Python version soon to stop being supported.This issue is to remove the pin, leave
python
open to any version, which in general it should be the latest available, and fix all the problems in the CI caused by upgrading the version here.The errors detected when upgrading can be found here:
The text was updated successfully, but these errors were encountered: