updating based on feedback

kirill-bash · kirill-bash · commit aaa109475c57 · 2024-08-29T19:58:05.000-04:00
diff --git a/tests/test_frame.py b/tests/test_frame.py
@@ -379,12 +379,14 @@ def test_types_drop_duplicates() -> None:
         }
     )
 
-    check(assert_type(df.drop_duplicates({"AAA"}), pd.DataFrame), pd.DataFrame)
     check(assert_type(df.drop_duplicates(["AAA"]), pd.DataFrame), pd.DataFrame)
     check(assert_type(df.drop_duplicates(("AAA",)), pd.DataFrame), pd.DataFrame)
-    check(assert_type(df.drop_duplicates({"AAA": None}), pd.DataFrame), pd.DataFrame)
     check(assert_type(df.drop_duplicates("AAA"), pd.DataFrame), pd.DataFrame)
 
+    if PD_LTE_22:
+        check(assert_type(df.drop_duplicates({"AAA"}), pd.DataFrame), pd.DataFrame)
+        check(assert_type(df.drop_duplicates({"AAA": None}), pd.DataFrame), pd.DataFrame)
+
 
 def test_types_fillna() -> None:
     df = pd.DataFrame(data={"col1": [np.nan, np.nan], "col2": [3, np.nan]})

Original file line number	Diff line number	Diff line change
`@@ -379,12 +379,14 @@ def test_types_drop_duplicates() -> None:`
`379`	`379`	`}`
`380`	`380`	`)`
`381`	`381`
`382`		`- check(assert_type(df.drop_duplicates({"AAA"}), pd.DataFrame), pd.DataFrame)`
`383`	`382`	`check(assert_type(df.drop_duplicates(["AAA"]), pd.DataFrame), pd.DataFrame)`
`384`	`383`	`check(assert_type(df.drop_duplicates(("AAA",)), pd.DataFrame), pd.DataFrame)`
`385`		`- check(assert_type(df.drop_duplicates({"AAA": None}), pd.DataFrame), pd.DataFrame)`
`386`	`384`	`check(assert_type(df.drop_duplicates("AAA"), pd.DataFrame), pd.DataFrame)`
`387`	`385`
	`386`	`+ if PD_LTE_22:`
	`387`	`+ check(assert_type(df.drop_duplicates({"AAA"}), pd.DataFrame), pd.DataFrame)`
	`388`	`+ check(assert_type(df.drop_duplicates({"AAA": None}), pd.DataFrame), pd.DataFrame)`
	`389`	`+`
`388`	`390`
`389`	`391`	`def test_types_fillna() -> None:`
`390`	`392`	`df = pd.DataFrame(data={"col1": [np.nan, np.nan], "col2": [3, np.nan]})`