Skip to content

Commit 88540bf

Browse files
authored
Merge pull request #11 from mslmio/haris/oxylabs-sdk-fixes
haris/oxylabs-sdk-fixes
2 parents b28a2bd + 22eb591 commit 88540bf

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+2974
-3040
lines changed

CHANGELOG.md

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,22 @@
11
# Changelog
22

3+
## 1.0.2
4+
5+
- Fixed function and class naming.
6+
- Added request timeout in proxy.
7+
- Removed Yandex and Baidu sources from SERP.
8+
39
## 1.0.1
410

511
- Fixed issue with uploaded package.
612

713
## 1.0.0
814

9-
- Initial release of Oxylabs Serp, Ecommerce and Proxy integrations.
15+
- Initial release of Oxylabs SDK.
16+
- Scraper APIs:
17+
- SERP
18+
- Ecommerce
19+
- Integration methods:
20+
- Proxy
21+
- Push-Pull
22+
- Realtime

CONTRIBUTING.md

Lines changed: 49 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ involved. The community looks forward to your contributions.
2222
> answered your question.
2323
2424
Before you ask a question, it is best to search for existing
25-
[Issues](https://github.com/mslmio/oxylabs-sdk-python/issues) that might help you. In
26-
case you have found a suitable issue and still need clarification, you can
27-
write your question in this issue. It is also advisable to search the internet
28-
for answers first.
25+
[Issues](https://github.com/mslmio/oxylabs-sdk-python/issues) that might help
26+
you. In case you have found a suitable issue and still need clarification, you
27+
can write your question in this issue. It is also advisable to search the
28+
internet for answers first.
2929

3030
If you then still feel the need to ask a question and need clarification, we
3131
recommend the following:
@@ -45,6 +45,42 @@ We will then take care of the issue as soon as possible.
4545
> of the content, that you have the necessary rights to the content and that
4646
> the content you contribute may be provided under the project licence.
4747
48+
## Code Formatting
49+
50+
This project uses [Black](https://black.readthedocs.io/en/stable/) and
51+
[isort](https://pycqa.github.io/isort/) for code formatting. Before you submit
52+
your contribution, please make sure your code is formatted according to these
53+
style guides.
54+
55+
First, you will need to install the required tools if you haven't already:
56+
57+
```bash
58+
pip install black isort
59+
```
60+
61+
You can use the provided `fmt.sh` script to automatically format your code.
62+
This script runs `isort` and `black` on the `src` directory. Here's how you can
63+
run it:
64+
65+
```bash
66+
scripts/fmt.sh
67+
```
68+
69+
## Running Tests
70+
71+
To ensure the quality of the code, we encourage you to run tests after making
72+
any changes and before submitting a contribution. We have a script that
73+
facilitates running the unit tests for the project.
74+
75+
To run the tests, use the `tests.sh` script located in the `scripts` directory.
76+
This will execute all the unit tests and report any failures.
77+
78+
Here's how you can run it:
79+
80+
```bash
81+
scripts/tests.sh
82+
```
83+
4884
### Reporting Bugs
4985

5086
#### Before Submitting a Bug Report
@@ -83,11 +119,12 @@ possible.
83119
> including sensitive information to the issue tracker, or elsewhere in public.
84120
> Instead sensitive bugs must be sent by email to .
85121
86-
We use GitHub issues to track bugs and errors. If you run into an issue with the project:
122+
We use GitHub issues to track bugs and errors. If you run into an issue with the
123+
project:
87124

88-
- Open an [Issue](https://github.com/mslmio/oxylabs-sdk-python/issues/new). (Since we
89-
can't be sure at this point whether it is a bug or not, we ask you not to
90-
talk about a bug yet and not to label the issue.)
125+
- Open an [Issue](https://github.com/mslmio/oxylabs-sdk-python/issues/new).
126+
(Since we can't be sure at this point whether it is a bug or not, we ask you
127+
not to talk about a bug yet and not to label the issue.)
91128
- Explain the behavior you would expect and the actual behavior.
92129
- Please provide as much context as possible and describe the *reproduction
93130
steps* that someone else can follow to recreate the issue on their own. This
@@ -119,8 +156,8 @@ community to understand your suggestion and find related suggestions.
119156
- Read the [documentation](https://developers.oxylabs.io/) carefully and
120157
find out if the functionality is already covered, maybe by an individual
121158
configuration.
122-
- Perform a [search](https://github.com/mslmio/oxylabs-sdk-python/issues) to see if
123-
the enhancement has already been suggested. If it has, add a comment to the
159+
- Perform a [search](https://github.com/mslmio/oxylabs-sdk-python/issues) to see
160+
if the enhancement has already been suggested. If it has, add a comment to the
124161
existing issue instead of opening a new one.
125162
- Find out whether your idea fits with the scope and aims of the project. It's
126163
up to you to make a strong case to convince the project's developers of the
@@ -131,7 +168,8 @@ community to understand your suggestion and find related suggestions.
131168

132169
#### How Do I Submit a Good Enhancement Suggestion?
133170

134-
Enhancement suggestions are tracked as [GitHub issues](https://github.com/mslmio/oxylabs-sdk-python/issues).
171+
Enhancement suggestions are tracked as
172+
[GitHub issues](https://github.com/mslmio/oxylabs-sdk-python/issues).
135173

136174
- Use a **clear and descriptive title** for the issue to identify the
137175
suggestion.

0 commit comments

Comments
 (0)