Skip to content

Commit de288e4

Browse files
committed
avfilter/vf_hflip: Remove empty options and AVClass
This filter only had an AVClass and empty options because up until recently, avfilter_init_str() errored out when options were provided for a filter without an AVClass. But setting (generic) options is necessary to take advantage of timeline support. So with avfilter_init_str() fixed, the AVClass and the options can be removed. Signed-off-by: Andreas Rheinhardt <[email protected]>
1 parent 99a200c commit de288e4

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

libavfilter/hflip.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,9 @@
2222
#ifndef AVFILTER_HFLIP_H
2323
#define AVFILTER_HFLIP_H
2424

25-
#include "avfilter.h"
25+
#include <stdint.h>
2626

2727
typedef struct FlipContext {
28-
const AVClass *class;
2928
int max_step[4]; ///< max pixel step for each plane, expressed as a number of bytes
3029
int bayer_plus1; ///< 1 .. not a Bayer input format, 2 .. Bayer input format
3130
int planewidth[4]; ///< width of each plane

libavfilter/vf_hflip.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626

2727
#include <string.h>
2828

29-
#include "libavutil/opt.h"
3029
#include "avfilter.h"
3130
#include "formats.h"
3231
#include "hflip.h"
@@ -38,12 +37,6 @@
3837
#include "libavutil/intreadwrite.h"
3938
#include "libavutil/imgutils.h"
4039

41-
static const AVOption hflip_options[] = {
42-
{ NULL }
43-
};
44-
45-
AVFILTER_DEFINE_CLASS(hflip);
46-
4740
static int query_formats(AVFilterContext *ctx)
4841
{
4942
AVFilterFormats *pix_fmts = NULL;
@@ -155,7 +148,6 @@ const AVFilter ff_vf_hflip = {
155148
.name = "hflip",
156149
.description = NULL_IF_CONFIG_SMALL("Horizontally flip the input video."),
157150
.priv_size = sizeof(FlipContext),
158-
.priv_class = &hflip_class,
159151
FILTER_INPUTS(avfilter_vf_hflip_inputs),
160152
FILTER_OUTPUTS(ff_video_default_filterpad),
161153
FILTER_QUERY_FUNC(query_formats),

libavfilter/vf_hflip_init.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
#include "config.h"
2828
#include "libavutil/attributes.h"
29+
#include "libavutil/error.h"
2930
#include "libavutil/intreadwrite.h"
3031
#include "hflip.h"
3132

0 commit comments

Comments
 (0)