avcodec/h264_ps: Show VUI and SPS overread messages just once per frame thread

michaelni · michaelni · commit d9751a116275 · 2020-02-12T10:25:25.000+01:00
Signed-off-by: Michael Niedermayer &lt;michael@niedermayer.cc&gt;
diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c
@@ -579,7 +579,8 @@ int ff_h264_decode_seq_parameter_set(GetBitContext *gb, AVCodecContext *avctx,
     }
 
     if (get_bits_left(gb) < 0) {
-        av_log(avctx, ignore_truncation ? AV_LOG_WARNING : AV_LOG_ERROR,
+        av_log_once(avctx, ignore_truncation ? AV_LOG_WARNING : AV_LOG_ERROR, AV_LOG_DEBUG,
+                    &ps->overread_warning_printed[sps->vui_parameters_present_flag],
                "Overread %s by %d bits\n", sps->vui_parameters_present_flag ? "VUI" : "SPS", -get_bits_left(gb));
         if (!ignore_truncation)
             goto fail;
diff --git a/libavcodec/h264_ps.h b/libavcodec/h264_ps.h
@@ -144,6 +144,8 @@ typedef struct H264ParamSets {
     /* currently active parameters sets */
     const PPS *pps;
     const SPS *sps;
+
+    int overread_warning_printed[2];
 } H264ParamSets;
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -579,7 +579,8 @@ int ff_h264_decode_seq_parameter_set(GetBitContext gb, AVCodecContext avctx,`
`579`	`579`	`}`
`580`	`580`
`581`	`581`	`if (get_bits_left(gb) < 0) {`
`582`		`- av_log(avctx, ignore_truncation ? AV_LOG_WARNING : AV_LOG_ERROR,`
	`582`	`+ av_log_once(avctx, ignore_truncation ? AV_LOG_WARNING : AV_LOG_ERROR, AV_LOG_DEBUG,`
	`583`	`+ &ps->overread_warning_printed[sps->vui_parameters_present_flag],`
`583`	`584`	`"Overread %s by %d bits\n", sps->vui_parameters_present_flag ? "VUI" : "SPS", -get_bits_left(gb));`
`584`	`585`	`if (!ignore_truncation)`
`585`	`586`	`goto fail;`