Skip to content

Commit 636631d

Browse files
committed
Remove unnecessary libavutil/(avutil|common|internal).h inclusions
Some of these were made possible by moving several common macros to libavutil/macros.h. While just at it, also improve the other headers a bit. Reviewed-by: Martin Storsjö <[email protected]> Signed-off-by: Andreas Rheinhardt <[email protected]>
1 parent 84f16bb commit 636631d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

126 files changed

+260
-178
lines changed

libavcodec/ac3.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@
2424
* Common code between the AC-3 encoder and decoder.
2525
*/
2626

27-
#include "libavutil/common.h"
27+
#include "libavutil/error.h"
28+
#include "libavutil/macros.h"
2829

2930
#include "ac3.h"
3031

libavcodec/ac3.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ typedef int INTFLOAT;
7878
typedef int16_t SHORTFLOAT;
7979

8080
#else /* USE_FIXED */
81+
#include "libavutil/libm.h"
8182

8283
#define FIXR(x) ((float)(x))
8384
#define FIXR12(x) ((float)(x))

libavcodec/ass_split.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,14 @@
1919
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2020
*/
2121

22-
#include "libavutil/common.h"
22+
#include <limits.h>
23+
#include <stddef.h>
24+
#include <stdint.h>
25+
#include <stdio.h>
26+
#include <string.h>
27+
2328
#include "libavutil/error.h"
29+
#include "libavutil/macros.h"
2430
#include "libavutil/mem.h"
2531
#include "ass_split.h"
2632

libavcodec/av1_parse.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@
2424
#include <limits.h>
2525
#include <stdint.h>
2626

27-
#include "libavutil/common.h"
2827
#include "libavutil/error.h"
2928
#include "libavutil/intmath.h"
29+
#include "libavutil/macros.h"
3030

3131
#include "av1.h"
3232
#include "get_bits.h"

libavcodec/bitstream.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@
3636
#include "config.h"
3737
#include "libavutil/avassert.h"
3838
#include "libavutil/bswap.h"
39-
#include "libavutil/common.h"
4039
#include "libavutil/error.h"
4140
#include "libavutil/internal.h"
4241
#include "libavutil/intreadwrite.h"
4342
#include "libavutil/log.h"
43+
#include "libavutil/macros.h"
4444
#include "libavutil/mem.h"
4545
#include "libavutil/qsort.h"
4646
#include "mathops.h"

libavcodec/cabac.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,10 @@
2424
* Context Adaptive Binary Arithmetic Coder.
2525
*/
2626

27-
#include <string.h>
28-
29-
#include "libavutil/common.h"
27+
#include "libavutil/error.h"
3028
#include "libavutil/mem_internal.h"
3129

3230
#include "cabac.h"
33-
#include "cabac_functions.h"
3431

3532
DECLARE_ASM_ALIGNED(1, const uint8_t, ff_h264_cabac_tables)[512 + 4*2*64 + 4*64 + 63] = {
3633
9,8,7,7,6,6,6,6,5,5,5,5,5,5,5,5,

libavcodec/celp_math.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,13 @@
2020
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2121
*/
2222

23-
#include <inttypes.h>
24-
#include <limits.h>
23+
#include <stdint.h>
2524

25+
#include "config.h"
2626
#include "libavutil/avassert.h"
27-
#include "avcodec.h"
27+
#include "libavutil/intmath.h"
2828
#include "mathops.h"
2929
#include "celp_math.h"
30-
#include "libavutil/common.h"
3130

3231
#ifdef G729_BITEXACT
3332
static const uint16_t exp2a[]=

libavcodec/codec_desc.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,11 @@
1919
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2020
*/
2121

22+
#include <stdlib.h>
2223
#include <string.h>
2324

24-
#include "libavutil/common.h"
2525
#include "libavutil/internal.h"
26+
#include "libavutil/macros.h"
2627

2728
#include "codec_id.h"
2829
#include "codec_desc.h"

libavcodec/dca_exss.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
#ifndef AVCODEC_DCA_EXSS_H
2222
#define AVCODEC_DCA_EXSS_H
2323

24-
#include "libavutil/common.h"
24+
#include <stdint.h>
2525

2626
#include "avcodec.h"
2727
#include "get_bits.h"

libavcodec/dcadct.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1919
*/
2020

21-
#include "libavutil/common.h"
21+
#include <stdlib.h>
2222

2323
#include "dcadct.h"
2424
#include "dcamath.h"

libavcodec/dcadct.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
#ifndef AVCODEC_DCADCT_H
2222
#define AVCODEC_DCADCT_H
2323

24-
#include "libavutil/common.h"
24+
#include <stdint.h>
25+
#include "libavutil/attributes.h"
2526

2627
typedef struct DCADCTContext {
2728
void (*imdct_half[2])(int32_t *output, const int32_t *input);

libavcodec/dcadec.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,11 @@
2121
#ifndef AVCODEC_DCADEC_H
2222
#define AVCODEC_DCADEC_H
2323

24-
#include "libavutil/common.h"
24+
#include <stdint.h>
25+
2526
#include "libavutil/crc.h"
2627
#include "libavutil/float_dsp.h"
28+
#include "libavutil/log.h"
2729

2830
#include "avcodec.h"
2931
#include "get_bits.h"

libavcodec/dcahuff.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
#include <stddef.h>
2424

2525
#include "libavutil/avassert.h"
26-
#include "libavutil/common.h"
26+
#include "libavutil/macros.h"
2727

2828
#include "dcahuff.h"
2929
#include "put_bits.h"

libavcodec/dirac_vlc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#ifndef AVCODEC_DIRAC_VLC_H
2020
#define AVCODEC_DIRAC_VLC_H
2121

22-
#include "libavutil/avutil.h"
22+
#include <stdint.h>
2323

2424
int ff_dirac_golomb_read_16bit(const uint8_t *buf, int bytes,
2525
uint8_t *_dst, int coeffs);

libavcodec/dnxhddata.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,11 @@
1919
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2020
*/
2121

22+
#include <stddef.h>
23+
#include "libavutil/log.h"
24+
#include "libavutil/macros.h"
2225
#include "avcodec.h"
2326
#include "dnxhddata.h"
24-
#include "libavutil/common.h"
2527

2628
/* The quantization tables below are in zigzag order! */
2729

libavcodec/dnxhddata.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@
2424

2525
#include <stdint.h>
2626
#include "avcodec.h"
27-
#include "libavutil/internal.h"
27+
#include "libavutil/attributes.h"
2828
#include "libavutil/intreadwrite.h"
29+
#include "libavutil/rational.h"
2930

3031
/** Additional profile info flags */
3132
#define DNXHD_INTERLACED (1<<0)

libavcodec/dv_profile.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@
1818

1919
#include "config.h"
2020

21+
#include <stddef.h>
2122
#include <stdint.h>
2223

23-
#include "libavutil/common.h"
2424
#include "libavutil/intreadwrite.h"
2525
#include "libavutil/log.h"
26+
#include "libavutil/macros.h"
2627
#include "libavutil/pixdesc.h"
2728

2829
#include "avcodec.h"

libavcodec/elsdec.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,14 @@
2525
* Entropy Logarithmic-Scale binary arithmetic decoder
2626
*/
2727

28-
#include <math.h>
28+
#include <stddef.h>
2929
#include <stdint.h>
30+
#include <string.h>
3031

31-
#include "libavutil/common.h"
32+
#include "libavutil/error.h"
3233
#include "libavutil/intreadwrite.h"
34+
#include "libavutil/macros.h"
35+
#include "libavutil/mem.h"
3336

3437
#include "elsdec.h"
3538

libavcodec/exrdsp.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
#ifndef AVCODEC_EXRDSP_H
2020
#define AVCODEC_EXRDSP_H
2121

22+
#include <stddef.h>
2223
#include <stdint.h>
23-
#include "libavutil/common.h"
2424

2525
typedef struct ExrDSPContext {
2626
void (*reorder_pixels)(uint8_t *dst, const uint8_t *src, ptrdiff_t size);

libavcodec/flacdsp.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
*/
2020

2121
#include "libavutil/attributes.h"
22+
#include "libavutil/internal.h"
2223
#include "libavutil/samplefmt.h"
2324
#include "flacdsp.h"
2425
#include "config.h"

libavcodec/flacdsp.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#define AVCODEC_FLACDSP_H
2121

2222
#include <stdint.h>
23-
#include "libavutil/internal.h"
23+
2424
#include "libavutil/samplefmt.h"
2525

2626
typedef struct FLACDSPContext {

libavcodec/flacdsp_lpc_template.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
*/
1818

1919
#include <stdint.h>
20-
#include "libavutil/avutil.h"
20+
#include "libavutil/common.h"
2121
#include "mathops.h"
2222

2323
#undef FUNC

libavcodec/flacdsp_template.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
*/
2020

2121
#include <stdint.h>
22-
#include "libavutil/avutil.h"
22+
#include "libavutil/macros.h"
2323

2424
#undef FUNC
2525
#undef FSUF

libavcodec/fmtconvert.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@
2020
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2121
*/
2222

23+
#include "config.h"
24+
#include "libavutil/attributes.h"
2325
#include "avcodec.h"
2426
#include "fmtconvert.h"
25-
#include "libavutil/common.h"
2627

2728
static void int32_to_float_fmul_scalar_c(float *dst, const int32_t *src,
2829
float mul, int len)

libavcodec/golomb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
* @author Michael Niedermayer <[email protected]>
2727
*/
2828

29-
#include "libavutil/common.h"
29+
#include <stdint.h>
3030

3131
const uint8_t ff_golomb_vlc_len[512]={
3232
19,17,15,15,13,13,13,13,11,11,11,11,11,11,11,11,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,

libavcodec/h264_levels.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
*/
1818

1919
#include <stddef.h>
20-
#include "libavutil/common.h"
20+
#include "libavutil/macros.h"
2121
#include "h264_levels.h"
2222

2323
// H.264 table A-1.

libavcodec/h264_redundant_pps_bsf.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,17 @@
1616
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1717
*/
1818

19-
#include <string.h>
19+
#include <inttypes.h>
2020

21-
#include "libavutil/common.h"
21+
#include "libavutil/log.h"
2222

2323
#include "bsf.h"
24-
#include "bsf_internal.h"
2524
#include "cbs.h"
2625
#include "cbs_bsf.h"
2726
#include "cbs_h264.h"
27+
#include "codec_id.h"
2828
#include "h264.h"
29+
#include "packet.h"
2930

3031
#define NEW_GLOBAL_PIC_INIT_QP 26
3132

libavcodec/h264_sei.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@
2828
#include <limits.h>
2929
#include <stdio.h>
3030
#include <string.h>
31-
#include "libavutil/common.h"
3231
#include "libavutil/error.h"
3332
#include "libavutil/log.h"
33+
#include "libavutil/macros.h"
3434
#include "libavutil/mem.h"
3535
#include "atsc_a53.h"
3636
#include "get_bits.h"

libavcodec/huffman.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,11 @@
2626

2727
#include <stdint.h>
2828

29+
#include "libavutil/error.h"
30+
#include "libavutil/log.h"
31+
#include "libavutil/macros.h"
32+
#include "libavutil/mem.h"
2933
#include "libavutil/qsort.h"
30-
#include "libavutil/common.h"
3134

3235
#include "huffman.h"
3336
#include "vlc.h"

libavcodec/jfdctfst.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,8 @@
6666
* Independent JPEG Group's fast AAN dct.
6767
*/
6868

69-
#include <stdlib.h>
70-
#include <stdio.h>
71-
#include "libavutil/common.h"
69+
#include <stdint.h>
70+
#include "libavutil/attributes.h"
7271
#include "dct.h"
7372

7473
#define DCTSIZE 8

libavcodec/jpeg2000dwt.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
* Discrete wavelet transform
2626
*/
2727

28-
#include "libavutil/common.h"
28+
#include "libavutil/error.h"
29+
#include "libavutil/macros.h"
2930
#include "libavutil/mem.h"
3031
#include "jpeg2000dwt.h"
3132

libavcodec/jrevdct.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,9 @@
6262
* Independent JPEG Group's LLM idct.
6363
*/
6464

65-
#include "libavutil/common.h"
65+
#include <stddef.h>
66+
#include <stdint.h>
67+
6668
#include "libavutil/intreadwrite.h"
6769

6870
#include "dct.h"

libavcodec/lagarithrac.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
#define AVCODEC_LAGARITHRAC_H
3232

3333
#include <stdint.h>
34-
#include "libavutil/common.h"
3534
#include "libavutil/intreadwrite.h"
3635
#include "avcodec.h"
3736
#include "get_bits.h"

libavcodec/libopus.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
#include <opus_defines.h>
2323

24-
#include "libavutil/common.h"
2524
#include "libavutil/error.h"
2625
#include "libopus.h"
2726

libavcodec/lsp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2222
*/
2323

24-
#include <inttypes.h>
24+
#include <math.h>
2525

2626
#define FRAC_BITS 14
27-
#include "libavutil/common.h"
27+
#include "libavutil/macros.h"
2828
#include "mathops.h"
2929
#include "lsp.h"
3030
#include "libavcodec/mips/lsp_mips.h"

0 commit comments

Comments
 (0)