Fix Darwin OSLog composition failure in historical logs (#594)

Fixes #588

## Description
This PR fixes an issue where logs on macOS (using `DarwinKLogger`) would show `<compose failure>` when viewed in historical logs (via `log show` or Console.app), despite appearing correctly in live logs (`log stream`).

The issue was caused by passing a dynamically allocated format string to `os_log`. Apple's `os_log` system requires the format string to be a C string literal located in the `__TEXT,__oslogstring` section of the binary for security and privacy (redaction) reasons. Wrappers or dynamic strings do not satisfy this requirement by default, causing the logging system to fail composition during archival.

## Solution
Implemented a C-interop solution to provide a valid static format string to `os_log`:

1.  **Added C-Interop Definition (`oslog.def`)**: Created a C header/def file that defines a static inline function `kotlin_logging_os_log`.
    ```c
    static inline void kotlin_logging_os_log(os_log_t log, os_log_type_t type, const char* message) {
        os_log_with_type(log, type, "%{public}s", message);
    }
    ```
    This function uses `"%{public}s"` as a constant C string literal, which `clang` places in the correct section.

2.  **Updated Build Configuration (`build.gradle.kts`)**: Configured all Darwin targets to include this C-interop definition.

3.  **Updated `DarwinKLogger`**: Modified `DarwinKLogger.kt` to call `kotlin_logging_os_log` instead of `_os_log_internal`.

## Verification
- Added `Issue588Test` to reproduce the issue.
- Verified that logs are successfully persisted and readable using `log show`:
  ```bash
  log show --predicate 'processImagePath CONTAINS "test.kexe"' --info --style syslog --last 5m
  ```
- Confirmed output contains the log message instead of `<compose failure>`.

Author: oshai

build.gradle.kts

@@ -271,6 +271,10 @@ kotlin {
             getByName("${it.targetName}Test") {
                 dependsOn(darwinTest)
             }
+            val main by it.compilations.getting
+            val oslog by main.cinterops.creating {
+                defFile(project.file("src/darwinMain/cinterop/oslog.def"))
+            }
         }
     }
 }
@@ -407,3 +411,11 @@ tasks.withType<AbstractPublishToMaven>().configureEach {
     mustRunAfter(signingTasks)
 }
 //endregion
+
+// Fix implicit dependency issue for native MetadataElements tasks
+// "Declare an explicit dependency on ':commonizeCInterop' from ':*MetadataElements' using Task#dependsOn"
+tasks.matching {
+    it.name.matches("^(linux|mingw|androidNative|macos|ios|watchos|tvos).*MetadataElements$".toRegex())
+}.configureEach {
+    dependsOn("commonizeCInterop")
+}

gradle.properties

@@ -5,4 +5,5 @@ org.gradle.jvmargs=-Xmx2048m
 kotlin.mpp.androidSourceSetLayoutVersion=2
 kotlin.mpp.applyDefaultHierarchyTemplate=false
 # Allow inconsistent JVM targets: Kotlin targets 1.8 (for compatibility), but module-info.java requires 9+.
-kotlin.jvm.target.validation.mode=warning
+kotlin.jvm.target.validation.mode=ignore
+kotlin.mpp.enableCInteropCommonization=true

src/darwinMain/cinterop/oslog.def

@@ -0,0 +1,10 @@
+package = io.github.oshai.kotlinlogging.cinterop
+language = Objective-C
+headers = os/log.h
+
+---
+#include <os/log.h>
+
+static inline void kotlin_logging_os_log(os_log_t log, os_log_type_t type, const char* message) {
+    os_log_with_type(log, type, "%{public}s", message);
+}

src/darwinMain/kotlin/io/github/oshai/kotlinlogging/DarwinKLogger.kt

@@ -2,15 +2,13 @@
 
 package io.github.oshai.kotlinlogging
 
+import io.github.oshai.kotlinlogging.cinterop.kotlin_logging_os_log
 import io.github.oshai.kotlinlogging.internal.DarwinFormatter
 import kotlinx.cinterop.ExperimentalForeignApi
-import kotlinx.cinterop.ptr
 import platform.darwin.OS_LOG_TYPE_DEBUG
 import platform.darwin.OS_LOG_TYPE_DEFAULT
 import platform.darwin.OS_LOG_TYPE_ERROR
 import platform.darwin.OS_LOG_TYPE_INFO
-import platform.darwin.__dso_handle
-import platform.darwin._os_log_internal
 import platform.darwin.os_log_t
 import platform.darwin.os_log_type_enabled
 import platform.darwin.os_log_type_t
@@ -21,16 +19,17 @@ public class DarwinKLogger(override val name: String, override val underlyingLog
   override fun at(level: Level, marker: Marker?, block: KLoggingEventBuilder.() -> Unit) {
     if (isLoggingEnabledFor(level, marker)) {
       KLoggingEventBuilder().apply(block).run {
-        val formattedMessage: String = DarwinFormatter.getFormattedMessage(this, marker)
-        _os_log_internal(
-          __dso_handle.ptr,
-          underlyingLogger,
-          level.toDarwinLevel(),
-          // Use %{public}s to prevent redaction of the log message in historical logs (log show)
-          // See https://github.com/oshai/kotlin-logging/issues/588
-          "%{public}s",
-          formattedMessage,
-        )
+        val message = DarwinFormatter.getFormattedMessage(this, marker)
+        val formattedMessage =
+          if (marker != null) {
+            // Separating marker and message because OSLog doesn't have a way to pass marker as a
+            // separate argument
+            // formatting manually to string for now
+            "$marker $message"
+          } else {
+            message
+          }
+        kotlin_logging_os_log(underlyingLogger, level.toDarwinLevel(), formattedMessage)
       }
     }
   }

src/darwinMain/kotlin/io/github/oshai/kotlinlogging/internal/KLoggingClock.kt

@@ -2,4 +2,4 @@ package io.github.oshai.kotlinlogging.internal
 
 import kotlin.system.getTimeMillis
 
-public actual fun getCurrentTime(): Long = getTimeMillis()
+@Suppress("DEPRECATION") public actual fun getCurrentTime(): Long = getTimeMillis()

src/darwinTest/kotlin/io/github/oshai/kotlinlogging/Issue588Test.kt

@@ -0,0 +1,15 @@
+package io.github.oshai.kotlinlogging
+
+import kotlin.test.Test
+import platform.Foundation.NSUUID
+
+class Issue588Test {
+  @Test
+  fun testHistoricalLogging() {
+    val uuid = NSUUID().UUIDString
+    val logger = KotlinLogging.logger("issue588.repro")
+
+    logger.info { "Test message execution $uuid" }
+    logger.error { "Test error execution $uuid" }
+  }
+}

src/jvmMain/kotlin/io/github/oshai/kotlinlogging/KLogging.kt

@@ -12,12 +12,14 @@ package io.github.oshai.kotlinlogging
  * ```
  */
 @Deprecated("Use KLogger instead", ReplaceWith("KLogger", "io.github.oshai.kotlinlogging.KLogger"))
+@Suppress("DEPRECATION")
 public open class KLogging : KLoggable {
   override val logger: KLogger = logger()
 }
 
 /** A class with logging capabilities and explicit logger name */
 @Deprecated("Use KLogger instead", ReplaceWith("KLogger", "io.github.oshai.kotlinlogging.KLogger"))
+@Suppress("DEPRECATION")
 public open class NamedKLogging(name: String) : KLoggable {
   override val logger: KLogger = logger(name)
 }

src/jvmMain/kotlin/io/github/oshai/kotlinlogging/logback/internal/LogbackLogEvent.kt

@@ -41,6 +41,7 @@ internal class LogbackLogEvent(
   override fun getMessage(): String =
     kLoggingEvent.internalCompilerData?.messageTemplate ?: kLoggingEvent.message ?: ""
 
+  @Suppress("UNCHECKED_CAST")
   override fun getArgumentArray(): Array<Object>? = kLoggingEvent.arguments as? Array<Object>
 
   override fun getFormattedMessage(): String? = kLoggingEvent.message

src/nativeMain/kotlin/io/github/oshai/kotlinlogging/internal/KLoggingClock.kt

@@ -2,4 +2,4 @@ package io.github.oshai.kotlinlogging.internal
 
 import kotlin.system.getTimeMillis
 
-public actual fun getCurrentTime(): Long = getTimeMillis()
+@Suppress("DEPRECATION") public actual fun getCurrentTime(): Long = getTimeMillis()