Resolve a few static analysis warnings.

Author: mikehearn

espresso/src/com.oracle.truffle.espresso.jdwp/src/com/oracle/truffle/espresso/jdwp/impl/JDWP.java

@@ -2730,6 +2730,7 @@ static CommandResult createReply(Packet packet, JDWPContext context) {
                         writeValue(sigbyte, value, reply, true, context);
                     }
                 } catch (ArrayIndexOutOfBoundsException | InteropException ex) {
+                    ex.printStackTrace();
                     // invalid slot provided
                     reply.errorCode(ErrorCodes.INVALID_SLOT);
                     return new CommandResult(reply);

espresso/src/com.oracle.truffle.espresso.libjavavm/src/com/oracle/truffle/espresso/libjavavm/arghelper/PolyglotArgs.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -149,18 +149,15 @@ void parsePolyglotOption(String group, String key, String value, String arg, boo
 
     private OptionDescriptor findOptionDescriptor(String group, String key) {
         OptionDescriptors descriptors = null;
-        switch (group) {
-            case "engine":
-                descriptors = getTempEngine().getOptions();
-                break;
-            default:
-                Engine engine = getTempEngine();
-                if (engine.getLanguages().containsKey(group)) {
-                    descriptors = engine.getLanguages().get(group).getOptions();
-                } else if (engine.getInstruments().containsKey(group)) {
-                    descriptors = engine.getInstruments().get(group).getOptions();
-                }
-                break;
+        if (group.equals("engine")) {
+            descriptors = getTempEngine().getOptions();
+        } else {
+            Engine engine = getTempEngine();
+            if (engine.getLanguages().containsKey(group)) {
+                descriptors = engine.getLanguages().get(group).getOptions();
+            } else if (engine.getInstruments().containsKey(group)) {
+                descriptors = engine.getInstruments().get(group).getOptions();
+            }
         }
         if (descriptors == null) {
             return null;
@@ -219,7 +216,7 @@ static final class PrintableOption implements Comparable<PrintableOption> {
         final String option;
         final String description;
 
-        protected PrintableOption(String option, String description) {
+        private PrintableOption(String option, String description) {
             this.option = option;
             this.description = description;
         }
@@ -231,21 +228,12 @@ public int compareTo(PrintableOption o) {
     }
 
     private static String optionsTitle(String kind, OptionCategory optionCategory) {
-        String category;
-        switch (optionCategory) {
-            case USER:
-                category = "User ";
-                break;
-            case EXPERT:
-                category = "Expert ";
-                break;
-            case INTERNAL:
-                category = "Internal ";
-                break;
-            default:
-                category = "";
-                break;
-        }
+        String category = switch (optionCategory) {
+            case USER -> "User ";
+            case EXPERT -> "Expert ";
+            case INTERNAL -> "Internal ";
+            default -> "";
+        };
         return category + kind + " options:";
     }
 
@@ -279,9 +267,7 @@ private static PrintableOption asPrintableOption(OptionDescriptor descriptor) {
         StringBuilder key = new StringBuilder("--");
         key.append(descriptor.getName());
         Object defaultValue = descriptor.getKey().getDefaultValue();
-        if (defaultValue instanceof Boolean && defaultValue == Boolean.FALSE) {
-            // nothing to print
-        } else {
+        if (defaultValue != Boolean.FALSE) {
             key.append("=<");
             key.append(descriptor.getKey().getType().getName());
             key.append(">");