extract missing_notify to newly created ci-check.libsonnet

Author: wirthi

ci-check.libsonnet

@@ -0,0 +1,14 @@
+local std_get = (import 'common-utils.libsonnet').std_get;
+
+{
+  # check that all non [gate, ondemand] entries have notify_emails or notify_groups defined
+  local missing_notify(builds) = {
+    [x.name]: $.std_get(x, "defined_in") for x in builds if !std.objectHas(x, "notify_emails") && !std.objectHasAll(x, "notify_groups") && (std.member(x.targets, "daily") || std.member(x.targets, "weekly") || std.member(x.targets, "monthly"))
+  },
+  
+  verify_ci(builds)::
+    local missingNotify = missing_notify(builds);
+    assert std.length(missingNotify) == 0 : "Missing notify_emails or notify_groups: " + missingNotify;
+    true
+  ,
+}

ci.jsonnet

@@ -35,7 +35,7 @@ local javadoc = import "ci_includes/publish-javadoc.jsonnet";
 # VM
 local vm = import 'vm/ci/ci_includes/vm.jsonnet';
 
-local missing_notify = (import 'common-utils.libsonnet').missing_notify;
+local verify_ci = (import 'ci-check.libsonnet').verify_ci;
 
 {
   # Ensure that entries in common.jsonnet can be resolved.
@@ -56,6 +56,5 @@ local missing_notify = (import 'common-utils.libsonnet').missing_notify;
     javadoc.builds +
     vm.builds
   )],
-  missingNotify:: missing_notify(self.builds),
-  assert std.length(self.missingNotify) == 0 : "Missing notify_emails or notify_groups: " + self.missingNotify,
+  assert verify_ci(self.builds),
 }

common-utils.libsonnet

@@ -94,8 +94,4 @@
     if objectHas(o, f) then o[f] else default
   ,
 
-  # check that all non [gate, ondemand] entries have notify_emails or notify_groups defined
-  missing_notify(builds):: {
-    [x.name]: $.std_get(x, "defined_in") for x in builds if !std.objectHas(x, "notify_emails") && !std.objectHasAll(x, "notify_groups") && (std.member(x.targets, "daily") || std.member(x.targets, "weekly") || std.member(x.targets, "monthly"))
-  },
 }