[GR-42811] Use JsonWriter for build output JSON.

PullRequest: graal/13338

Author: fniephaus

docs/reference-manual/native-image/README.md

@@ -228,6 +228,9 @@ Below, example commands are listed per operating system:
 # Ring the terminal bell
 native-image -jar App.jar ... ; printf '\a'
 
+# Use libnotify to create a desktop notification
+native-image -jar App.jar ... ; notify-send "GraalVM Native Image build completed with exit code $?"
+
 # Use Zenity to open an info dialog box with text
 native-image -jar App.jar ... ; zenity --info --text="GraalVM Native Image build completed with exit code $?"
 ```

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/util/ExitStatus.java

@@ -24,6 +24,7 @@
  */
 package com.oracle.svm.core.util;
 
+/** Exit status codes to be used at build time (in driver and builder). */
 public enum ExitStatus {
     OK(0),
     BUILDER_ERROR(1),

substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/util/json/JsonWriter.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019, 2019, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2019, 2022, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -30,6 +30,8 @@
 import java.nio.file.Files;
 import java.nio.file.OpenOption;
 import java.nio.file.Path;
+import java.util.Iterator;
+import java.util.Map;
 
 public class JsonWriter implements AutoCloseable {
     private final Writer writer;
@@ -54,15 +56,42 @@ public JsonWriter append(String s) throws IOException {
         return this;
     }
 
+    @SuppressWarnings("unchecked")
+    public void print(Map<String, Object> map) throws IOException {
+        if (map.isEmpty()) {
+            append("{}");
+            return;
+        }
+        append('{');
+        Iterator<String> keySetIter = map.keySet().iterator();
+        while (keySetIter.hasNext()) {
+            String key = keySetIter.next();
+            Object value = map.get(key);
+            quote(key).append(':');
+            if (value instanceof Map) {
+                print((Map<String, Object>) value); // Must always be <String, Object>
+            } else {
+                quote(value);
+            }
+            if (keySetIter.hasNext()) {
+                append(',');
+            }
+        }
+        append('}');
+    }
+
     public JsonWriter quote(Object o) throws IOException {
         if (o == null) {
             return append("null");
         } else if (Boolean.TRUE.equals(o)) {
             return append("true");
         } else if (Boolean.FALSE.equals(o)) {
             return append("false");
+        } else if (o instanceof Number) {
+            return append(o.toString());
+        } else {
+            return quote(o.toString());
         }
-        return quote(o.toString());
     }
 
     public JsonWriter quote(String s) throws IOException {

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/ProgressReporterJsonHelper.java

@@ -26,17 +26,16 @@
 package com.oracle.svm.hosted;
 
 import java.io.File;
-import java.io.PrintWriter;
+import java.io.IOException;
 import java.lang.management.ManagementFactory;
 import java.lang.management.OperatingSystemMXBean;
 import java.nio.file.Path;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.Map;
-import java.util.function.Consumer;
 
 import com.oracle.graal.pointsto.reports.ReportUtils;
 import com.oracle.svm.core.util.VMError;
+import com.oracle.svm.core.util.json.JsonWriter;
 
 class ProgressReporterJsonHelper {
     protected static final long UNAVAILABLE_METRIC = -1;
@@ -108,51 +107,13 @@ public Path printToFile() {
         recordSystemFixedValues();
         final File file = new File(jsonOutputFile);
         String description = "image statistics in json";
-        return ReportUtils.report(description, file.getAbsoluteFile().toPath(), getReporter(), false);
-    }
-
-    private Consumer<PrintWriter> getReporter() {
-        return out -> {
-            out.println(toJson());
-        };
-    }
-
-    private String toJson() {
-        return mapToJson(statsHolder);
-    }
-
-    private String mapToJson(Map<String, Object> map) {
-        // base case
-        if (map.isEmpty()) {
-            return "{}";
-        }
-        StringBuilder builder = new StringBuilder();
-        builder.append("{");
-        Iterator<String> keySetIter = map.keySet().iterator();
-        while (keySetIter.hasNext()) {
-            String key = keySetIter.next();
-            Object value = map.get(key);
-            builder.append("\"" + key + "\":");
-            if (value == null) {
-                builder.append("null"); // null string
-            } else if (value instanceof Map) {
-                // Always a <String, Object> map
-                @SuppressWarnings("unchecked")
-                Map<String, Object> subMap = (Map<String, Object>) value;
-                builder.append(mapToJson(subMap));
-            } else if (value instanceof String) {
-                builder.append("\"" + value + "\"");
-            } else {
-                assert value instanceof Number;
-                // Numeric value
-                builder.append(value);
+        return ReportUtils.report(description, file.getAbsoluteFile().toPath(), out -> {
+            try {
+                new JsonWriter(out).print(statsHolder);
+            } catch (IOException e) {
+                throw VMError.shouldNotReachHere("Failed to create " + jsonOutputFile, e);
             }
-            if (keySetIter.hasNext()) {
-                builder.append(",");
-            }
-        }
-        builder.append("}");
-        return builder.toString();
+        }, false);
     }
 
     interface JsonMetric {