Skip to content

Commit 24f037c

Browse files
committed
Automation Toolkit Release v2024.4.1
1 parent 59d8eb9 commit 24f037c

File tree

4 files changed

+30
-14
lines changed

4 files changed

+30
-14
lines changed

cd3_automation_toolkit/Identity/Users/export_users_nonGreenField.py

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,22 @@ def map_columns(col_header):
3838
column_map = {
3939
"Region": ct.home_region.capitalize(),
4040
"User Name": username,
41-
"Family Name": family_name,
42-
"First Name": given_name,
41+
"Family Name": family_name if hasattr(user_info, 'name') else "",
42+
"First Name": given_name if hasattr(user_info, 'name') else "",
4343
"Description": description,
44-
"Display Name": display_name,
44+
"Display Name": display_name if hasattr(user_info, 'display_name') else "",
4545
"User Email": email,
4646
"Recovery Email": recovery_email,
4747
"Domain Name": domain_key,
4848
"Defined Tags": str(user_defined_tags) if user_defined_tags else "",
4949
"Enable Capabilities": add_capabilities(user_info),
50-
"Middle Name": user_info.name.middle_name,
51-
"Prefix": user_info.name.honorific_prefix,
52-
"Home Phone Number": next((phone.value for phone in user_info.phone_numbers if phone.type == "home"), None) if user_info.phone_numbers else None,
53-
"Mobile Phone Number": next((phone.value for phone in user_info.phone_numbers if phone.type == "mobile"), None) if user_info.phone_numbers else None
50+
"Middle Name": getattr(user_info.name, 'middle_name', "") if hasattr(user_info, 'name') else "",
51+
"Prefix": getattr(user_info.name, 'honorific_prefix', "") if hasattr(user_info, 'name') else "",
52+
"Home Phone Number": next((phone.value for phone in user_info.phone_numbers if phone.type == "home"), None)
53+
if hasattr(user_info, 'phone_numbers') and user_info.phone_numbers else None,
54+
"Mobile Phone Number": next((phone.value for phone in user_info.phone_numbers if phone.type == "mobile"),
55+
None)
56+
if hasattr(user_info, 'phone_numbers') and user_info.phone_numbers else None
5457
}
5558
return column_map.get(col_header, None)
5659

@@ -107,7 +110,8 @@ def export_users(inputfile, outdir, service_dir, config, signer, ct,export_domai
107110
if ct.identity_domain_enabled:
108111
for domain_key, idcs_endpoint in export_domains.items():
109112
domain_name = domain_key.split("@")[1]
110-
domain_client = oci.identity_domains.IdentityDomainsClient(config, idcs_endpoint)
113+
domain_client = oci.identity_domains.IdentityDomainsClient(config=config, signer=signer,
114+
service_endpoint=idcs_endpoint)
111115
users = domain_client.list_users()
112116
index = 0
113117
for user in users.data.resources:
@@ -164,14 +168,17 @@ def export_users(inputfile, outdir, service_dir, config, signer, ct,export_domai
164168
username = user_info.name
165169
description = user_info.description
166170
email = user_info.email
171+
user_defined_tags = []
167172
tf_name = commonTools.check_tf_variable(username)
168173
import_user_id = user_info.id
169174
tf_resource = f'module.iam-users[\\"{str(tf_name)}\\"].oci_identity_user.user'
170175
if tf_resource not in state["resources"]:
171176
importCommands += f'\n{tf_or_tofu} import "{tf_resource}" "{import_user_id}"'
172177

173178
count_u += 1
174-
append_user_info(values_for_column_users,sheetName_users, ct, user_info, username, "", description, email, "", [])
179+
#append_user_info(values_for_column_users,sheetName_users, ct, user_info, username, "", description, email, "", [])
180+
append_user_info(values_for_column_users, sheet_dict_users, ct, user_info, username, "", "", "", "",
181+
description, email, "", user_defined_tags)
175182

176183
if user.capabilities:
177184
tf_resource = f'module.iam-users[\\"{str(tf_name)}\\"].oci_identity_user_capabilities_management.user_capabilities_management[0]'

cd3_automation_toolkit/Identity/export_identity_nonGreenField.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,8 @@ def process_group(grp_info, members_list,membership_id_list, domain_name, is_dyn
357357
if ct.identity_domain_enabled:
358358
for domain_key, idcs_endpoint in export_domains.items():
359359
domain_name = domain_key.split("@")[1]
360-
domain_client = oci.identity_domains.IdentityDomainsClient(config, idcs_endpoint)
360+
domain_client = oci.identity_domains.IdentityDomainsClient(config=config, signer=signer,
361+
service_endpoint=idcs_endpoint)
361362
groups = domain_client.list_groups(attributes=['members'], attribute_sets=['all'])
362363
dyngroups = domain_client.list_dynamic_resource_groups(attributes=['matching_rule'], attribute_sets=['all'])
363364

cd3_automation_toolkit/Release-Notes

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,16 @@ Sep 30th, 2024
44
-------------------------------------
55
1. Call CD3 Validator for services while invoking create workflow for that service.
66
2. Multi Prefix Support using Jenkins. Toolkit can be setup for multiple prefixes by specifying different values in tenancyconfig.properties.
7-
3. OCI RM Stack enhancements - disable legacy IMDS endpoints, enable in transit encryption, enable bastion plugin, specify custom boot volume size.
8-
4. Bug fixes - skip cross tenancy RPC, KMS fix, identity domain users/groups terraform modules, fetch compatible image OCIDs during createTenancyConfig.py
7+
3. CD3 VM RM Stack enhancements -
8+
a. disable legacy IMDS endpoints
9+
b. enable in transit encryption
10+
c. enable bastion plugin
11+
d. specify custom boot volume size.
12+
4. Bug fixes/Enhancements -
13+
a. Skip cross tenancy RPCs while exporting network components.
14+
b. Support for cross region replication feature for default vault as well.
15+
c. Identity domain users/groups terraform modules enhancement to support optional attributes.
16+
d. Fetch compatible image OCIDs during createTenancyConfig.py
917

1018
-------------------------------------
1119
CD3 Automation Toolkit Tag v2024.4.0

cd3_automation_toolkit/user-scripts/terraform/modules/identity/identity-domain-group/main.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
locals {
99
user_ids = {
1010
for user in data.oci_identity_domains_users.users.users :
11-
user.user_name => user.id
11+
user.user_name => user.id...
1212
}
1313
}
1414

@@ -33,7 +33,7 @@ resource "oci_identity_domains_group" "group" {
3333
for_each = {for k in var.members: k=>k}
3434
content {
3535
type = "User"
36-
value = local.user_ids[members.value]
36+
value = local.user_ids[members.value][0]
3737
}
3838
}
3939
urnietfparamsscimschemasoracleidcsextensionrequestable_group {

0 commit comments

Comments
 (0)