[change:tests] Switch to ChannelsLiveServerTestCase #466 #465
Conversation
dee077
changed the title
Replaced StaticLiveServerTestCase with ChannelsLiveServerTestCase to resolve JS errors caused by failed websocket connections. Fixes openwisp#466
dee077
force-pushed
the
issues/904-change-to-ChannelsLiveServerTestCase
branch
from
ee2d9f8 to
3d223e8
Compare
github-project-automation
bot
moved this to To do (general)
in OpenWISP Contributor's Board
| 'ENGINE': 'django.db.backends.sqlite3', | ||
| 'NAME': 'openwisp_utils.db', | ||
| 'TEST': { | ||
| 'NAME': 'openwisp_utils_test.db', |
There was a problem hiding this comment.
Why is this needed?
Without this, it was causing this error
raise ImproperlyConfigured(
django.core.exceptions.ImproperlyConfigured: ChannelLiveServerTestCase can not be used with in memory databases
As the ASGI server requires a physical database
|
|
||
|
|
||
| class TestMenu(SeleniumTestMixin, StaticLiveServerTestCase): | ||
| class TestMenu(SeleniumTestMixin, ChannelsLiveServerTestCase): |
There was a problem hiding this comment.
Let's tag all these tests (as we're doing in other modules for the selenium tests) so we can exclude them from the parallel run.
| @@ -86,7 +86,7 @@ jobs: | |||
| - name: Tests | |||
| if: ${{ !cancelled() && steps.deps.conclusion == 'success' }} | |||
| run: | | |||
| coverage run runtests.py --parallel | |||
| coverage run runtests.py | |||
There was a problem hiding this comment.
Once we have tagged the tests, we can modify the runtests.py script to handle which tests must not be run in parallel.
Since this can get complex in each module, I insisted with @pandafy that we hide this complexity from contributors in the runtests.py script, which thanks to a few lines of comments is also useful to us maintainers to remember why it's done that way.
See the runtests.py script in the controller module:
https://github.com/openwisp/openwisp-controller/blob/master/runtests.py#L46-L47
There is an open issue in django channels for ChannelsLiveServerTestCase is broken in django 5.2 |
Replaced StaticLiveServerTestCase with ChannelsLiveServerTestCase to resolve JS errors caused by failed websocket connections.
Fixes #466
Checklist
Reference to Existing Issue
Closes #466.
Description of Changes
Issues