Skip to content

Commit 1eed8a1

Browse files
PabloCastellanonepython
authored andcommitted
[admin] Fix crash due to already removed column: Metric.description
1 parent e4b2dbd commit 1eed8a1

File tree

2 files changed

+21
-12
lines changed

2 files changed

+21
-12
lines changed

openwisp_monitoring/monitoring/admin.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,7 @@ class MetricAdmin(TimeReadonlyAdminMixin, admin.ModelAdmin):
2929
save_on_top = True
3030
inlines = [ChartInline, AlertSettingsInline]
3131
fieldsets = [
32-
(
33-
None,
34-
{
35-
'fields': (
36-
'name',
37-
'description',
38-
'content_type',
39-
'object_id',
40-
'configuration',
41-
)
42-
},
43-
),
32+
(None, {'fields': ('name', 'content_type', 'object_id', 'configuration',)},),
4433
(
4534
_('Advanced options'),
4635
{'classes': ('collapse',), 'fields': ('key', 'field_name')},
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
from django.contrib.auth import get_user_model
2+
from django.test import TestCase
3+
from django.urls import reverse
4+
5+
from . import TestMonitoringMixin
6+
7+
8+
class TestAdmin(TestMonitoringMixin, TestCase):
9+
10+
def _login_admin(self):
11+
User = get_user_model()
12+
u = User.objects.create_superuser('admin', 'admin', '[email protected]')
13+
self.client.force_login(u)
14+
15+
def test_metric_admin(self):
16+
m = self._create_general_metric()
17+
url = reverse('admin:monitoring_metric_change', args=[m.pk])
18+
self._login_admin()
19+
r = self.client.get(url)
20+
self.assertEqual(r.status_code, 200)

0 commit comments

Comments
 (0)