Skip to content

[menu] Explicitly mention support for HR as a separator #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukewarlow opened this issue Apr 10, 2025 · 1 comment
Open

[menu] Explicitly mention support for HR as a separator #1191

lukewarlow opened this issue Apr 10, 2025 · 1 comment
Labels
menu Menu elements proposal

Comments

@lukewarlow
Copy link
Collaborator

lukewarlow commented Apr 10, 2025

It's common to visually separate menu items and select supports this so it seems good consistent for menu to do this too?

@lukewarlow lukewarlow added the menu Menu elements proposal label Apr 10, 2025
@scottaohara
Copy link
Collaborator

"good"

tbh, i the inclusion of hr in select serves more as a visual indicator of grouping than anything actually meaningful to people who can't see. in either case (now with customizable select) it'd be better, imo, to actually group the elements you want grouped using optgroup or fieldset, and then add whatever visual separator you want.

but, if we want to make this actually useful to everyone - if implicit groupings could be made in the a11y tree (for either element) then I wouldn't have to write all this stuff and I could have just thumbs upped your response. me shutting up is really the end goal, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
menu Menu elements proposal
Projects
None yet
Development

No branches or pull requests

2 participants