- fix count by adding a HashSet with visited sources

Author: Laurens-W

rewrite-core/src/main/java/org/openrewrite/scheduling/RecipeRunCycle.java

@@ -181,6 +181,7 @@ public LSS editSources(LSS sourceSet) {
                         return null;
                     }
 
+                    recipeRunStats.recordSourceVisited(source);
                     SourceFile after = source;
 
                     try {

rewrite-core/src/main/java/org/openrewrite/table/RecipeRunStats.java

@@ -35,6 +35,7 @@
 
 public class RecipeRunStats extends DataTable<RecipeRunStats.Row> {
     private final MeterRegistry registry = new SimpleMeterRegistry();
+    private final Set<Path> sourceFileVisited = new HashSet<>();
     private final Set<Path> sourceFileChanged = new HashSet<>();
 
     public RecipeRunStats(Recipe recipe) {
@@ -43,6 +44,10 @@ public RecipeRunStats(Recipe recipe) {
                 "Statistics used in analyzing the performance of recipes.");
     }
 
+    public void recordSourceVisited(SourceFile source) {
+        sourceFileVisited.add(source.getSourcePath());
+    }
+
     public void recordSourceFileChanged(@Nullable SourceFile before, @Nullable SourceFile after) {
         if (after != null) {
             sourceFileChanged.add(after.getSourcePath());
@@ -73,7 +78,7 @@ public void flush(ExecutionContext ctx) {
             Timer scanner = registry.find("rewrite.recipe.scan").tag("name", recipeName).timer();
             Row row = new Row(
                     recipeName,
-                    Long.valueOf(editor.count()).intValue(),
+                    sourceFileVisited.size(),
                     sourceFileChanged.size(),
                     scanner == null ? 0 : (long) scanner.totalTime(TimeUnit.NANOSECONDS),
                     scanner == null ? 0 : scanner.takeSnapshot().percentileValues()[0].value(TimeUnit.NANOSECONDS),

rewrite-core/src/test/java/org/openrewrite/table/RecipeRunStatsTest.java

@@ -78,9 +78,7 @@ void singleRow() {
               RecipeRunStats.Row row = rows.get(0);
               assertThat(row.getRecipe()).endsWith("RecipeWithApplicabilityTest");
               assertThat(row.getSourceFiles())
-                .as("Test framework will invoke the recipe once when it is expected to make a change, " +
-                    "then once again when it is expected to make no change")
-                .isEqualTo(2);
+                .isEqualTo(1);
               assertThat(row.getEditMaxNs()).isGreaterThan(0);
               assertThat(row.getEditTotalTimeNs())
                 .as("Cumulative time should be greater than any single visit time")
@@ -112,11 +110,11 @@ void sourceFilesCountStatsForSameRecipe() {
                   .hasSize(2);
                 for (RecipeRunStats.Row row : rows) {
                     assertThat(row.getSourceFiles())
-                      .as("If the same recipe runs with different parameters it shouldn't increment source files count")
-                      .isEqualTo(2);
+                      .as("If the same recipe runs with different parameters it shouldn't increment several times source files count")
+                      .isEqualTo(1);
                 }
             }).expectedCyclesThatMakeChanges(2),
           text("sem", "sam2")
         );
     }
-}
+}