`ClassCastException`: class org.openrewrite.java.tree.Javadoc$Reference cannot be cast

[Pankraz76]

ClassCastException: class org.openrewrite.java.tree.Javadoc$Reference cannot be cast to class org.openrewrite.java.tree.J (org.openrewrite.java.tree.Javadoc$Reference and org.openrewrite.java.tree.J are in unnamed module of loader org.openrewrite.gradle.RewriteClassLoader @423c2464)

* What went wrong:
Execution failed for task ':rewriteRun'.
> java.lang.RuntimeException: Error while visiting spring-web/src/main/java/org/springframework/web/util/UrlPathHelper.java: java.lang.ClassCastException: class org.openrewrite.java.tree.Javadoc$Reference cannot be cast to class org.openrewrite.java.tree.J (org.openrewrite.java.tree.Javadoc$Reference and org.openrewrite.java.tree.J are in unnamed module of loader org.openrewrite.gradle.RewriteClassLoader @423c2464)
    org.openrewrite.java.internal.template.BlockStatementTemplateGenerator.contextTemplate(BlockStatementTemplateGenerator.java:253)
    org.openrewrite.java.internal.template.BlockStatementTemplateGenerator.lambda$template$0(BlockStatementTemplateGenerator.java:72)
    io.micrometer.core.instrument.composite.CompositeTimer.record(CompositeTimer.java:65)
    org.openrewrite.java.internal.template.BlockStatementTemplateGenerator.template(BlockStatementTemplateGenerator.java:58)
    org.openrewrite.java.internal.template.JavaTemplateParser.parseMethodArguments(JavaTemplateParser.java:206)
    org.openrewrite.java.internal.template.JavaTemplateJavaExtension$1.visitMethodInvocation(JavaTemplateJavaExtension.java:390)
    org.openrewrite.java.internal.template.JavaTemplateJavaExtension$1.visitMethodInvocation(JavaTemplateJavaExtension.java:55)
    org.openrewrite.java.tree.J$MethodInvocation.acceptJava(J.java:4062)
    org.openrewrite.java.tree.J.accept(J.java:58)
    org.openrewrite.TreeVisitor.visit(TreeVisitor.java:250)
    org.openrewrite.TreeVisitor.visit(TreeVisitor.java:157)
    org.openrewrite.java.JavaTemplate.apply(JavaTemplate.java:115)
    org.openrewrite.java.migrate.net.MigrateURLDecoderDecode$1.visitMethodInvocation(MigrateURLDecoderDecode.java:60)
    org.openrewrite.java.migrate.net.MigrateURLDecoderDecode$1.visitMethodInvocation(MigrateURLDecoderDecode.java:52)
    org.openrewrite.java.tree.J$MethodInvocation.acceptJava(J.java:4062)
    org.openrewrite.java.tree.J.accept(J.java:58)
    ...

• reproduce: https://github.com/spring-projects/spring-framework
• adjust org.gradle.jvmargs=-Xmx8g to speed up process

initscript {
    repositories {
        maven { url "https://plugins.gradle.org/m2" }
    }
    dependencies { classpath("org.openrewrite:plugin:7.2.1") }
}
rootProject {
    plugins.apply(org.openrewrite.gradle.RewritePlugin)
    dependencies {
        rewrite("org.openrewrite.recipe:rewrite-migrate-java:3.4.0")
    }
    rewrite {
//        activeRecipe("org.openrewrite.staticanalysis.FinalizeLocalVariables")
//        activeRecipe("org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods")
        activeRecipe("org.openrewrite.java.migrate.UpgradeToJava17")
//        activeRecipe("org.openrewrite.java.migrate.UpgradeToJava21")
//        activeRecipe("org.openrewrite.java.migrate.lang.var.UseVarForObject")
//        activeRecipe("org.openrewrite.java.migrate.lang.var.UseVarForPrimitive")
        setExportDatatables(true)
    }
    afterEvaluate {
        if (repositories.isEmpty()) {
            repositories {
                mavenCentral()
            }
        }
    }
}

[timtebeek]

Thanks for the report here @Pankraz76 ! It looks like the recipe we have is tripped up by this line of JavaDoc.

	 * @see java.net.URLDecoder#decode(String, String)

Which then fails in this JavaTemplate apply:

rewrite-migrate-java/src/main/java/org/openrewrite/java/migrate/net/MigrateURLDecoderDecode.java

Lines 52 to 60 in ea61b2f

	return Preconditions.check(Preconditions.and(new UsesJavaVersion<>(10), new UsesMethod<>(MATCHER)), new JavaIsoVisitor<ExecutionContext>() {
	@Override
	public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
	J.MethodInvocation m = method;
	if (MATCHER.matches(m)) {
	m = JavaTemplate.builder("#{any(String)}, StandardCharsets.UTF_8")
	.contextSensitive()
	.imports("java.nio.charset.StandardCharsets")
	.build().apply(

I'd not seen JavaTemplate attempt replacements in JavaDoc before; could be a class of issues we'd not expected or encountered previously, thanks!

[timtebeek]

Separately: I see you're using the Gradle plugin and init script against spring-projects/spring-framework: you could speed that up considerably by either using the Moderne CLI, or Moderne Platform, as both support running recipes against serialized LSTs for OSS.