Skip to content

Commit ee04c40

Browse files
author
duke
committed
Added webrev for jfx/673
1 parent 6cc5af6 commit ee04c40

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

jfx/673/02-03/commits.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
[{"commit":{"message":"Add space around operator and string"},"files":[{"filename":"tests\/manual\/controls\/SelectTableViewTest.java"}],"sha":"2d321087e6ccaf2acdf04709b6d710098dd0e02a"},{"commit":{"message":"Add license header and add space around operators"},"files":[{"filename":"tests\/manual\/controls\/SelectListViewTest.java"},{"filename":"tests\/manual\/controls\/SelectTableViewTest.java"}],"sha":"c7b22089802dbe6a1fbb5f5cc0ed5a49781e60aa"}]

jfx/673/02-03/comparison.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"files":[{"patch":"@@ -0,0 +1,25 @@\n+\/*\n+ * Copyright (c) 2021, Oracle and\/or its affiliates. All rights reserved.\n+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.\n+ *\n+ * This code is free software; you can redistribute it and\/or modify it\n+ * under the terms of the GNU General Public License version 2 only, as\n+ * published by the Free Software Foundation. Oracle designates this\n+ * particular file as subject to the \"Classpath\" exception as provided\n+ * by Oracle in the LICENSE file that accompanied this code.\n+ *\n+ * This code is distributed in the hope that it will be useful, but WITHOUT\n+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\n+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License\n+ * version 2 for more details (a copy is included in the LICENSE file that\n+ * accompanied this code).\n+ *\n+ * You should have received a copy of the GNU General Public License version\n+ * 2 along with this work; if not, write to the Free Software Foundation,\n+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.\n+ *\n+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA\n+ * or visit www.oracle.com if you need additional information or have any\n+ * questions.\n+ *\/\n+\n@@ -24,1 +49,1 @@\n- for(int i=0; i<ROW_COUNT; i++) {\n+ for(int i = 0; i < ROW_COUNT; i++) {\n@@ -47,6 +72,6 @@\n- selectAll.setOnAction((e)->selectAll(listView));\n- clearSelection.setOnAction((e)->clearSelection(listView));\n- selectToStart.setOnAction((e)->selectToStart(listView));\n- selectToEnd.setOnAction((e)->selectToLast(listView));\n- selectPrevious.setOnAction((e)->selectPrevious(listView));\n- selectNext.setOnAction((e)->selectNext(listView));\n+ selectAll.setOnAction(e -> selectAll(listView));\n+ clearSelection.setOnAction(e -> clearSelection(listView));\n+ selectToStart.setOnAction(e -> selectToStart(listView));\n+ selectToEnd.setOnAction(e -> selectToLast(listView));\n+ selectPrevious.setOnAction(e -> selectPrevious(listView));\n+ selectNext.setOnAction(e -> selectNext(listView));\n","filename":"tests\/manual\/controls\/SelectListViewTest.java","additions":32,"deletions":7,"binary":false,"changes":39,"status":"modified"},{"patch":"@@ -0,0 +1,25 @@\n+\/*\n+ * Copyright (c) 2021, Oracle and\/or its affiliates. All rights reserved.\n+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.\n+ *\n+ * This code is free software; you can redistribute it and\/or modify it\n+ * under the terms of the GNU General Public License version 2 only, as\n+ * published by the Free Software Foundation. Oracle designates this\n+ * particular file as subject to the \"Classpath\" exception as provided\n+ * by Oracle in the LICENSE file that accompanied this code.\n+ *\n+ * This code is distributed in the hope that it will be useful, but WITHOUT\n+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\n+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License\n+ * version 2 for more details (a copy is included in the LICENSE file that\n+ * accompanied this code).\n+ *\n+ * You should have received a copy of the GNU General Public License version\n+ * 2 along with this work; if not, write to the Free Software Foundation,\n+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.\n+ *\n+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA\n+ * or visit www.oracle.com if you need additional information or have any\n+ * questions.\n+ *\/\n+\n@@ -28,1 +53,1 @@\n- for(int i=0; i<COL_COUNT; i++) {\n+ for(int i = 0; i < COL_COUNT; i++) {\n@@ -31,1 +56,1 @@\n- column.setCellValueFactory((cell)->new SimpleStringProperty(cell.getValue()[colIndex]));\n+ column.setCellValueFactory(cell -> new SimpleStringProperty(cell.getValue()[colIndex]));\n@@ -37,1 +62,1 @@\n- for(int i=0; i<ROW_COUNT; i++) {\n+ for(int i = 0; i < ROW_COUNT; i++) {\n@@ -39,2 +64,2 @@\n- for(int j=0; j<rec.length; j++) {\n- rec[j] = i+\":\"+j;\n+ for(int j = 0; j < rec.length; j++) {\n+ rec[j] = i + \":\" + j;\n@@ -63,6 +88,6 @@\n- selectAll.setOnAction((e)->selectAll(tableView));\n- clearSelection.setOnAction((e)->clearSelection(tableView));\n- selectToStart.setOnAction((e)->selectToStart(tableView));\n- selectToEnd.setOnAction((e)->selectToLast(tableView));\n- selectPrevious.setOnAction((e)->selectPrevious(tableView));\n- selectNext.setOnAction((e)->selectNext(tableView));\n+ selectAll.setOnAction(e -> selectAll(tableView));\n+ clearSelection.setOnAction(e -> clearSelection(tableView));\n+ selectToStart.setOnAction(e -> selectToStart(tableView));\n+ selectToEnd.setOnAction(e -> selectToLast(tableView));\n+ selectPrevious.setOnAction(e -> selectPrevious(tableView));\n+ selectNext.setOnAction(e -> selectNext(tableView));\n","filename":"tests\/manual\/controls\/SelectTableViewTest.java","additions":36,"deletions":11,"binary":false,"changes":47,"status":"modified"}]}

jfx/673/02-03/metadata.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"head":{"repo":{"full_name":"abhinayagarwal\/jfx","html_url":"https:\/\/github.com\/abhinayagarwal\/jfx"},"sha":"2d321087e6ccaf2acdf04709b6d710098dd0e02a"},"created_at":"2021-12-21T12:21:55.498597952Z","base":{"repo":{"full_name":"openjdk\/jfx","html_url":"https:\/\/git.openjdk.java.net\/jfx"},"sha":"8196b34899b7bd4930f22d355b684c341862c8d9"}}

0 commit comments

Comments
 (0)