Skip to content

Commit 5362ba3

Browse files
author
duke
committed
Added webrev for jdk19/9
1 parent 258a4e9 commit 5362ba3

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

jdk19/9/02-03/commits.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
[{"commit":{"message":"8287971: Throw exception for missing values in .jpackage.xml [v4]"},"files":[{"filename":"src\/jdk.jpackage\/share\/classes\/jdk\/jpackage\/internal\/AppImageFile.java"},{"filename":"test\/jdk\/tools\/jpackage\/helpers\/jdk\/jpackage\/test\/JPackageCommand.java"}],"sha":"d489ee6067583b4fb1671de4323d587e6d462c2b"}]

jdk19/9/02-03/comparison.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"files":[{"patch":"@@ -333,1 +333,1 @@\n- static String getVersion() {\n+ public static String getVersion() {\n@@ -337,1 +337,1 @@\n- static String getPlatform() {\n+ public static String getPlatform() {\n","filename":"src\/jdk.jpackage\/share\/classes\/jdk\/jpackage\/internal\/AppImageFile.java","additions":2,"deletions":2,"binary":false,"changes":4,"status":"modified"},{"patch":"@@ -304,21 +304,6 @@\n- String appImage = getArgumentValue(\"--app-image\");\n- if (appImage == null) {\n- throw new RuntimeException(\"Error: --app-image expected\");\n- }\n-\n- final String version = System.getProperty(\"java.version\");\n- final String platform;\n-\n- if (TKit.isWindows()) {\n- platform = \"windows\";\n- } else if (TKit.isLinux()) {\n- platform = \"linux\";\n- } else if (TKit.isOSX()) {\n- platform = \"macOS\";\n- } else {\n- platform = \"unknown\";\n- }\n-\n- ApplicationLayout layout = ApplicationLayout.platformAppImage();\n- Path jpackageXMLFile = layout.resolveAt(Path.of(appImage))\n- .appDirectory().resolve(\".jpackage.xml\");\n+ Path jpackageXMLFile = AppImageFile.getPathInAppImage(\n+ Optional.ofNullable(getArgumentValue(\"--app-image\")).map(\n+ Path::of).orElseThrow(() -> {\n+ return new RuntimeException(\n+ \"Error: --app-image expected\");\n+ }));\n@@ -328,2 +313,2 @@\n- xml.writeAttribute(\"version\", version);\n- xml.writeAttribute(\"platform\", platform);\n+ xml.writeAttribute(\"version\", AppImageFile.getVersion());\n+ xml.writeAttribute(\"platform\", AppImageFile.getPlatform());\n","filename":"test\/jdk\/tools\/jpackage\/helpers\/jdk\/jpackage\/test\/JPackageCommand.java","additions":8,"deletions":23,"binary":false,"changes":31,"status":"modified"}]}

jdk19/9/02-03/metadata.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"head":{"repo":{"full_name":"sashamatveev\/jdk19","html_url":"https:\/\/github.com\/sashamatveev\/jdk19"},"sha":"d489ee6067583b4fb1671de4323d587e6d462c2b"},"created_at":"2022-06-17T21:49:52.947901064Z","base":{"repo":{"full_name":"openjdk\/jdk19","html_url":"https:\/\/git.openjdk.org\/jdk19"},"sha":"2199f4e2bcfc31cfa7280e3c954b2fe8261776d1"}}

0 commit comments

Comments
 (0)