Skip to content

Commit 91f0582

Browse files
author
duke
committed
Backport 385c4f8
1 parent 2da14e2 commit 91f0582

File tree

7 files changed

+12
-8
lines changed

7 files changed

+12
-8
lines changed

src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,8 @@ void ShenandoahAdaptiveHeuristics::record_success_concurrent() {
184184
}
185185
}
186186

187-
void ShenandoahAdaptiveHeuristics::record_success_degenerated() {
188-
ShenandoahHeuristics::record_success_degenerated();
187+
void ShenandoahAdaptiveHeuristics::record_degenerated() {
188+
ShenandoahHeuristics::record_degenerated();
189189
// Adjust both trigger's parameters in the case of a degenerated GC because
190190
// either of them should have triggered earlier to avoid this case.
191191
adjust_margin_of_error(DEGENERATE_PENALTY_SD);

src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ class ShenandoahAdaptiveHeuristics : public ShenandoahHeuristics {
114114

115115
virtual void record_cycle_start() override;
116116
virtual void record_success_concurrent() override;
117-
virtual void record_success_degenerated() override;
117+
virtual void record_degenerated() override;
118118
virtual void record_success_full() override;
119119

120120
virtual bool should_start_gc() override;

src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ void ShenandoahHeuristics::record_success_concurrent() {
243243
adjust_penalty(Concurrent_Adjust);
244244
}
245245

246-
void ShenandoahHeuristics::record_success_degenerated() {
246+
void ShenandoahHeuristics::record_degenerated() {
247247
adjust_penalty(Degenerated_Penalty);
248248
}
249249

src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ class ShenandoahHeuristics : public CHeapObj<mtGC> {
218218

219219
virtual void record_success_concurrent();
220220

221-
virtual void record_success_degenerated();
221+
virtual void record_degenerated();
222222

223223
virtual void record_success_full();
224224

src/hotspot/share/gc/shenandoah/heuristics/shenandoahOldHeuristics.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -722,10 +722,10 @@ void ShenandoahOldHeuristics::record_success_concurrent() {
722722
this->ShenandoahHeuristics::record_success_concurrent();
723723
}
724724

725-
void ShenandoahOldHeuristics::record_success_degenerated() {
725+
void ShenandoahOldHeuristics::record_degenerated() {
726726
// Forget any triggers that occurred while OLD GC was ongoing. If we really need to start another, it will retrigger.
727727
clear_triggers();
728-
this->ShenandoahHeuristics::record_success_degenerated();
728+
this->ShenandoahHeuristics::record_degenerated();
729729
}
730730

731731
void ShenandoahOldHeuristics::record_success_full() {

src/hotspot/share/gc/shenandoah/heuristics/shenandoahOldHeuristics.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ class ShenandoahOldHeuristics : public ShenandoahHeuristics {
190190

191191
void record_success_concurrent() override;
192192

193-
void record_success_degenerated() override;
193+
void record_degenerated() override;
194194

195195
void record_success_full() override;
196196

src/hotspot/share/gc/shenandoah/shenandoahDegeneratedGC.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,8 +313,12 @@ void ShenandoahDegenGC::op_degenerated() {
313313
policy->record_degenerated(_generation->is_young(), _abbreviated, progress);
314314
if (progress) {
315315
heap->notify_gc_progress();
316+
_generation->heuristics()->record_degenerated();
316317
} else if (!heap->mode()->is_generational() || policy->generational_should_upgrade_degenerated_gc()) {
318+
// Upgrade to full GC, register full-GC impact on heuristics.
317319
op_degenerated_futile();
320+
} else {
321+
_generation->heuristics()->record_degenerated();
318322
}
319323
}
320324

0 commit comments

Comments
 (0)