Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit dc8c292

Browse files
authored
Merge pull request #122 from openedx/mashal-m/node18-upgrade
feat: upgraded to node v18, added .nvmrc and updated workflows
2 parents 6d6abe2 + 9bf1905 commit dc8c292

File tree

13 files changed

+5802
-27369
lines changed

13 files changed

+5802
-27369
lines changed

.eslintrc.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable import/no-extraneous-dependencies */
12
const { createConfig } = require('@edx/frontend-build');
23

3-
module.exports = createConfig('eslint');
4+
module.exports = createConfig('eslint');

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ on:
1111
jobs:
1212
tests:
1313
runs-on: ubuntu-latest
14-
strategy:
15-
matrix:
16-
node: [16]
14+
1715
steps:
18-
- uses: actions/checkout@v2
19-
- uses: actions/setup-node@v1
16+
- uses: actions/checkout@v3
17+
- name: Setup Nodejs Env
18+
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
19+
- uses: actions/setup-node@v3
2020
with:
21-
node-version: ${{ matrix.node }}
21+
node-version: ${{ env.NODE_VER }}
2222
- run: npm ci
2323
- run: make validate-no-uncommitted-package-lock-changes
2424
- run: npm run lint

.github/workflows/lockfileversion-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ on:
1111

1212
jobs:
1313
version-check:
14-
uses: openedx/.github/.github/workflows/lockfileversion-check.yml@master
14+
uses: openedx/.github/.github/workflows/lockfileversion-check-v3.yml@master

.github/workflows/update-browserlist.yml

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,14 @@ on:
77
jobs:
88
update-dep:
99
runs-on: ubuntu-latest
10-
strategy:
11-
matrix:
12-
node: [16]
13-
npm: [8.5.x]
1410

1511
steps:
16-
- uses: actions/checkout@v2
17-
- uses: actions/setup-node@v2
12+
- uses: actions/checkout@v3
13+
- name: Setup Nodejs Env
14+
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
15+
- uses: actions/setup-node@v3
1816
with:
19-
node-version: ${{ matrix.node }}
20-
- run: npm install -g npm@${{ matrix.npm }}
17+
node-version: ${{ env.NODE_VER }}
2118
- run: make requirements
2219

2320
- name: Update dependencies

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
18

0 commit comments

Comments
 (0)