Skip to content

Commit 2b48832

Browse files
authored
Merge pull request #327 from zhouzi88/swl-4346
change FAN RPM MAX so fan max percentage won't exceed 100%
2 parents 8513836 + 89ba156 commit 2b48832

File tree

12 files changed

+60
-5
lines changed

12 files changed

+60
-5
lines changed

packages/platforms/accton/powerpc/powerpc-accton-as5710-54x/onlp/builds/src/module/auto/powerpc_accton_as5710_54x.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ cdefs: &cdefs
2929
- POWERPC_ACCTON_AS5710_54X_CONFIG_INCLUDE_DEBUG:
3030
doc: "Include debug tool."
3131
default: 0
32+
- POWERPC_ACCTON_AS5710_54X_CONFIG_SYS_FAN_FRONT_RPM_MAX:
33+
doc: "Maximum system fan(Front) rpm."
34+
default: 19725
3235

3336
definitions:
3437
cdefs:

packages/platforms/accton/powerpc/powerpc-accton-as5710-54x/onlp/builds/src/module/inc/powerpc_accton_as5710_54x/powerpc_accton_as5710_54x_config.h

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,16 @@
9999
#define POWERPC_ACCTON_AS5710_54X_CONFIG_INCLUDE_DEBUG 0
100100
#endif
101101

102+
/**
103+
* POWERPC_ACCTON_AS5710_54X_CONFIG_SYS_FAN_FRONT_RPM_MAX
104+
*
105+
* Maximum system fan(Front) rpm. */
106+
107+
108+
#ifndef POWERPC_ACCTON_AS5710_54X_CONFIG_SYS_FAN_FRONT_RPM_MAX
109+
#define POWERPC_ACCTON_AS5710_54X_CONFIG_SYS_FAN_FRONT_RPM_MAX 19725
110+
#endif
111+
102112

103113

104114
/**

packages/platforms/accton/powerpc/powerpc-accton-as5710-54x/onlp/builds/src/module/src/fani.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
#include <onlplib/mmap.h>
2828
#include <fcntl.h>
2929
#include "platform_lib.h"
30+
#include "powerpc_accton_as5710_54x/powerpc_accton_as5710_54x_config.h"
3031

3132
#define PREFIX_PATH_ON_MAIN_BROAD "/sys/class/hwmon/hwmon11/"
3233
#define PREFIX_PATH_ON_PSU "/sys/bus/i2c/devices/"
@@ -190,7 +191,7 @@ _onlp_fani_info_get_fan(int local_id, onlp_fan_info_t* info)
190191
info->rpm = (info->rpm + atoi(r_data))/2;
191192

192193
/* get speed percentage from rpm */
193-
info->percentage = (info->rpm * 100)/16800;
194+
info->percentage = (info->rpm * 100)/POWERPC_ACCTON_AS5710_54X_CONFIG_SYS_FAN_FRONT_RPM_MAX;
194195

195196
/* check present */
196197
if (info->rpm > 0)

packages/platforms/accton/powerpc/powerpc-accton-as5710-54x/onlp/builds/src/module/src/powerpc_accton_as5710_54x_config.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@ powerpc_accton_as5710_54x_config_settings_t powerpc_accton_as5710_54x_config_set
4949
{ __powerpc_accton_as5710_54x_config_STRINGIFY_NAME(POWERPC_ACCTON_AS5710_54X_CONFIG_INCLUDE_DEBUG), __powerpc_accton_as5710_54x_config_STRINGIFY_VALUE(POWERPC_ACCTON_AS5710_54X_CONFIG_INCLUDE_DEBUG) },
5050
#else
5151
{ POWERPC_ACCTON_AS5710_54X_CONFIG_INCLUDE_DEBUG(__powerpc_accton_as5710_54x_config_STRINGIFY_NAME), "__undefined__" },
52+
#endif
53+
#ifdef POWERPC_ACCTON_AS5710_54X_CONFIG_SYS_FAN_FRONT_RPM_MAX
54+
{ __powerpc_accton_as5710_54x_config_STRINGIFY_NAME(POWERPC_ACCTON_AS5710_54X_CONFIG_SYS_FAN_FRONT_RPM_MAX), __powerpc_accton_as5710_54x_config_STRINGIFY_VALUE(POWERPC_ACCTON_AS5710_54X_CONFIG_SYS_FAN_FRONT_RPM_MAX) },
55+
#else
56+
{ POWERPC_ACCTON_AS5710_54X_CONFIG_SYS_FAN_FRONT_RPM_MAX(__powerpc_accton_as5710_54x_config_STRINGIFY_NAME), "__undefined__" },
5257
#endif
5358
{ NULL, NULL }
5459
};

packages/platforms/accton/x86-64/x86-64-accton-as5812-54t/onlp/builds/src/module/auto/x86_64_accton_as5812_54t.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ cdefs: &cdefs
2929
- X86_64_ACCTON_AS5812_54T_CONFIG_INCLUDE_DEFAULT_FAN_DIRECTION:
3030
doc: "Assume chassis fan direction is the same as the PSU fan direction."
3131
default: 0
32-
32+
- x86_64_accton_as5812_54t_CONFIG_SYS_FAN_FRONT_RPM_MAX:
33+
doc: "Maximum system fan(Front) rpm."
34+
default: 21500
3335

3436
definitions:
3537
cdefs:

packages/platforms/accton/x86-64/x86-64-accton-as5812-54t/onlp/builds/src/module/inc/x86_64_accton_as5812_54t/x86_64_accton_as5812_54t_config.h

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,16 @@
9999
#define X86_64_ACCTON_AS5812_54T_CONFIG_INCLUDE_DEFAULT_FAN_DIRECTION 0
100100
#endif
101101

102+
/**
103+
* x86_64_accton_as5812_54t_CONFIG_SYS_FAN_FRONT_RPM_MAX
104+
*
105+
* Maximum system fan(Front) rpm. */
106+
107+
108+
#ifndef x86_64_accton_as5812_54t_CONFIG_SYS_FAN_FRONT_RPM_MAX
109+
#define x86_64_accton_as5812_54t_CONFIG_SYS_FAN_FRONT_RPM_MAX 21500
110+
#endif
111+
102112

103113

104114
/**

packages/platforms/accton/x86-64/x86-64-accton-as5812-54t/onlp/builds/src/module/src/fani.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include <onlplib/file.h>
2929
#include <fcntl.h>
3030
#include "platform_lib.h"
31+
#include "x86_64_accton_as5812_54t/x86_64_accton_as5812_54t_config.h"
3132

3233
#define PREFIX_PATH_ON_MAIN_BOARD "/sys/devices/platform/as5812_54t_fan/"
3334
#define PREFIX_PATH_ON_PSU "/sys/bus/i2c/devices/"
@@ -191,7 +192,7 @@ _onlp_fani_info_get_fan(int local_id, onlp_fan_info_t* info)
191192
info->rpm = (info->rpm + atoi(r_data))/2;
192193

193194
/* get speed percentage from rpm */
194-
info->percentage = (info->rpm * 100)/16800;
195+
info->percentage = (info->rpm * 100)/x86_64_accton_as5812_54t_CONFIG_SYS_FAN_FRONT_RPM_MAX;
195196

196197
/* check present */
197198
if (info->rpm > 0)

packages/platforms/accton/x86-64/x86-64-accton-as5812-54t/onlp/builds/src/module/src/x86_64_accton_as5812_54t_config.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@ x86_64_accton_as5812_54t_config_settings_t x86_64_accton_as5812_54t_config_setti
4949
{ __x86_64_accton_as5812_54t_config_STRINGIFY_NAME(X86_64_ACCTON_AS5812_54T_CONFIG_INCLUDE_DEFAULT_FAN_DIRECTION), __x86_64_accton_as5812_54t_config_STRINGIFY_VALUE(X86_64_ACCTON_AS5812_54T_CONFIG_INCLUDE_DEFAULT_FAN_DIRECTION) },
5050
#else
5151
{ X86_64_ACCTON_AS5812_54T_CONFIG_INCLUDE_DEFAULT_FAN_DIRECTION(__x86_64_accton_as5812_54t_config_STRINGIFY_NAME), "__undefined__" },
52+
#endif
53+
#ifdef x86_64_accton_as5812_54t_CONFIG_SYS_FAN_FRONT_RPM_MAX
54+
{ __x86_64_accton_as5812_54t_config_STRINGIFY_NAME(x86_64_accton_as5812_54t_CONFIG_SYS_FAN_FRONT_RPM_MAX), __x86_64_accton_as5812_54t_config_STRINGIFY_VALUE(x86_64_accton_as5812_54t_CONFIG_SYS_FAN_FRONT_RPM_MAX) },
55+
#else
56+
{ x86_64_accton_as5812_54t_CONFIG_SYS_FAN_FRONT_RPM_MAX(__x86_64_accton_as5812_54t_config_STRINGIFY_NAME), "__undefined__" },
5257
#endif
5358
{ NULL, NULL }
5459
};

packages/platforms/accton/x86-64/x86-64-accton-as5812-54x/onlp/builds/src/module/auto/x86_64_accton_as5812_54x.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ cdefs: &cdefs
2929
- X86_64_ACCTON_AS5812_54X_CONFIG_INCLUDE_DEFAULT_FAN_DIRECTION:
3030
doc: "Assume chassis fan direction is the same as the PSU fan direction."
3131
default: 0
32-
32+
- x86_64_accton_as5812_54x_CONFIG_SYS_FAN_FRONT_RPM_MAX:
33+
doc: "Maximum system fan(Front) rpm."
34+
default: 21500
3335

3436
definitions:
3537
cdefs:

packages/platforms/accton/x86-64/x86-64-accton-as5812-54x/onlp/builds/src/module/inc/x86_64_accton_as5812_54x/x86_64_accton_as5812_54x_config.h

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,16 @@
9999
#define X86_64_ACCTON_AS5812_54X_CONFIG_INCLUDE_DEFAULT_FAN_DIRECTION 0
100100
#endif
101101

102+
/**
103+
* x86_64_accton_as5812_54x_CONFIG_SYS_FAN_FRONT_RPM_MAX
104+
*
105+
* Maximum system fan(Front) rpm. */
106+
107+
108+
#ifndef x86_64_accton_as5812_54x_CONFIG_SYS_FAN_FRONT_RPM_MAX
109+
#define x86_64_accton_as5812_54x_CONFIG_SYS_FAN_FRONT_RPM_MAX 21500
110+
#endif
111+
102112

103113

104114
/**

0 commit comments

Comments
 (0)