When unmarshaling ChatCompletionChunk, the sdk doesn't check if the input is valid #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

spacewander opened this issue Apr 23, 2025 · 1 comment

spacewander commented Apr 23, 2025

Using the snippet below:

	chunk = openai.ChatCompletionChunk{}
	err := json.Unmarshal([]byte(`[]`), &chunk)
	fmt.Printf("%+v\n", err)

The err is nil and the chunk is successfully unmarshalled, though it will have empty value except that the raw field is [].

The text was updated successfully, but these errors were encountered:

Author

spacewander commented Apr 24, 2025 •

edited by golinks bot

Loading

Sometimes, errors are ignored during decoding:
https://github.com/openai/openai-[go/blob/c0414f15a9f4065adee2ed96a4dcd4d4cb9708aa/internal/apijson/decoder.go#L408-L411](https://www.golinks.io/blob/c0414f15a9f4065adee2ed96a4dcd4d4cb9708aa/internal/apijson/decoder.go#L408-L411?trackSource=github)

https://github.com/openai/openai-[go/blob/c0414f15a9f4065adee2ed96a4dcd4d4cb9708aa/internal/apijson/decoder.go#L430-L435](https://www.golinks.io/blob/c0414f15a9f4065adee2ed96a4dcd4d4cb9708aa/internal/apijson/decoder.go#L430-L435?trackSource=github)

https://github.com/openai/openai-[go/blob/c0414f15a9f4065adee2ed96a4dcd4d4cb9708aa/internal/apijson/decoder.go#L482-L486](https://www.golinks.io/blob/c0414f15a9f4065adee2ed96a4dcd4d4cb9708aa/internal/apijson/decoder.go#L482-L486?trackSource=github)

What is the reason behind them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment