Skip to content

Commit dc84165

Browse files
committed
Apply CodeRabbitAI suggestions
1 parent 221c9ef commit dc84165

2 files changed

Lines changed: 3 additions & 12 deletions

File tree

feature/loan/src/commonMain/composeResources/values/strings.xml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -88,16 +88,6 @@
8888
<string name="feature_loan_approval_amount_can_not_be_empty">Loan approval amount can not be empty</string>
8989
<string name="feature_loan_error_invalid_amount">Invalid amount</string>
9090

91-
<string name="feature_loan_disburse_loan">Disburse Loan</string>
92-
<string name="feature_loan_loan_disburse_successfully">Loan disburse successfully</string>
93-
<string name="feature_loan_approval_disbursement_date">Approval Disbursement Date</string>
94-
<string name="feature_loan_loan_amount_disbursed">Loan Amount Disbursed</string>
95-
<string name="feature_loan_payment_type">Payment Type</string>
96-
<string name="feature_loan_disbursement_note">Disbursement Note</string>
97-
<string name="feature_loan_error_network_not_available">Network not available</string>
98-
<string name="feature_loan_error_amount_can_not_be_empty">Amount can not be empty</string>
99-
<string name="feature_loan_error_fetching_repayment_schedule">Error fetching repayment schedule</string>
100-
10191
<string name="feature_loan_loan_account_summary">Loan Account Summary</string>
10292
<string name="feature_loan_transactions">Transactions</string>
10393
<string name="feature_loan_repayment_schedule">Loan Repayment Schedule</string>
@@ -742,4 +732,5 @@
742732
<string name="feature_loan_disburse_failed">Failed to disburse loan</string>
743733
<string name="feature_loan_disburse_failed_to_load_template">Failed to load disburse template</string>
744734
<string name="feature_loan_disburse_amount_greater_than_zero">Amount must be greater than 0</string>
735+
<string name="feature_loan_disburse_note">Note (Optional)</string>
745736
</resources>

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanDisburse/LoanDisburseScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import androidclient.feature.loan.generated.resources.feature_loan_disburse_bank
2020
import androidclient.feature.loan.generated.resources.feature_loan_disburse_cheque_number
2121
import androidclient.feature.loan.generated.resources.feature_loan_disburse_date
2222
import androidclient.feature.loan.generated.resources.feature_loan_disburse_external_id
23+
import androidclient.feature.loan.generated.resources.feature_loan_disburse_note
2324
import androidclient.feature.loan.generated.resources.feature_loan_disburse_payment_type
2425
import androidclient.feature.loan.generated.resources.feature_loan_disburse_receipt_number
2526
import androidclient.feature.loan.generated.resources.feature_loan_disburse_routing_code
@@ -54,7 +55,6 @@ import androidx.compose.ui.Alignment
5455
import androidx.compose.ui.Modifier
5556
import androidx.compose.ui.text.input.KeyboardType
5657
import androidx.lifecycle.compose.collectAsStateWithLifecycle
57-
import androidx.lifecycle.viewmodel.compose.viewModel
5858
import com.mifos.core.designsystem.component.MifosButton
5959
import com.mifos.core.designsystem.component.MifosDatePickerTextField
6060
import com.mifos.core.designsystem.component.MifosOutlinedTextField
@@ -278,7 +278,7 @@ private fun LoanDisburseForm(
278278
MifosOutlinedTextField(
279279
value = state.note,
280280
onValueChange = { onAction(LoanDisburseAction.NoteChanged(it)) },
281-
label = "Note",
281+
label = stringResource(Res.string.feature_loan_disburse_note),
282282
keyboardType = KeyboardType.Text,
283283
)
284284

0 commit comments

Comments
 (0)