Replace dialog with snackbar for showing error and success messages

Author: sahilshivekar

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanChargeOff/LoanChargeOffScreen.kt

@@ -21,6 +21,7 @@ import androidclient.feature.loan.generated.resources.feature_loan_charge_off_pl
 import androidclient.feature.loan.generated.resources.feature_loan_charge_off_reason
 import androidclient.feature.loan.generated.resources.feature_loan_charge_off_submit
 import androidclient.feature.loan.generated.resources.feature_loan_charge_off_transaction_date
+import androidclient.feature.loan.generated.resources.feature_loan_loan_charges
 import androidclient.feature.loan.generated.resources.ok
 import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.Column
@@ -34,14 +35,19 @@ import androidx.compose.foundation.verticalScroll
 import androidx.compose.material3.DatePicker
 import androidx.compose.material3.DatePickerDialog
 import androidx.compose.material3.ExperimentalMaterial3Api
+import androidx.compose.material3.Icon
+import androidx.compose.material3.IconButton
 import androidx.compose.material3.SelectableDates
+import androidx.compose.material3.SnackbarHostState
 import androidx.compose.material3.Text
 import androidx.compose.material3.TextButton
 import androidx.compose.material3.rememberDatePickerState
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.getValue
+import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
+import androidx.compose.runtime.rememberCoroutineScope
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.text.input.KeyboardType
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
@@ -50,14 +56,17 @@ import com.mifos.core.common.utils.DateHelper
 import com.mifos.core.designsystem.component.MifosButton
 import com.mifos.core.designsystem.component.MifosDatePickerTextField
 import com.mifos.core.designsystem.component.MifosOutlinedTextField
+import com.mifos.core.designsystem.component.MifosScaffold
 import com.mifos.core.designsystem.component.MifosSweetError
 import com.mifos.core.designsystem.component.MifosTextFieldDropdown
+import com.mifos.core.designsystem.icon.MifosIcons
 import com.mifos.core.designsystem.theme.DesignToken
 import com.mifos.core.designsystem.theme.MifosTypography
 import com.mifos.core.ui.components.MifosAlertDialog
 import com.mifos.core.ui.components.MifosBreadcrumbNavBar
 import com.mifos.core.ui.components.MifosProgressIndicator
 import com.mifos.core.ui.util.EventsEffect
+import kotlinx.html.Entities
 import org.jetbrains.compose.resources.stringResource
 import org.koin.compose.viewmodel.koinViewModel
 import template.core.base.designsystem.theme.KptTheme
@@ -84,11 +93,6 @@ internal fun LoanChargeOffScreen(
         onAction = remember(viewModel) { { viewModel.trySendAction(it) } },
         navController = navController,
     )
-
-    LoanChargeOffDialog(
-        state = state,
-        onAction = remember(viewModel) { { viewModel.trySendAction(it) } },
-    )
 }
 
 @Composable
@@ -98,33 +102,47 @@ private fun LoanChargeOffScreenContent(
     navController: NavController,
     modifier: Modifier = Modifier,
 ) {
-    Column(
-        modifier = modifier.fillMaxSize(),
-    ) {
-        MifosBreadcrumbNavBar(navController)
+    val snackbarHostState = remember { SnackbarHostState() }
+    val snackbarMessage = state.snackbarMessage?.let { stringResource(it) }
+    LaunchedEffect(snackbarMessage) {
+        snackbarMessage?.let {
+            snackbarHostState.showSnackbar(it)
+        }
+    }
 
-        Box(
-            modifier = Modifier
-                .fillMaxSize()
-                .padding(horizontal = KptTheme.spacing.md),
+    MifosScaffold(
+        title = stringResource(Res.string.feature_loan_charge_off),
+        onBackPressed = { onAction(LoanChargeOffAction.NavigateBack) },
+        snackbarHostState = snackbarHostState,
+    ) {
+        Column(
+            modifier = modifier.fillMaxSize(),
         ) {
-            when (state.viewState) {
-                is LoanChargeOffState.ViewState.Loading -> {
-                    MifosProgressIndicator()
-                }
+            MifosBreadcrumbNavBar(navController)
 
-                is LoanChargeOffState.ViewState.Error -> {
-                    MifosSweetError(
-                        message = stringResource(state.viewState.message),
-                        onclick = { onAction(LoanChargeOffAction.OnRetry) },
-                    )
-                }
+            Box(
+                modifier = Modifier
+                    .fillMaxSize()
+                    .padding(horizontal = KptTheme.spacing.md),
+            ) {
+                when (state.viewState) {
+                    is LoanChargeOffState.ViewState.Loading -> {
+                        MifosProgressIndicator()
+                    }
+
+                    is LoanChargeOffState.ViewState.Error -> {
+                        MifosSweetError(
+                            message = stringResource(state.viewState.message),
+                            onclick = { onAction(LoanChargeOffAction.OnRetry) },
+                        )
+                    }
 
-                is LoanChargeOffState.ViewState.Success -> {
-                    LoanChargeOffForm(
-                        state = state,
-                        onAction = onAction,
-                    )
+                    is LoanChargeOffState.ViewState.Success -> {
+                        LoanChargeOffForm(
+                            state = state,
+                            onAction = onAction,
+                        )
+                    }
                 }
             }
         }
@@ -254,18 +272,3 @@ private fun LoanChargeOffForm(
         Spacer(modifier = Modifier.height(KptTheme.spacing.md))
     }
 }
-
-@Composable
-private fun LoanChargeOffDialog(
-    state: LoanChargeOffState,
-    onAction: (LoanChargeOffAction) -> Unit,
-) {
-    if (state.dialogMessage != null) {
-        MifosAlertDialog(
-            onConfirmation = { onAction(LoanChargeOffAction.DismissDialog) },
-            dialogText = stringResource(state.dialogMessage),
-            onDismissRequest = {},
-            dismissText = null,
-        )
-    }
-}

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanChargeOff/LoanChargeOffState.kt

@@ -25,7 +25,7 @@ constructor(
     val showDatePicker: Boolean = false,
     val isReasonError: Boolean = false,
     val isSubmitting: Boolean = false,
-    val dialogMessage: StringResource? = null,
+    val snackbarMessage: StringResource? = null,
 ) {
     sealed interface ViewState {
         data object Loading : ViewState

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanChargeOff/LoanChargeOffViewModel.kt

@@ -95,7 +95,7 @@ internal class LoanChargeOffViewModel(
                 mutableStateFlow.update {
                     it.copy(
                         isSubmitting = false,
-                        dialogMessage = Res.string.feature_loan_charge_off_failed,
+                        snackbarMessage = Res.string.feature_loan_charge_off_failed,
                     )
                 }
             }
@@ -110,7 +110,7 @@ internal class LoanChargeOffViewModel(
                 mutableStateFlow.update {
                     it.copy(
                         isSubmitting = false,
-                        dialogMessage = Res.string.feature_loan_charge_off_success,
+                        snackbarMessage = Res.string.feature_loan_charge_off_success,
                     )
                 }
                 sendEvent(LoanChargeOffEvent.ChargeOffSuccess)
@@ -138,7 +138,6 @@ internal class LoanChargeOffViewModel(
         when (action) {
             LoanChargeOffAction.NavigateBack -> sendEvent(LoanChargeOffEvent.NavigateBack)
             LoanChargeOffAction.OnRetry -> loadTemplate()
-            LoanChargeOffAction.DismissDialog -> mutableStateFlow.update { it.copy(dialogMessage = null) }
             is LoanChargeOffAction.ReasonSelected -> handleReasonSelection(action.index)
 
             is LoanChargeOffAction.TransactionDateChanged ->
@@ -172,7 +171,6 @@ sealed interface LoanChargeOffEvent {
 sealed interface LoanChargeOffAction {
     data object NavigateBack : LoanChargeOffAction
     data object OnRetry : LoanChargeOffAction
-    data object DismissDialog : LoanChargeOffAction
     data class ReasonSelected(val index: Int) : LoanChargeOffAction
     data class TransactionDateChanged(val dateMillis: Long) : LoanChargeOffAction
     data class ExternalIdChanged(val value: String) : LoanChargeOffAction