Remove the default parameter values for LoanChargeOffRequestDto to avoid the serializer omitting the default values issue

Author: sahilshivekar

core/model/src/commonMain/kotlin/com/mifos/core/model/objects/account/loan/LoanChargeOffInput.kt

@@ -17,5 +17,5 @@ data class LoanChargeOffInput(
     val externalId: String? = null,
     val note: String? = null,
     val locale: String = DateConstants.LOCALE,
-    val dateFormat: String = DateConstants.DATE_FORMAT,
+    val dateFormat: String = "dd-MM-yyyy",
 )

core/network/src/commonMain/kotlin/com/mifos/core/network/dto/loans/LoanChargeOffRequestDto.kt

@@ -9,7 +9,6 @@
  */
 package com.mifos.core.network.dto.loans
 
-import com.mifos.core.model.utils.DateConstants
 import kotlinx.serialization.Serializable
 
 @Serializable
@@ -18,6 +17,6 @@ data class LoanChargeOffRequestDto(
     val transactionDate: String,
     val externalId: String? = null,
     val note: String? = null,
-    val locale: String = DateConstants.LOCALE,
-    val dateFormat: String = DateConstants.DATE_FORMAT,
+    val locale: String,
+    val dateFormat: String,
 )

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanAccountAction/LoanAccountActionItem.kt

@@ -145,6 +145,8 @@ import androidclient.feature.loan.generated.resources.feature_loan_action_withdr
 import androidclient.feature.loan.generated.resources.feature_loan_action_withdrawn_by_client_sub
 import androidclient.feature.loan.generated.resources.feature_loan_action_write_off
 import androidclient.feature.loan.generated.resources.feature_loan_action_write_off_sub
+import androidclient.feature.loan.generated.resources.feature_loan_charge_off
+import androidclient.feature.loan.generated.resources.feature_loan_charge_off_subtitle
 import androidclient.feature.loan.generated.resources.feature_loan_create_guarantors
 import androidclient.feature.loan.generated.resources.feature_loan_create_guarantors_sub
 import androidclient.feature.loan.generated.resources.feature_loan_merchant_issued_refund_schedule
@@ -439,4 +441,10 @@ sealed class LoanAccountActionItem(
         subTitle = LoanRes.string.feature_loan_action_merchant_issued_refund_sub,
         icon = UiRes.drawable.merchant_issued_refund,
     )
+
+    data object LoanChargeOff : LoanAccountActionItem(
+        title = LoanRes.string.feature_loan_charge_off,
+        subTitle = LoanRes.string.feature_loan_charge_off_subtitle,
+        icon = UiRes.drawable.charge_off,
+    )
 }

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanAccountAction/LoanAccountActionNavigation.kt

@@ -23,6 +23,7 @@ fun NavGraphBuilder.loanAccountActionDestination(
     navController: NavController,
     onNavigateBack: () -> Unit,
     navigateToPaymentsActionScreen: () -> Unit,
+    navigateToChargeOff: (loanId: Int) -> Unit,
     // add other actions navigation lambda parameters here
 ) {
     composable<LoanAccountActionRoute> {
@@ -78,6 +79,7 @@ fun NavGraphBuilder.loanAccountActionDestination(
                     LoanAccountActionItem.WithdrawnByClient -> {}
                     LoanAccountActionItem.WriteOff -> {}
                     LoanAccountActionItem.WaiveInterest -> {}
+                    LoanAccountActionItem.LoanChargeOff -> navigateToChargeOff(loanId)
                 }
             },
         )

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanAccountProfile/LoanAccountProfileNavigation.kt

@@ -34,12 +34,11 @@ fun NavGraphBuilder.loanProfileAccountDestination(
     approveLoan: (Int, LoanWithAssociationsEntity) -> Unit,
     onRepaymentClick: (LoanWithAssociationsEntity) -> Unit,
     navigateToTransferScreen: (loanId: Int) -> Unit,
-    navigateToChargeOff: (Int) -> Unit,
 ) {
     composable<LoanAccountRoute> {
         LoanAccountProfileScreen(
-            onNavigateBack = onNavigateBack,
             navController = navController,
+            onNavigateBack = onNavigateBack,
             navigateToRepaymentSchedule = navigateToRepaymentSchedule,
             navigateToTransactions = navigateToTransactions,
             navigateToCharges = navigateToCharges,
@@ -50,7 +49,6 @@ fun NavGraphBuilder.loanProfileAccountDestination(
             approveLoan = approveLoan,
             onRepaymentClick = onRepaymentClick,
             navigateToTransferScreen = navigateToTransferScreen,
-            navigateToChargeOff = navigateToChargeOff,
             navigateToLoanAction = navigateToLoanAction,
         )
     }

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanAccountProfile/LoanAccountProfileScreen.kt

@@ -77,6 +77,7 @@ import template.core.base.designsystem.theme.KptTheme
 
 @Composable
 internal fun LoanAccountProfileScreen(
+    navController: NavController,
     onNavigateBack: () -> Unit,
     approveLoan: (Int, LoanWithAssociationsEntity) -> Unit,
     onRepaymentClick: (LoanWithAssociationsEntity) -> Unit,
@@ -88,9 +89,7 @@ internal fun LoanAccountProfileScreen(
     navigateToNotes: (Int) -> Unit,
     navigateToLoanAction: (Int) -> Unit,
     navigateToTransferScreen: (loanId: Int) -> Unit,
-    navigateToChargeOff: (Int) -> Unit,
     navigateToDashboard: (Int) -> Unit,
-    navController: NavController,
     modifier: Modifier = Modifier,
     viewModel: LoanAccountProfileViewModel = koinViewModel(),
 ) {
@@ -128,9 +127,7 @@ internal fun LoanAccountProfileScreen(
                     LoanAccountProfileActionItem.Reschedules -> navigateToReschedules(loanId)
                     LoanAccountProfileActionItem.Dashboard -> navigateToDashboard(loanId)
                     LoanAccountProfileActionItem.Notes -> navigateToNotes(loanId)
-                    LoanAccountProfileActionItem.LoanChargeOff -> navigateToChargeOff(loanId)
                     else -> {}
-
                 }
             }
 

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanAccountProfile/components/LoanAccountProfileActionItem.kt

@@ -11,7 +11,6 @@ package com.mifos.feature.loan.loanAccountProfile.components
 
 import androidclient.core.ui.generated.resources.account_details
 import androidclient.core.ui.generated.resources.autorenew
-import androidclient.core.ui.generated.resources.charge_off
 import androidclient.core.ui.generated.resources.charges
 import androidclient.core.ui.generated.resources.collateral
 import androidclient.core.ui.generated.resources.dashboard
@@ -23,8 +22,6 @@ import androidclient.core.ui.generated.resources.repayment_schedule
 import androidclient.core.ui.generated.resources.reschedules
 import androidclient.core.ui.generated.resources.term_variations
 import androidclient.core.ui.generated.resources.transaction
-import androidclient.feature.loan.generated.resources.feature_loan_charge_off
-import androidclient.feature.loan.generated.resources.feature_loan_charge_off_subtitle
 import androidclient.feature.loan.generated.resources.feature_loan_profile_item_account_details_subtitle
 import androidclient.feature.loan.generated.resources.feature_loan_profile_item_account_details_title
 import androidclient.feature.loan.generated.resources.feature_loan_profile_item_charges_subtitle
@@ -128,12 +125,6 @@ sealed class LoanAccountProfileActionItem(
         subTitle = LoanRes.string.feature_loan_profile_item_standing_instructions_subtitle,
         icon = UiRes.drawable.autorenew,
     )
-
-    data object LoanChargeOff : LoanAccountProfileActionItem(
-        title = LoanRes.string.feature_loan_charge_off,
-        subTitle = LoanRes.string.feature_loan_charge_off_subtitle,
-        icon = UiRes.drawable.charge_off,
-    )
 }
 
 internal val loanProfileActionItems: ImmutableList<LoanAccountProfileActionItem> = persistentListOf(
@@ -150,5 +141,4 @@ internal val loanProfileActionItems: ImmutableList<LoanAccountProfileActionItem>
     LoanAccountProfileActionItem.Documents,
     LoanAccountProfileActionItem.Notes,
     LoanAccountProfileActionItem.StandingInstructions,
-    LoanAccountProfileActionItem.LoanChargeOff,
 )

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/navigation/LoanNavigation.kt

@@ -116,13 +116,13 @@ fun NavGraphBuilder.loanDestination(
         navigateToTransferScreen = navController::navigateToTransferScreen,
         navigateToLoanAction = navController::navigateToLoanAccountActionScreen,
         navigateToReschedules = navController::navigateToLoanReschedulesScreen,
-        navigateToChargeOff = navController::navigateToLoanChargeOffScreen,
     )
 
     loanAccountActionDestination(
         navController = navController,
         onNavigateBack = navController::popBackStack,
         navigateToPaymentsActionScreen = navController::navigateToLoanPaymentsAction,
+        navigateToChargeOff = navController::navigateToLoanChargeOffScreen,
     )
 
     loanPaymentsActionDestination(