Commit 655ee2a
fix(build): unblock gradle build — wrapper 9.5.0 + catalog sync + libs/mifos-passcode removal + sync-dirs heal
After commit ac2fbe2 (T0.1 quarantine) + da586a7 (16 alias catch-up), the
Test Coverage Floor workflow on PR #2691 still failed at gradle script
compilation. Local reproduction with openjdk@17 surfaced a chain of compounding
issues; this commit fixes them so `./gradlew help` now succeeds.
`--no-verify` used per user direction — detekt has many pre-existing violations
across the codebase (long parameter lists, parameter order) unrelated to this
commit's changes. Detekt cleanup is a separate wave.
Major changes:
1. Gradle wrapper 8.13 → 9.5.0 (gradle/wrapper/*) — kmp-product-flavors:2.4.2
ships Kotlin 2.2 metadata; Gradle 8.13's kotlin-dsl uses Kotlin 2.0.21 which
max-reads metadata 2.1. Matches template's wrapper version.
2. Root build.gradle.kts — added:
- buildscript classpath R8 9.1.31 pin (understands Kotlin 2.3.20 metadata)
- Root kover + kover.convention plugin registration so KoverConventionPlugin
can apply at per-module level
- subprojects resolutionStrategy forcing JetBrains androidx.lifecycle 2.9.6
+ savedstate 1.3.6 (resolves KLIB resolver duplicate-warnings)
- failOnNoDiscoveredTests = false per-test-task (Gradle 9 KMP compat)
- roborazzi alias
3. gradle/libs.versions.toml — catalog catch-up:
- Added missing version refs: appPackage
- Added missing library alias: compottie (bare, alongside -lite/-resources;
core-base/ui/build.gradle.kts uses `libs.compottie` directly which
Gradle 9 rejected when only sub-aliases existed)
- Stripped `version = "unspecified"` from 15 convention-plugin aliases
(Gradle 9 rejects with "Error resolving plugin … plugin is already on
the classpath with an unknown version")
- Removed androidx-hilt-navigation-compose + androidxHiltNavigationCompose
(field-officer is Koin-only per user direction; the only reference was
in libs/mifos-passcode which is deleted in this commit)
4. Deleted libs/mifos-passcode/ entirely (109 files) — vendored legacy
Hilt-based library excluded from build since 2024 (settings.gradle.kts
had `//include(":libs:mifos-passcode")` commented). Functionality replaced
by feature/passcode (Koin-based, scheduled W2 in
active/feature-vertical-migration/PLAN.md). Removed commented include from
settings.gradle.kts.
5. core/network/build.gradle.kts — removed `add("kspIosX64", libs.ktorfit.ksp)`
(TS-2 dropped iosX64 target; this reference triggered "Configuration with
name 'kspIosX64' not found" at config time).
6. sync-dirs self-heal (mirrors openMF/kmp-project-template PR #163):
- .github/workflows/sync-dirs.yaml: new "Heal libs.versions.toml" step
between sync + temp-branch cleanup. Detects build-logic `libs.<X>` refs
unresolved in consumer catalog, pulls them (and their referenced version
keys) from upstream via `git show $TEMP_BRANCH:gradle/libs.versions.toml`.
- sync-dirs.sh: matching heal_libs_versions_toml() function for local CLI.
Eliminates the failure mode that required this commit's manual catch-up.
7. File renames for ktlint compliance:
- core/ui/.../ViewModelTypes.kt → BaseViewModel.kt (single typealias)
- feature/document/.../DocumentRoute.kt → DocumentListRoute.kt
- feature/path-tracking/.../PathTrackingRoute.kt → PathTrackingScreenRoute.kt
- feature/search/.../SearchRoute.kt → SearchScreenRoute.kt
8. core/data/.../legacy/di/RepositoryModule.legacy.kt — added @file:Suppress
"ktlint:standard:no-empty-file" + a private object marker. The file is
intentionally a /* */ block-commented reference (legacy/ is gradle-excluded)
but spotless still scans it.
Verification (with openjdk@17):
✅ ./gradlew help — BUILD SUCCESSFUL
✅ ./gradlew -p build-logic help — BUILD SUCCESSFUL
✅ ./gradlew spotlessApply — BUILD SUCCESSFUL
1 parent da586a7 commit 655ee2a
252 files changed
Lines changed: 717 additions & 2006 deletions
File tree
- .github/workflows
- cmp-android
- src
- main
- kotlin/cmp/android/app
- prod
- core
- database/src/commonMain/kotlin/com/mifos/room
- center
- converter
- dao
- entity
- charge/entity
- client
- dao
- entity
- group
- dao
- entity
- loan
- converter
- dao
- entity
- savings
- dao
- entity
- typeconverters
- data/src
- androidMain/kotlin/com/mifos/core/data/di
- commonMain/kotlin/com/mifos/core/data
- activate
- impl
- auth/impl
- legacy
- di
- repositoryImp
- repositoryImp
- repository
- searchrecord/local
- domain/src/commonMain/kotlin/com/mifos/core/domain/useCases
- model/src/commonMain/kotlin/com/mifos/core/model
- network/fixedDeposit
- objects
- account
- loan
- saving
- collectionsheets
- collectionsheet
- databaseobjects
- error
- noncoreobjects
- recurringdeposit
- template/loan
- network
- src/commonMain/kotlin/com/mifos/core/network
- center/api
- checkerinbox/api
- client/api
- collectionsheet/api
- di
- loan/api
- note/api
- pathtracking/api
- recurringdeposit/api
- savings/api
- store
- src/commonMain/kotlin/com/mifos/core/store
- di
- ui/src/commonMain/kotlin/com/mifos/core/ui/store
- feature
- activate/src/commonMain/kotlin/com/mifos/feature/activate/ui
- center/src/commonMain/kotlin/com/mifos/feature/center
- centerGroupList
- syncCentersDialog
- client/src/commonMain/kotlin/com/mifos/feature/client
- charges
- clientAddress
- clientClosure
- clientCollateralDetails
- clientCollateral
- clientDetailsProfile
- clientDetails
- clientDocuments
- clientEditDetails
- clientEditProfile
- clientGeneral
- clientIdentifiersAddUpdate
- clientIdentifiersList
- clientLoanAccounts
- clientProfile
- clientStaff
- clientTransfer
- clientUpcomingCharges
- clientUpdateDefaultAccount
- createNewClient
- newFixedDepositAccount
- syncClientDialog
- collectionSheet/src/commonMain/kotlin/com/mifos/feature/individualCollectionSheet
- generateCollectionSheet
- individualCollectionSheetDetails
- individualCollectionSheet
- newIndividualCollectionSheet
- paymentDetails
- data-table/src/commonMain/kotlin/com/mifos/feature/dataTable
- dataTableList
- document/src/commonMain/kotlin/com/mifos/feature/document
- ui
- groups/src/commonMain/kotlin/com/mifos/feature/groups
- groupDetails
- syncGroupDialog
- loan/src/commonMain/kotlin/com/mifos/feature/loan
- loanAccountProfile
- loanAccount
- loanApproval
- loanDisbursement
- loanRepayment
- newLoanAccount
- offline/src/commonMain/kotlin/com/mifos/feature/offline
- syncCenterPayloads
- syncClientPayloads
- syncGroupPayloads
- syncLoanRepaymentTransaction
- syncSavingsAccountTransaction
- path-tracking/src
- androidMain/kotlin/com/mifos/feature/path/tracking/ui
- commonMain/kotlin/com/mifos/feature/path/tracking
- di
- recurringDeposit/src/commonMain/kotlin/com/mifos/feature/recurringDeposit/newRecurringDepositAccount
- savings/src/commonMain/kotlin/com/mifos/feature/savings
- savingsAccountApproval
- savingsAccountSummary
- savingsAccountTransaction
- savingsAccountv2
- savingsAccount
- search-record/src/commonMain/kotlin/com/mifos/feature/searchrecord/ui
- search/src/commonMain/kotlin/com/mifos/feature/search
- ui
- gradle
- wrapper
- libs/mifos-passcode
- src/main
- kotlin/org/mifos/library/passcode
- component
- data
- di
- theme
- utility
- viewmodels
- res
- drawable
- font
- values
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
249 | 249 | | |
250 | 250 | | |
251 | 251 | | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
252 | 372 | | |
253 | 373 | | |
254 | 374 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
4 | 25 | | |
5 | 26 | | |
6 | 27 | | |
| |||
28 | 49 | | |
29 | 50 | | |
30 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
31 | 60 | | |
32 | 61 | | |
33 | 62 | | |
| |||
47 | 76 | | |
48 | 77 | | |
49 | 78 | | |
50 | | - | |
| 79 | + | |
51 | 80 | | |
52 | 81 | | |
53 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
54 | 108 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
0 commit comments