Skip to content

Commit 3e3eca6

Browse files
committed
refactor(feature:client): clean up unused code
1 parent f5d7401 commit 3e3eca6

5 files changed

Lines changed: 4 additions & 54 deletions

File tree

core/data/src/commonMain/kotlin/com/mifos/core/data/repositoryImp/ClientDetailsRepositoryImp.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class ClientDetailsRepositoryImp(
2121
private val dataManagerClient: DataManagerClient,
2222
) : ClientDetailsRepository {
2323

24-
override suspend fun uploadClientImage(clientId: Int, image: String) {
24+
override suspend fun uploadClientImage(clientId: Int, image: PlatformFile) {
2525
dataManagerClient.uploadClientImage(
2626
clientId = clientId,
2727
typedFile = "data:image/png;base64,$image",

feature/client/src/androidMain/kotlin/com/mifos/feature/client/clientDetails/ClientDetailsScreen.android.kt

Lines changed: 0 additions & 18 deletions
This file was deleted.
Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,9 @@
11
package com.mifos.feature.client.createNewClient
22

3-
import android.content.Context
43
import android.telephony.PhoneNumberUtils
5-
import java.io.File
6-
import androidx.compose.ui.platform.LocalContext
74

85
actual object PhoneNumberUtil {
96
actual fun isGlobalPhoneNumber(phoneNumber: String): Boolean {
107
return PhoneNumberUtils.isGlobalPhoneNumber(phoneNumber)
118
}
12-
}
13-
14-
actual suspend fun createTempImageFile(): File {
15-
// Needs Android context
16-
val context = LocalContext.current
17-
val imageFileName = "clients_image"
18-
return File.createTempFile(
19-
imageFileName,
20-
".png",
21-
context.externalCacheDir,
22-
)
239
}

feature/client/src/commonMain/kotlin/com/mifos/feature/client/clientDetails/ClientDetailsScreen.kt

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,9 @@
77
*
88
* See https://github.com/openMF/android-client/blob/master/LICENSE.md
99
*/
10-
@file:OptIn(ExperimentalMaterial3Api::class, ExperimentalPermissionsApi::class)
11-
10+
@file:OptIn(ExperimentalMaterial3Api::class)
1211
package com.mifos.feature.client.clientDetails
1312

14-
import android.Manifest
15-
import android.content.Context
16-
import android.graphics.BitmapFactory
17-
import android.net.Uri
18-
import androidx.activity.compose.rememberLauncherForActivityResult
19-
import androidx.activity.result.contract.ActivityResultContracts
2013
import androidx.compose.animation.animateContentSize
2114
import androidx.compose.animation.core.LinearOutSlowInEasing
2215
import androidx.compose.animation.core.animateFloatAsState
@@ -66,8 +59,6 @@ import androidx.compose.ui.Modifier
6659
import androidx.compose.ui.draw.clip
6760
import androidx.compose.ui.draw.rotate
6861
import androidx.compose.ui.graphics.Color
69-
import androidx.compose.ui.graphics.asAndroidBitmap
70-
import androidx.compose.ui.graphics.asImageBitmap
7162
import androidx.compose.ui.graphics.vector.ImageVector
7263
import androidx.compose.ui.layout.ContentScale
7364
import androidclient.feature.client.generated.resources.Res
@@ -106,12 +97,8 @@ import androidx.compose.ui.text.style.TextAlign
10697
import androidx.compose.ui.unit.dp
10798
import androidx.compose.ui.window.Dialog
10899
import androidx.compose.ui.window.DialogProperties
109-
import androidx.core.content.FileProvider
110100
import androidx.lifecycle.compose.collectAsStateWithLifecycle
111101
import coil3.compose.AsyncImage
112-
import com.google.accompanist.permissions.ExperimentalPermissionsApi
113-
import com.google.accompanist.permissions.isGranted
114-
import com.google.accompanist.permissions.rememberMultiplePermissionsState
115102
import com.mifos.core.common.utils.Utils
116103
import com.mifos.core.designsystem.component.MifosCircularProgress
117104
import com.mifos.core.designsystem.component.MifosMenuDropDownItem
@@ -125,8 +112,6 @@ import com.mifos.room.entities.accounts.savings.SavingsAccountEntity
125112
import kotlinx.coroutines.launch
126113
import org.jetbrains.compose.resources.stringResource
127114
import org.koin.compose.viewmodel.koinViewModel
128-
import java.io.File
129-
import java.util.Objects
130115

131116
/**
132117
* Created by Aditya Gupta on 18/03/24.
@@ -159,7 +144,6 @@ internal fun ClientDetailsScreen(
159144
var clientNotFoundError by rememberSaveable { mutableStateOf(false) }
160145
var showMenu by remember { mutableStateOf(false) }
161146
var showSelectImageDialog by remember { mutableStateOf(false) }
162-
var imageUri by remember { mutableStateOf<Uri?>(null) }
163147
val snackbarHostState = remember { SnackbarHostState() }
164148

165149
val file = context.createImageFile()

feature/client/src/commonMain/kotlin/com/mifos/feature/client/createNewClient/CreateNewClientScreen.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ import com.mifos.room.entities.templates.clients.ClientsTemplateEntity
120120
import io.github.vinceglb.filekit.PlatformFile
121121
import io.github.vinceglb.filekit.dialogs.FileKitType
122122
import io.github.vinceglb.filekit.dialogs.compose.rememberFilePickerLauncher
123-
import io.github.vinceglb.filekit.path
124123
import kotlinx.coroutines.CoroutineScope
125124
import kotlinx.coroutines.launch
126125
import kotlinx.datetime.Clock
@@ -358,7 +357,7 @@ private fun CreateNewClientContent(
358357
onDismissRequest = { showImagePickerDialog = false },
359358
takeImage = {
360359
showImagePickerDialog = false
361-
cameraLauncher.launch()
360+
// cameraLauncher.launch()
362361
},
363362
uploadImage = {
364363
showImagePickerDialog = false
@@ -587,7 +586,7 @@ private fun handleSubmitClick(
587586
createClient: (clientPayload: ClientPayloadEntity) -> Unit,
588587
isActive: Boolean,
589588
onHasDatatables: (datatables: List<DataTableEntity>, clientPayload: ClientPayloadEntity) -> Unit,
590-
selectedImage: PlatformFile,
589+
selectedImage: PlatformFile?,
591590
staffInOffices: List<StaffEntity>,
592591
hasDatatables: Boolean,
593592
selectedOfficeId: Int?,
@@ -623,7 +622,6 @@ private fun handleSubmitClick(
623622
onHasDatatables.invoke(it, clientPayload)
624623
}
625624
} else {
626-
setUriForUpload.invoke(selectedImage.path)
627625
clientPayload = clientPayload.copy(
628626
datatables = null,
629627
)

0 commit comments

Comments
 (0)