feat(auth): Phase C Wave 2 — Login end-to-end Store5 migration

Second end-to-end feature wave. Adds the auth resource API + relocates
the Login chain following the Wave 1 template.

core/network/auth/api/AuthApi.kt (NEW)
  Suspend Ktorfit interface for Fineract authentication endpoints.
  Future auth-wave additions (OTP, refresh, logout) extend this same file.

core/network/di/NetworkModule.kt
  + single { get<Ktorfit>().createAuthApi() }

Method-level @deprecated on legacy login paths:
  - DataManagerAuth.login
  - ClientService.authenticate
Both surfaces stay compileable for un-migrated callers; Phase D deletes
them once nothing references them.

core/data/auth/ (relocate + rewrite)
  git mv core/data/repository/LoginRepository.kt
      -> core/data/auth/LoginRepository.kt
  git mv core/data/repositoryImp/LoginRepositoryImp.kt
      -> core/data/auth/impl/LoginRepositoryImpl.kt (renamed)
  Impl now consumes AuthApi directly; no DataManagerAuth dependency.
  RepositoryModule import updated; binding remains in core/data.

core/domain (delete pure-delegator use case)
  - useCases/LoginUseCase.kt           (deleted)
  - di/UseCaseModule.kt: factoryOf(::LoginUseCase) removed
  Surviving use cases: UsernameValidationUseCase + PasswordValidationUseCase
  (validators — kept per the core/domain rule).

feature/auth/{ui, di, navigation}/ (restructure with MVI triple)
  ui/
    LoginState.kt    — validation-error state (pre-submit gate)
    LoginAction.kt   — sealed Submit / DismissError
    LoginEvent.kt    — sealed NavigateToPasscode / ShowError(StringResource)
    LoginViewModel.kt — extends BaseViewModel<LoginState, LoginEvent, LoginAction>
                        with SubmitHandler<PostAuthenticationResponse>.
                        Submitted -> persist user via prefManager, emit
                        NavigateToPasscode event. authenticated != true also
                        routes to ShowError. Failed -> ShowError.
    LoginScreen.kt    — uses MifosProgressIndicatorOverlay during submit;
                        Snackbar for error events; passcode navigation on
                        success. Includes 3 @Preview functions (Idle,
                        Submitting, ValidationError) using
                        org.jetbrains.compose.ui.tooling.preview.* (KMP-aware).
  di/AuthModule.kt    — import updated to ui/ package; viewModelOf-only
                        (Repository binding lives in core/data
                        RepositoryModule per the Koin DI ownership boundary).
  navigation/
    LoginRoute.kt     — @serializable object (split from AuthNavigation)
    AuthNavigation.kt — NavGraphBuilder.authNavGraph + nav extensions

No hardcoded user-facing strings:
  composeResources additions:
    feature_auth_update_server_configuration
    feature_auth_cd_arrow_forward
    feature_auth_cd_error_icon
    feature_auth_cd_password_visibility
  All button labels, content descriptions consume stringResource(...).

feature/auth/build.gradle.kts
  + implementation(projects.core.ui)
  Other deps unchanged (core.data + core.domain for validators).

Grep invariants pass: zero DataState, zero MifosProgressIndicator legacy
imports, zero user-facing string literals, file layout matches plan.

Author: Rajan Maurya

…/core/data/repository/LoginRepository.kt …/mifos/core/data/auth/LoginRepository.ktcore/data/src/commonMain/kotlin/com/mifos/core/data/repository/LoginRepository.kt renamed to core/data/src/commonMain/kotlin/com/mifos/core/data/auth/LoginRepository.kt core/data/src/commonMain/kotlin/com/mifos/core/data/repository/LoginRepository.kt renamed to core/data/src/commonMain/kotlin/com/mifos/core/data/auth/LoginRepository.kt

@@ -7,15 +7,17 @@
  *
  * See https://github.com/openMF/mifos-x-field-officer-app/blob/master/LICENSE.md
  */
-package com.mifos.core.data.repository
+package com.mifos.core.data.auth
 
 import com.mifos.core.network.model.PostAuthenticationResponse
 
-/**
- * Created by Aditya Gupta on 06/08/23.
- */
-
 interface LoginRepository {
 
+    /**
+     * Sends credentials to Fineract's `/authentication` endpoint. Returns the typed
+     * response on success; throws on transport/HTTP failure (caller wraps in
+     * `SubmitHandler.submit { ... }` for structured Submitting / Submitted / Failed
+     * lifecycle).
+     */
     suspend fun login(username: String, password: String): PostAuthenticationResponse
 }

…data/repositoryImp/LoginRepositoryImp.kt …re/data/auth/impl/LoginRepositoryImpl.ktcore/data/src/commonMain/kotlin/com/mifos/core/data/repositoryImp/LoginRepositoryImp.kt renamed to core/data/src/commonMain/kotlin/com/mifos/core/data/auth/impl/LoginRepositoryImpl.kt core/data/src/commonMain/kotlin/com/mifos/core/data/repositoryImp/LoginRepositoryImp.kt renamed to core/data/src/commonMain/kotlin/com/mifos/core/data/auth/impl/LoginRepositoryImpl.kt

@@ -7,21 +7,19 @@
  *
  * See https://github.com/openMF/mifos-x-field-officer-app/blob/master/LICENSE.md
  */
-package com.mifos.core.data.repositoryImp
+package com.mifos.core.data.auth.impl
 
-import com.mifos.core.data.repository.LoginRepository
-import com.mifos.core.network.datamanager.DataManagerAuth
+import com.mifos.core.data.auth.LoginRepository
+import com.mifos.core.network.auth.api.AuthApi
+import com.mifos.core.network.model.PostAuthenticationRequest
 import com.mifos.core.network.model.PostAuthenticationResponse
 
-/**
- * Created by Aditya Gupta on 06/08/23.
- */
-
-class LoginRepositoryImp(
-    private val dataManagerAuth: DataManagerAuth,
+class LoginRepositoryImpl(
+    private val authApi: AuthApi,
 ) : LoginRepository {
 
-    override suspend fun login(username: String, password: String): PostAuthenticationResponse {
-        return dataManagerAuth.login(username.trim(), password.trim())
-    }
+    override suspend fun login(username: String, password: String): PostAuthenticationResponse =
+        authApi.authenticate(
+            PostAuthenticationRequest(username = username.trim(), password = password.trim()),
+        )
 }

core/data/src/commonMain/kotlin/com/mifos/core/data/di/RepositoryModule.kt

@@ -51,7 +51,8 @@ import com.mifos.core.data.repository.LoanRepaymentRepository
 import com.mifos.core.data.repository.LoanRepaymentScheduleRepository
 import com.mifos.core.data.repository.LoanReschedulesRepository
 import com.mifos.core.data.repository.LoanTransactionsRepository
-import com.mifos.core.data.repository.LoginRepository
+import com.mifos.core.data.auth.LoginRepository
+import com.mifos.core.data.auth.impl.LoginRepositoryImpl
 import com.mifos.core.data.repository.NewIndividualCollectionSheetRepository
 import com.mifos.core.data.repository.NoteRepository
 import com.mifos.core.data.repository.OfflineDashboardRepository
@@ -119,7 +120,6 @@ import com.mifos.core.data.repositoryImp.LoanRepaymentRepositoryImp
 import com.mifos.core.data.repositoryImp.LoanRepaymentScheduleRepositoryImp
 import com.mifos.core.data.repositoryImp.LoanReschedulesRepositoryImpl
 import com.mifos.core.data.repositoryImp.LoanTransactionsRepositoryImp
-import com.mifos.core.data.repositoryImp.LoginRepositoryImp
 import com.mifos.core.data.repositoryImp.NewIndividualCollectionSheetRepositoryImp
 import com.mifos.core.data.repositoryImp.NoteRepositoryImp
 import com.mifos.core.data.repositoryImp.OfflineDashboardRepositoryImp
@@ -162,7 +162,7 @@ import org.mifos.authenticator.passcode.PasscodeStorageAdapter
 val RepositoryModule = module {
     single<CoroutineDispatcher> { get(named(MifosDispatchers.IO.name)) }
 
-    singleOf(::LoginRepositoryImp) bind LoginRepository::class
+    singleOf(::LoginRepositoryImpl) bind LoginRepository::class
     singleOf(::SearchRepositoryImp) bind SearchRepository::class
 
     // Client

core/domain/src/commonMain/kotlin/com/mifos/core/domain/di/UseCaseModule.kt

@@ -67,7 +67,6 @@ import com.mifos.core.domain.useCases.GetStaffInOfficeUseCase
 import com.mifos.core.domain.useCases.GetUserPathTrackingUseCase
 import com.mifos.core.domain.useCases.GroupsListPagingDataSource
 import com.mifos.core.domain.useCases.LoadSavingsAccountsAndTemplateUseCase
-import com.mifos.core.domain.useCases.LoginUseCase
 import com.mifos.core.domain.useCases.PasswordValidationUseCase
 import com.mifos.core.domain.useCases.RejectCheckerUseCase
 import com.mifos.core.domain.useCases.RemoveDocumentUseCase
@@ -144,7 +143,6 @@ val UseCaseModule = module {
     factoryOf(::GetUserPathTrackingUseCase)
     factoryOf(::GroupsListPagingDataSource)
     factoryOf(::LoadSavingsAccountsAndTemplateUseCase)
-    factoryOf(::LoginUseCase)
     factoryOf(::PasswordValidationUseCase)
     factoryOf(::RejectCheckerUseCase)
     factoryOf(::RemoveDocumentUseCase)

core/domain/src/commonMain/kotlin/com/mifos/core/domain/useCases/LoginUseCase.kt

@@ -0,0 +1,27 @@
+/*
+ * Copyright 2025 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/mifos-x-field-officer-app/blob/master/LICENSE.md
+ */
+package com.mifos.core.network.auth.api
+
+import com.mifos.core.network.model.PostAuthenticationRequest
+import com.mifos.core.network.model.PostAuthenticationResponse
+import de.jensklingenberg.ktorfit.http.Body
+import de.jensklingenberg.ktorfit.http.POST
+
+/**
+ * Fineract `authentication` endpoints. Future auth-feature waves (OTP, refresh, logout)
+ * add more methods here.
+ */
+interface AuthApi {
+
+    @POST("authentication")
+    suspend fun authenticate(
+        @Body request: PostAuthenticationRequest,
+    ): PostAuthenticationResponse
+}

core/network/src/commonMain/kotlin/com/mifos/core/network/auth/api/AuthApi.kt

@@ -24,6 +24,10 @@ class DataManagerAuth(
      * @param password Password
      * @return Basic OAuth
      */
+    @Deprecated(
+        message = "Use com.mifos.core.network.auth.api.AuthApi.authenticate instead",
+        level = DeprecationLevel.WARNING,
+    )
     suspend fun login(username: String, password: String): PostAuthenticationResponse {
         val body = PostAuthenticationRequest(username = username, password = password)
         return baseApiManager.clientService.authenticate(body)

core/network/src/commonMain/kotlin/com/mifos/core/network/datamanager/DataManagerAuth.kt

@@ -14,6 +14,7 @@ import com.mifos.core.network.BaseApiManager
 import com.mifos.core.network.KtorHttpClient
 import com.mifos.core.network.KtorfitClient
 import com.mifos.core.network.MifosInterceptor
+import com.mifos.core.network.auth.api.createAuthApi
 import com.mifos.core.network.center.api.createCenterApi
 import com.mifos.core.network.client.api.createClientApi
 import com.mifos.core.network.group.api.createGroupApi
@@ -62,6 +63,7 @@ val NetworkModule = module {
     // Per-resource Api factories (template's per-feature `core/network/<resource>/api/` pattern).
     // Each feature wave adds methods to the matching resource's interface; this DI list grows
     // as new resource APIs are introduced.
+    single { get<Ktorfit>().createAuthApi() }
     single { get<Ktorfit>().createClientApi() }
     single { get<Ktorfit>().createCenterApi() }
     single { get<Ktorfit>().createGroupApi() }

core/network/src/commonMain/kotlin/com/mifos/core/network/di/NetworkModule.kt

@@ -52,6 +52,10 @@ import kotlinx.coroutines.flow.Flow
  */
 interface ClientService {
 
+    @Deprecated(
+        message = "Use com.mifos.core.network.auth.api.AuthApi.authenticate instead",
+        level = DeprecationLevel.WARNING,
+    )
     @POST("authentication")
     suspend fun authenticate(
         @Body postAuthenticationRequest: PostAuthenticationRequest,

core/network/src/commonMain/kotlin/com/mifos/core/network/services/ClientService.kt

@@ -24,6 +24,7 @@ kotlin {
             implementation(compose.ui)
             implementation(projects.core.data)
             implementation(projects.core.domain)
+            implementation(projects.core.ui)
             implementation(compose.components.uiToolingPreview)
         }
     }