Add fix for coderabbitai suggestions

Author: sahilshivekar

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanChargeOff/LoanChargeOffScreen.kt

@@ -46,8 +46,6 @@ import androidx.compose.runtime.remember
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.text.input.KeyboardType
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
-import androidx.navigation.NavController
-import com.mifos.core.common.utils.DateHelper
 import com.mifos.core.designsystem.component.MifosButton
 import com.mifos.core.designsystem.component.MifosDatePickerTextField
 import com.mifos.core.designsystem.component.MifosOutlinedTextField
@@ -56,7 +54,6 @@ import com.mifos.core.designsystem.component.MifosSweetError
 import com.mifos.core.designsystem.component.MifosTextFieldDropdown
 import com.mifos.core.designsystem.theme.DesignToken
 import com.mifos.core.designsystem.theme.MifosTypography
-import com.mifos.core.ui.components.MifosBreadcrumbNavBar
 import com.mifos.core.ui.components.MifosProgressIndicator
 import com.mifos.core.ui.util.EventsEffect
 import org.jetbrains.compose.resources.stringResource
@@ -68,7 +65,6 @@ import kotlin.time.ExperimentalTime
 @Composable
 internal fun LoanChargeOffScreen(
     onNavigateBack: () -> Unit,
-    navController: NavController,
     viewModel: LoanChargeOffViewModel = koinViewModel(),
 ) {
     val state by viewModel.stateFlow.collectAsStateWithLifecycle()
@@ -83,15 +79,13 @@ internal fun LoanChargeOffScreen(
     LoanChargeOffScreenContent(
         state = state,
         onAction = remember(viewModel) { { viewModel.trySendAction(it) } },
-        navController = navController,
     )
 }
 
 @Composable
 private fun LoanChargeOffScreenContent(
     state: LoanChargeOffState,
     onAction: (LoanChargeOffAction) -> Unit,
-    navController: NavController,
     modifier: Modifier = Modifier,
 ) {
     val snackbarHostState = remember { SnackbarHostState() }
@@ -110,8 +104,6 @@ private fun LoanChargeOffScreenContent(
         Column(
             modifier = modifier.fillMaxSize(),
         ) {
-            MifosBreadcrumbNavBar(navController)
-
             Box(
                 modifier = Modifier
                     .fillMaxSize()
@@ -226,7 +218,7 @@ private fun LoanChargeOffForm(
         Spacer(modifier = Modifier.height(DesignToken.padding.large))
 
         MifosDatePickerTextField(
-            value = DateHelper.getDateAsStringFromLong(state.transactionDate),
+            value = state.transactionDateText,
             label = stringResource(Res.string.feature_loan_charge_off_transaction_date) + "*",
             openDatePicker = { onAction(LoanChargeOffAction.ShowDatePicker) },
         )

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanChargeOff/LoanChargeOffScreenRoute.kt

@@ -19,12 +19,10 @@ data class LoanChargeOffRoute(val loanId: Int)
 
 fun NavGraphBuilder.loanChargeOffScreen(
     onNavigateBack: () -> Unit,
-    navController: NavController,
 ) {
     composable<LoanChargeOffRoute> {
         LoanChargeOffScreen(
             onNavigateBack = onNavigateBack,
-            navController = navController,
         )
     }
 }

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanChargeOff/LoanChargeOffState.kt

@@ -20,6 +20,7 @@ constructor(
     val viewState: ViewState = ViewState.Loading,
     val selectedReason: ChargeOffReasonOption? = null,
     val transactionDate: Long = Clock.System.now().toEpochMilliseconds(),
+    val transactionDateText: String = "",
     val externalId: String = "",
     val note: String = "",
     val showDatePicker: Boolean = false,

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanChargeOff/LoanChargeOffViewModel.kt

@@ -141,7 +141,14 @@ internal class LoanChargeOffViewModel(
             is LoanChargeOffAction.ReasonSelected -> handleReasonSelection(action.index)
 
             is LoanChargeOffAction.TransactionDateChanged ->
-                mutableStateFlow.update { it.copy(transactionDate = action.dateMillis) }
+                mutableStateFlow.update {
+                    it.copy(
+                        transactionDate = action.dateMillis,
+                        transactionDateText = DateHelper.getDateAsStringFromLong(
+                            action.dateMillis,
+                        ),
+                    )
+                }
 
             is LoanChargeOffAction.ExternalIdChanged ->
                 mutableStateFlow.update { it.copy(externalId = action.value) }

feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/navigation/LoanNavigation.kt

@@ -89,7 +89,6 @@ fun NavGraphBuilder.loanDestination(
     )
     loanChargeOffScreen(
         onNavigateBack = navController::popBackStack,
-        navController = navController,
     )
     newLoanAccountDestination(
         onNavigateBack = navController::popBackStack,