Handle unexpected types in attributes#432
Merged
fractalwrench merged 1 commit intoopen-telemetry:mainfrom Apr 24, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (23.52%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
- Coverage 89.84% 89.70% -0.15%
==========================================
Files 263 264 +1
Lines 3428 3437 +9
Branches 369 379 +10
==========================================
+ Hits 3080 3083 +3
- Misses 264 269 +5
- Partials 84 85 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bidetofevil
reviewed
Apr 23, 2026
| is Long -> AnyValue(int_value = value) | ||
| is Double -> AnyValue(double_value = value) | ||
| is Float -> AnyValue(double_value = value.toDouble()) | ||
| is Number -> AnyValue(int_value = value.toLong()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Handles unexpected types in attributes by casting them to either
LongorDouble. Closes #409.Testing
Added unit tests.