Skip to content

Commit 734bc28

Browse files
authored
Merge pull request #25 from oslabs-beta/rowData-hotfix
rename row variables
2 parents bd20293 + 06ad898 commit 734bc28

File tree

1 file changed

+20
-15
lines changed

1 file changed

+20
-15
lines changed

src/components/ReactFlow/TableNode.jsx

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,39 +18,44 @@ export default function TableNode({ data }) {
1818
const tableHandles = [];
1919
for (let i = 0; i < data.edges.length; i++) {
2020
if (data.edges[i].source === tableName) {
21-
//make handle placement dynamic, we need to know the row of our source
22-
let rowNumberSource = rowData.findIndex(obj => obj.Name === data.edges[i].sourceHandle) + 1;
23-
if (rowNumberSource === 0) rowNumberSource = 1;
24-
console.log('rowNumberSource', rowNumberSource)
21+
//make handle placement dynamic, we need to know the column of our source
22+
let columnNumberSource =
23+
columnData.findIndex((obj) => obj.Name === data.edges[i].sourceHandle) + 1;
24+
if (columnNumberSource === 0) columnNumberSource = 1;
25+
console.log('columnNumberSource', columnNumberSource);
2526
console.log('data.edges[i].sourceHandle', data.edges[i].sourceHandle);
2627
tableHandles.push(
2728
<Handle
2829
key={`${data.edges[i]}-source-${[i]}`}
2930
type="source"
3031
position={Position.Right}
3132
id={data.edges[i].sourceHandle}
32-
style={{ background: 'transparent',
33-
top: 96 + rowNumberSource * 21,
34-
bottom: 'auto'}}
33+
style={{
34+
background: 'transparent',
35+
top: 96 + columnNumberSource * 21,
36+
bottom: 'auto',
37+
}}
3538
/>
3639
);
3740
}
3841
if (data.edges[i].target === tableName) {
39-
//make handle placement dynamic, we need to know the row of our target
40-
let rowNumberTarget = rowData.findIndex(obj => obj.Name === data.edges[i].targetHandle) + 1;
41-
if (rowNumberTarget === 0) rowNumberTarget = 1;
42-
console.log('rowNumberTarget', rowNumberTarget)
42+
//make handle placement dynamic, we need to know the column of our target
43+
let columnNumberTarget =
44+
columnData.findIndex((obj) => obj.Name === data.edges[i].targetHandle) + 1;
45+
if (columnNumberTarget === 0) columnNumberTarget = 1;
46+
console.log('columnNumberTarget', columnNumberTarget);
4347
console.log('data.edges[i].targetHandle', data.edges[i].targetHandle);
4448
tableHandles.push(
4549
<Handle
4650
key={`${data.edges[i]}-target-${[i]}`}
4751
type="target"
4852
position={Position.Left}
4953
id={data.edges[i].targetHandle}
50-
style={{
51-
background: 'transparent',
52-
top: 96 + rowNumberTarget * 21,
53-
bottom: 'auto'}}
54+
style={{
55+
background: 'transparent',
56+
top: 96 + columnNumberTarget * 21,
57+
bottom: 'auto',
58+
}}
5459
/>
5560
);
5661
}

0 commit comments

Comments
 (0)