Skip to content

Commit 5f66b9c

Browse files
committed
Fixed WSS and header/cookie references
1 parent 56c1040 commit 5f66b9c

File tree

7 files changed

+24
-19
lines changed

7 files changed

+24
-19
lines changed

src/client/components/composer/NewRequest/ComposerNewRequest.jsx

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class ComposerNewRequest extends Component {
4343
const protocol = this.props.newRequestFields.url.match(/(https?:\/\/)|(wss?:\/\/)/)[0]
4444

4545
// HTTP && GRAPHQL REQUESTS
46-
if (this.props.newRequestFields.protocol !== 'ws://') {
46+
if (!/wss?:\/\//.test(this.props.newRequestFields.protocol)) {
4747
let URIWithoutProtocol = `${this.props.newRequestFields.url.split(protocol)[1]}/`;
4848
const host = protocol + URIWithoutProtocol.split('/')[0];
4949
let path = `/${URIWithoutProtocol.split('/')
@@ -157,10 +157,10 @@ class ComposerNewRequest extends Component {
157157

158158
render() {
159159
let HeaderEntryFormStyle = { //trying to change style to conditional created strange duplication effect when continuously changing protocol
160-
display: this.props.newRequestFields.protocol !== 'ws://' ? 'block' : 'none',
160+
display: !/wss?:\/\//.test(this.props.newRequestFields.protocol) ? 'block' : 'none',
161161
}
162162
let SubmitButtonClassName = "composer_submit";
163-
if (this.props.newRequestFields.protocol === "ws://") { SubmitButtonClassName += " ws" }
163+
if (/wss?:\/\//.test(this.props.newRequestFields.protocol)) { SubmitButtonClassName += " ws" }
164164
else if (this.props.newRequestFields.graphQL) { SubmitButtonClassName += " gql" }
165165
else { SubmitButtonClassName += " http" }
166166

@@ -190,15 +190,18 @@ class ComposerNewRequest extends Component {
190190
/>
191191

192192
{
193-
this.props.newRequestFields.method && this.props.newRequestFields.protocol !== 'ws://' &&
193+
this.props.newRequestFields.method && !/wss?:\/\//.test(this.props.newRequestFields.protocol) &&
194194
<CookieEntryForm
195195
newRequestCookies={this.props.newRequestCookies}
196196
newRequestBody={this.props.newRequestBody}
197197
setNewRequestCookies={this.props.setNewRequestCookies}
198198
/>
199199
}
200200
{
201-
!this.props.newRequestFields.graphQL && this.props.newRequestFields.method !== 'GET' && this.props.newRequestFields.protocol !== 'ws://' &&
201+
!this.props.newRequestFields.graphQL
202+
&& this.props.newRequestFields.method !== 'GET'
203+
&& !/wss?:\/\//.test(this.props.newRequestFields.protocol)
204+
&&
202205
<BodyEntryForm
203206
newRequestHeaders={this.props.newRequestHeaders}
204207
newRequestBody={this.props.newRequestBody}

src/client/components/composer/NewRequest/FieldEntryForm.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ class FieldEntryForm extends Component {
2424
let grabbedProtocol, afterProtocol;
2525
if (!!this.props.newRequestFields.url) {
2626
grabbedProtocol = this.props.newRequestFields.url.match(/(https?:\/\/)|(wss?:\/\/)/) !== null
27-
? this.props.newRequestFields.url.match(/(https?:\/\/)|(wss?:\/\/)/)[0]
28-
: ""
27+
? this.props.newRequestFields.url.match(/(https?:\/\/)|(wss?:\/\/)/)[0]
28+
: ""
2929
afterProtocol = this.props.newRequestFields.url.substring(grabbedProtocol.length, this.props.newRequestFields.url.length)
3030
}
3131
else afterProtocol = ''
@@ -151,7 +151,7 @@ class FieldEntryForm extends Component {
151151

152152
{/* below conditional method selection rendering for http/s */}
153153
{
154-
this.props.newRequestFields.protocol !== 'ws://' && !this.props.newRequestFields.graphQL &&
154+
!/wss?:\/\//.test(this.props.newRequestFields.protocol) && !this.props.newRequestFields.graphQL &&
155155

156156
<select style={{ display: 'block' }} value={this.props.newRequestFields.method} className={'composer_method_select http'} onChange={(e) => {
157157
this.onChangeHandler(e, 'method')
@@ -165,7 +165,7 @@ class FieldEntryForm extends Component {
165165
}
166166
{/* below conditional method selection rendering for graphql */}
167167
{
168-
this.props.newRequestFields.protocol !== 'ws://' && this.props.newRequestFields.graphQL &&
168+
!/wss?:\/\//.test(this.props.newRequestFields.protocol) && this.props.newRequestFields.graphQL &&
169169

170170
<select style={{ display: 'block' }} value={this.props.newRequestFields.method} className={'composer_method_select gql'} onChange={(e) => {
171171
this.onChangeHandler(e, 'method')

src/client/components/composer/NewRequest/ProtocolSelect.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class ProtocolSelect extends Component {
1717
const WSStyleClasses = classNames({
1818
composer_protocol_button: true,
1919
ws: true,
20-
'composer_protocol_button-selected_ws': this.props.currentProtocol === 'ws://',
20+
'composer_protocol_button-selected_ws': /wss?:\/\//.test(this.props.currentProtocol),
2121
});
2222
const GQLStyleClasses = classNames({
2323
composer_protocol_button: true,

src/client/components/containers/SingleReqResContainer.jsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class SingleReqResContainer extends Component {
3535
render() {
3636
const contentBody = [];
3737

38-
if (this.props.content.protocol === 'ws://') {
38+
if (/wss?:\/\//.test(this.props.content.protocol)) {
3939
contentBody.push(<WebSocketWindow
4040
key={0}
4141
outgoingMessages={this.props.content.request.messages}
@@ -138,7 +138,9 @@ class SingleReqResContainer extends Component {
138138

139139
<span className="tertiary-title">{this.props.content.connectionType}</span>
140140

141-
{this.props.content.request.method === "SUBSCRIPTION" || this.props.content.protocol === "ws://" || this.props.content.connectionType === "SSE" ? <></> :
141+
{this.props.content.request.method === "SUBSCRIPTION"
142+
|| /wss?:\/\//.test(this.props.content.protocol)
143+
|| this.props.content.connectionType === "SSE" ? <></> :
142144
<span className="tertiary-title roundtrip" title="The amount of time it takes to recieve response">
143145
Roundtrip: {(this.props.content.connection === "open" || this.props.content.connection === 'pending' || this.props.content.timeReceived === null) ? 0 : this.props.content.timeReceived - this.props.content.timeSent} ms
144146
</span>

src/client/components/display/RequestTabs.jsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class RequestTabs extends Component {
6363

6464
else if (this.state.openTab === "Request Headers") {
6565
tabContentShown = [];
66-
if (this.props.requestContent.headers.length > 0) {
66+
if (this.props.requestContent.headers && this.props.requestContent.headers.length > 0) {
6767
this.props.requestContent.headers.forEach((cur, idx) => {
6868
tabContentShown.push(
6969
<div className={"grid-2"} key={idx}>
@@ -80,7 +80,7 @@ class RequestTabs extends Component {
8080

8181
else if (this.state.openTab === "Request Cookies") {
8282
tabContentShown = [];
83-
if (this.props.requestContent.cookies.length > 0) {
83+
if (this.props.requestContent.cookies && this.props.requestContent.cookies.length > 0) {
8484
this.props.requestContent.cookies.forEach((cur, idx) => {
8585
tabContentShown.push(
8686
<div className={"grid-2"} key={idx}>
@@ -98,9 +98,9 @@ class RequestTabs extends Component {
9898
return (
9999
<div className={"request_tabs_container"}>
100100
<ul className={"tab_list"}>
101-
<Tab onTabSelected={this.handleTabSelect} tabName={headers} openTab={this.state.openTab}/>
102-
<Tab onTabSelected={this.handleTabSelect} tabName={cookies} openTab={this.state.openTab}/>
103-
<Tab onTabSelected={this.handleTabSelect} tabName={body} openTab={this.state.openTab}/>
101+
<Tab onTabSelected={this.handleTabSelect} tabName={headers} openTab={this.state.openTab} />
102+
<Tab onTabSelected={this.handleTabSelect} tabName={cookies} openTab={this.state.openTab} />
103+
<Tab onTabSelected={this.handleTabSelect} tabName={body} openTab={this.state.openTab} />
104104
{
105105
this.props.requestContent.bodyType === "GQL" &&
106106
<Tab onTabSelected={this.handleTabSelect} tabName={variables} openTab={this.state.openTab} />

src/client/components/display/ResponseSubscriptionDisplay.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { WebSocketLink } from 'apollo-link-ws';
99

1010
const ResponseSubscriptionDisplay = ({ content, reqResUpdate }) => {
1111
const { body, bodyVariables } = content.request;
12-
const uri = content.protocol === /wss?:\/\// ? content.url : content.url.replace(content.protocol, 'ws://');
12+
const uri = /wss?:\/\//.test(content.protocol) ? content.url : content.url.replace(content.protocol, 'ws://');
1313

1414
const link = new WebSocketLink({
1515
uri,

src/client/controllers/reqResController.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const connectionController = {
4848

4949
if (reqResObj.request.method === 'SUBSCRIPTION') graphQLController.openSubscription(reqResObj);
5050
else if (reqResObj.graphQL) graphQLController.openGraphQLConnection(reqResObj);
51-
else if (reqResObj.protocol === 'ws://') wsController.openWSconnection(reqResObj, this.openConnectionArray);
51+
else if (/wss?:\/\//.test(reqResObj.protocol)) wsController.openWSconnection(reqResObj, this.openConnectionArray);
5252
else httpController.openHTTPconnection(reqResObj, this.openConnectionArray);
5353
},
5454

0 commit comments

Comments
 (0)