Skip to content

Commit 585940e

Browse files
only populate content type header on PUT POST PATCH DELETE
1 parent c8ff58e commit 585940e

File tree

1 file changed

+17
-2
lines changed

1 file changed

+17
-2
lines changed

src/client/components/composer/NewRequest/HeaderEntryForm.jsx

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,16 @@ class HeaderEntryForm extends Component {
2929
this.checkContentTypeHeaderUpdate();
3030
}
3131

32+
contentHeaderNeeded() {
33+
const { method } = this.props.newRequestFields;
34+
return (
35+
method === "PUT" ||
36+
method === "PATCH" ||
37+
method === "DELETE" ||
38+
method === "POST"
39+
);
40+
}
41+
3242
checkContentTypeHeaderUpdate() {
3343
let contentType;
3444

@@ -54,7 +64,7 @@ class HeaderEntryForm extends Component {
5464
);
5565

5666
// 1. if there is no contentTypeHeader, but there should be
57-
if (!foundHeader && contentType !== "") {
67+
if (!foundHeader && contentType !== "" && this.contentHeaderNeeded()) {
5868
this.addContentTypeHeader(contentType);
5969
// this.updateContentTypeHeader(contentType, foundHeader);
6070
}
@@ -63,12 +73,17 @@ class HeaderEntryForm extends Component {
6373
//keeping this else if lets the user do what they want, it's fine, updateContentTypeHeader and removeContentTypeHeader will fix it later
6474
}
6575
// 3. if there is a contentTypeHeader, needs to update
66-
else if (foundHeader && foundHeader.value !== contentType) {
76+
else if (
77+
foundHeader &&
78+
foundHeader.value !== contentType &&
79+
this.contentHeaderNeeded()
80+
) {
6781
this.updateContentTypeHeader(contentType, foundHeader);
6882
}
6983
}
7084

7185
addContentTypeHeader(contentType) {
86+
if (!this.contentHeaderNeeded()) return;
7287
const headersDeepCopy = JSON.parse(
7388
JSON.stringify(
7489
this.props.newRequestHeaders.headersArr.filter(

0 commit comments

Comments
 (0)