Commit f695654
authored
Add frameworks apis to scheme (#1470)
* Add frameworks apis to scheme
I recently ran `make vendor` on gatekeeper master and noticed that a
number of files from frameworks/constraint were being deleted. Why?
It runs out that a recent PR (#1445) removed a dependency on
frameworks/constraint/pkg/apis and `make vendor` was pruning the unused
code from the vendor/ directory.
As the API types declared in frameworks/constraint are part of the API
used in g8r, I thought it appropriate to add them to the scheme. This
fixes the problem with make vendor.
Signed-off-by: juliankatz <[email protected]>
* Add frameworks apis to scheme
I recently ran `make vendor` on gatekeeper master and noticed that a
number of files from frameworks/constraint were being deleted. Why?
It runs out that a recent PR (#1445) removed a dependency on
frameworks/constraint/pkg/apis and `make vendor` was pruning the unused
code from the vendor/ directory.
Further, while we might expect the AddToScheme calls to be used when we
setup the scheme in main.go, it turns out that we were making
essentially duplicate versions of the AddToScheme files in g8r. I've
replaced these with a single file that calls all the AddToScheme
functions in frameworks/constraint.
Signed-off-by: juliankatz <[email protected]>1 parent 07e2fd0 commit f695654
File tree
3 files changed
+2
-28
lines changed- apis
3 files changed
+2
-28
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
308 | 308 | | |
309 | 309 | | |
310 | 310 | | |
311 | | - | |
312 | 311 | | |
313 | 312 | | |
314 | 313 | | |
| |||
0 commit comments