Skip to content

Commit 3902162

Browse files
committed
resolve comments
Signed-off-by: Jian Qiu <[email protected]>
1 parent b4b4738 commit 3902162

File tree

1 file changed

+16
-9
lines changed

1 file changed

+16
-9
lines changed

content/en/docs/concepts/work-distribution/manifestwork.md

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -222,12 +222,13 @@ spec:
222222
namespace: default
223223
name: pi-calculation
224224
conditionRules:
225-
- type: WellKnownCompletions
225+
- type: WellKnownConditions
226+
condition: Complete
226227
```
227228

228229
### Well-Known Completions
229230

230-
For common Kubernetes resources, you can use the `WellKnownCompletions` type which provides
231+
For common Kubernetes resources, you can use the `WellKnownConditions` type which provides
231232
built-in completion logic:
232233

233234
**Job Completion**: A Job is considered complete when it has a condition of type `Complete` or `Failed`
@@ -243,7 +244,8 @@ manifestConfigs:
243244
namespace: default
244245
name: my-job
245246
conditionRules:
246-
- type: WellKnownCompletions
247+
- type: WellKnownConditions
248+
condition: Complete
247249
```
248250

249251
### Custom CEL Expressions
@@ -301,7 +303,8 @@ spec:
301303
namespace: default
302304
name: my-job
303305
conditionRules:
304-
- type: WellKnownCompletions
306+
- type: WellKnownConditions
307+
condition: Complete
305308
```
306309

307310
**Important Notes:**
@@ -325,16 +328,16 @@ Completion status is reflected in both manifest-level and `ManifestWork`-level c
325328
status:
326329
conditions:
327330
- lastTransitionTime: "2025-02-20T18:53:40Z"
328-
message: "All manifests with completion rules are complete"
329-
reason: "ConditionRulesPassed"
331+
message: "Job is finished"
332+
reason: "ConditionRulesAggregated"
330333
status: "True"
331334
type: Complete
332335
resourceStatus:
333336
manifests:
334337
- conditions:
335338
- lastTransitionTime: "2025-02-20T19:12:22Z"
336339
message: "Job is finished"
337-
reason: "ConditionRulesPassed"
340+
reason: "ConditionRuleEvaluated"
338341
status: "True"
339342
type: Complete
340343
resourceMeta:
@@ -347,6 +350,8 @@ status:
347350
version: v1
348351
```
349352

353+
All conditions with the same type from manifest-level are aggregated to `ManifestWork`-level status.conditions.
354+
350355
### Multiple Condition Types
351356

352357
You can define multiple condition rules for different condition types on the same manifest:
@@ -412,7 +417,8 @@ spec:
412417
namespace: default
413418
name: data-migration
414419
conditionRules:
415-
- type: WellKnownCompletions
420+
- type: WellKnownConditions
421+
condition: Complete
416422
```
417423

418424
**Run a Job and clean up after 30 seconds:**
@@ -448,7 +454,8 @@ spec:
448454
namespace: default
449455
name: temp-task
450456
conditionRules:
451-
- type: WellKnownCompletions
457+
- type: WellKnownConditions
458+
condition: Complete
452459
```
453460

454461
## Garbage collection

0 commit comments

Comments
 (0)