rename placement decision tracker get function (#278)

Signed-off-by: haoqing0110 <[email protected]>

Author: haoqing0110

cluster/v1beta1/helpers.go

@@ -59,13 +59,13 @@ func NewPlacementDecisionClustersTrackerWithGroups(placement *Placement, pdl Pla
 	return pdct
 }
 
-// Get updates the tracker's decisionClusters and returns added and deleted cluster names.
-func (pdct *PlacementDecisionClustersTracker) Get() (sets.Set[string], sets.Set[string], error) {
+// Refresh refreshes the tracker's decisionClusters.
+func (pdct *PlacementDecisionClustersTracker) Refresh() error {
 	pdct.lock.Lock()
 	defer pdct.lock.Unlock()
 
 	if pdct.placement == nil || pdct.placementDecisionGetter == nil {
-		return nil, nil, nil
+		return nil
 	}
 
 	// Get the generated PlacementDecisions
@@ -74,37 +74,49 @@ func (pdct *PlacementDecisionClustersTracker) Get() (sets.Set[string], sets.Set[
 	})
 	decisions, err := pdct.placementDecisionGetter.List(decisionSelector, pdct.placement.Namespace)
 	if err != nil {
-		return nil, nil, fmt.Errorf("failed to list PlacementDecisions: %w", err)
+		return fmt.Errorf("failed to list PlacementDecisions: %w", err)
 	}
 
 	// Get the decision cluster names and groups
-	newScheduledClusters := sets.New[string]()
 	newScheduledClusterGroups := map[GroupKey]sets.Set[string]{}
 	for _, d := range decisions {
 		groupKey, err := parseGroupKeyFromDecision(d)
 		if err != nil {
-			return nil, nil, err
+			return err
 		}
 
 		if _, exist := newScheduledClusterGroups[groupKey]; !exist {
 			newScheduledClusterGroups[groupKey] = sets.New[string]()
 		}
 
 		for _, sd := range d.Status.Decisions {
-			newScheduledClusters.Insert(sd.ClusterName)
 			newScheduledClusterGroups[groupKey].Insert(sd.ClusterName)
 		}
 	}
 
-	// Compare the difference
-	existingScheduledClusters := pdct.existingScheduledClusterGroups.GetClusters()
-	added := newScheduledClusters.Difference(existingScheduledClusters)
-	deleted := existingScheduledClusters.Difference(newScheduledClusters)
-
 	// Update the existing decision cluster groups
 	pdct.existingScheduledClusterGroups = newScheduledClusterGroups
 	pdct.generateGroupsNameIndex()
 
+	return nil
+}
+
+// GetClusterChanges updates the tracker's decisionClusters and returns added and deleted cluster names.
+func (pdct *PlacementDecisionClustersTracker) GetClusterChanges() (sets.Set[string], sets.Set[string], error) {
+	// Get existing clusters
+	existingScheduledClusters := pdct.existingScheduledClusterGroups.GetClusters()
+
+	// Refresh clusters
+	err := pdct.Refresh()
+	if err != nil {
+		return nil, nil, err
+	}
+	newScheduledClusters := pdct.existingScheduledClusterGroups.GetClusters()
+
+	// Compare the difference
+	added := newScheduledClusters.Difference(existingScheduledClusters)
+	deleted := existingScheduledClusters.Difference(newScheduledClusters)
+
 	return added, deleted, nil
 }
 

cluster/v1beta1/helpers_test.go

@@ -43,7 +43,7 @@ func newFakePlacementDecision(placementName, groupName string, groupIndex int, c
 	}
 }
 
-func TestPlacementDecisionClustersTracker_Get(t *testing.T) {
+func TestPlacementDecisionClustersTracker_GetClusterChanges(t *testing.T) {
 	tests := []struct {
 		name                           string
 		placement                      Placement
@@ -81,6 +81,19 @@ func TestPlacementDecisionClustersTracker_Get(t *testing.T) {
 			expectAddedScheduledClusters:   sets.New[string]("cluster1", "cluster2"),
 			expectDeletedScheduledClusters: sets.New[string](),
 		},
+		{
+			name: "test nil exist cluster groups",
+			placement: Placement{
+				ObjectMeta: metav1.ObjectMeta{Name: "placement2", Namespace: "default"},
+				Spec:       PlacementSpec{},
+			},
+			existingScheduledClusterGroups: nil,
+			updateDecisions: []*PlacementDecision{
+				newFakePlacementDecision("placement2", "", 0, "cluster1", "cluster2"),
+			},
+			expectAddedScheduledClusters:   sets.New[string]("cluster1", "cluster2"),
+			expectDeletedScheduledClusters: sets.New[string](),
+		},
 	}
 
 	for _, test := range tests {
@@ -92,7 +105,7 @@ func TestPlacementDecisionClustersTracker_Get(t *testing.T) {
 		tracker := NewPlacementDecisionClustersTrackerWithGroups(&test.placement, &fakeGetter, test.existingScheduledClusterGroups)
 
 		// check changed decision clusters
-		addedClusters, deletedClusters, err := tracker.Get()
+		addedClusters, deletedClusters, err := tracker.GetClusterChanges()
 		if err != nil {
 			t.Errorf("Case: %v, Failed to run Get(): %v", test.name, err)
 		}
@@ -173,9 +186,9 @@ func TestPlacementDecisionClustersTracker_Existing(t *testing.T) {
 		}
 		// init tracker
 		tracker := NewPlacementDecisionClustersTrackerWithGroups(&test.placement, &fakeGetter, nil)
-		_, _, err := tracker.Get()
+		err := tracker.Refresh()
 		if err != nil {
-			t.Errorf("Case: %v, Failed to run Get(): %v", test.name, err)
+			t.Errorf("Case: %v, Failed to run Refresh(): %v", test.name, err)
 		}
 
 		// Call the Existing method with different groupKeys inputs.
@@ -295,9 +308,9 @@ func TestPlacementDecisionClustersTracker_ExistingClusterGroups(t *testing.T) {
 		}
 		// init tracker
 		tracker := NewPlacementDecisionClustersTracker(&test.placement, &fakeGetter, nil)
-		_, _, err := tracker.Get()
+		err := tracker.Refresh()
 		if err != nil {
-			t.Errorf("Case: %v, Failed to run Get(): %v", test.name, err)
+			t.Errorf("Case: %v, Failed to run Refresh(): %v", test.name, err)
 		}
 
 		// Call the Existing method with different groupKeys inputs.