Skip to content

Commit 480f8ab

Browse files
authored
Fix grammer, spell, and punctuation issues in api description. (#318)
Signed-off-by: GitHub <[email protected]>
1 parent abaf09c commit 480f8ab

18 files changed

+96
-95
lines changed

addon/v1alpha1/0000_00_addon.open-cluster-management.io_clustermanagementaddons.crd.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,9 @@ spec:
2626
schema:
2727
openAPIV3Schema:
2828
description: ClusterManagementAddOn represents the registration of an add-on
29-
to the cluster manager. This resource allows the user to discover which
30-
add-on is available for the cluster manager and also provides metadata information
31-
about the add-on. This resource also provides a linkage to ManagedClusterAddOn,
32-
the name of the ClusterManagementAddOn resource will be used for the namespace-scoped
29+
to the cluster manager. This resource allows you to discover which add-ons
30+
are available for the cluster manager and provides metadata information
31+
about the add-ons. The ClusterManagementAddOn name is used for the namespace-scoped
3332
ManagedClusterAddOn resource. ClusterManagementAddOn is a cluster-scoped
3433
resource.
3534
properties:

addon/v1alpha1/0000_02_addon.open-cluster-management.io_addondeploymentconfigs.crd.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@ spec:
1515
- name: v1alpha1
1616
schema:
1717
openAPIV3Schema:
18-
description: AddOnDeploymentConfig represents a deployment configuration for
19-
an add-on.
18+
description: AddOnDeploymentConfig represents a configuration to customize
19+
the deployments of an add-on. For example, you can specify the NodePlacement
20+
to control the scheduling of the add-on agents.
2021
properties:
2122
apiVersion:
2223
description: 'APIVersion defines the versioned schema of this representation

addon/v1alpha1/types_addondeploymentconfig.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ import (
88
// +genclient
99
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
1010

11-
// AddOnDeploymentConfig represents a deployment configuration for an add-on.
11+
// AddOnDeploymentConfig represents a configuration to customize the deployments of an add-on.
12+
// For example, you can specify the NodePlacement to control the scheduling of the add-on agents.
1213
type AddOnDeploymentConfig struct {
1314
metav1.TypeMeta `json:",inline"`
1415
metav1.ObjectMeta `json:"metadata,omitempty"`

addon/v1alpha1/types_clustermanagementaddon.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,9 @@ import (
1414
// +kubebuilder:printcolumn:name="CRD NAME",type=string,JSONPath=`.spec.addOnConfiguration.crdName`
1515

1616
// ClusterManagementAddOn represents the registration of an add-on to the cluster manager.
17-
// This resource allows the user to discover which add-on is available for the cluster manager and
18-
// also provides metadata information about the add-on.
19-
// This resource also provides a linkage to ManagedClusterAddOn, the name of the ClusterManagementAddOn
20-
// resource will be used for the namespace-scoped ManagedClusterAddOn resource.
17+
// This resource allows you to discover which add-ons are available for the cluster manager
18+
// and provides metadata information about the add-ons. The ClusterManagementAddOn name is used
19+
// for the namespace-scoped ManagedClusterAddOn resource.
2120
// ClusterManagementAddOn is a cluster-scoped resource.
2221
type ClusterManagementAddOn struct {
2322
metav1.TypeMeta `json:",inline"`

addon/v1alpha1/zz_generated.swagger_doc_generated.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cluster/v1/0000_00_clusters.open-cluster-management.io_managedclusters.crd.yaml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,18 @@ spec:
3535
schema:
3636
openAPIV3Schema:
3737
description: "ManagedCluster represents the desired state and current status
38-
of managed cluster. ManagedCluster is a cluster scoped resource. The name
39-
is the cluster UID. \n The cluster join process follows a double opt-in
40-
process: \n 1. Agent on managed cluster creates CSR on hub with cluster
41-
UID and agent name. 2. Agent on managed cluster creates ManagedCluster on
42-
hub. 3. Cluster admin on hub approves the CSR for UID and agent name of
43-
the ManagedCluster. 4. Cluster admin sets spec.acceptClient of ManagedCluster
44-
to true. 5. Cluster admin on managed cluster creates credential of kubeconfig
45-
to hub. \n Once the hub creates the cluster namespace, the Klusterlet agent
46-
on the ManagedCluster pushes the credential to the hub to use against the
47-
kube-apiserver of the ManagedCluster."
38+
of a managed cluster. ManagedCluster is a cluster-scoped resource. The name
39+
is the cluster UID. \n The cluster join process is a double opt-in process.
40+
See the following join process steps: \n 1. The agent on the managed cluster
41+
creates a CSR on the hub with the cluster UID and agent name. 2. The agent
42+
on the managed cluster creates a ManagedCluster on the hub. 3. The cluster
43+
admin on the hub cluster approves the CSR for the UID and agent name of
44+
the ManagedCluster. 4. The cluster admin sets the spec.acceptClient of the
45+
ManagedCluster to true. 5. The cluster admin on the managed cluster creates
46+
a credential of the kubeconfig for the hub cluster. \n After the hub cluster
47+
creates the cluster namespace, the klusterlet agent on the ManagedCluster
48+
pushes the credential to the hub cluster to use against the kube-apiserver
49+
of the ManagedCluster."
4850
properties:
4951
apiVersion:
5052
description: 'APIVersion defines the versioned schema of this representation

cluster/v1/types.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,20 @@ import (
1616
// +kubebuilder:printcolumn:JSONPath=`.status.conditions[?(@.type=="ManagedClusterConditionAvailable")].status`,name="Available",type=string
1717
// +kubebuilder:printcolumn:JSONPath=`.metadata.creationTimestamp`,name="Age",type=date
1818

19-
// ManagedCluster represents the desired state and current status of managed
20-
// cluster. ManagedCluster is a cluster scoped resource. The name is the cluster
21-
// UID.
19+
// ManagedCluster represents the desired state and current status
20+
// of a managed cluster. ManagedCluster is a cluster-scoped resource. The name
21+
// is the cluster UID.
2222
//
23-
// The cluster join process follows a double opt-in process:
23+
// The cluster join process is a double opt-in process. See the following join process steps:
2424
//
25-
// 1. Agent on managed cluster creates CSR on hub with cluster UID and agent name.
26-
// 2. Agent on managed cluster creates ManagedCluster on hub.
27-
// 3. Cluster admin on hub approves the CSR for UID and agent name of the ManagedCluster.
28-
// 4. Cluster admin sets spec.acceptClient of ManagedCluster to true.
29-
// 5. Cluster admin on managed cluster creates credential of kubeconfig to hub.
25+
// 1. The agent on the managed cluster creates a CSR on the hub with the cluster UID and agent name.
26+
// 2. The agent on the managed cluster creates a ManagedCluster on the hub.
27+
// 3. The cluster admin on the hub cluster approves the CSR for the UID and agent name of the ManagedCluster.
28+
// 4. The cluster admin sets the spec.acceptClient of the ManagedCluster to true.
29+
// 5. The cluster admin on the managed cluster creates a credential of the kubeconfig for the hub cluster.
3030
//
31-
// Once the hub creates the cluster namespace, the Klusterlet agent on the ManagedCluster
32-
// pushes the credential to the hub to use against the kube-apiserver of the ManagedCluster.
31+
// After the hub cluster creates the cluster namespace, the klusterlet agent on the ManagedCluster pushes
32+
// the credential to the hub cluster to use against the kube-apiserver of the ManagedCluster.
3333
type ManagedCluster struct {
3434
metav1.TypeMeta `json:",inline"`
3535
metav1.ObjectMeta `json:"metadata,omitempty"`

cluster/v1/zz_generated.swagger_doc_generated.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cluster/v1beta1/0000_02_clusters.open-cluster-management.io_placements.crd.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ spec:
3434
to workload namespaces; 4. Namespace-scoped Placements specify a slice of
3535
ManagedClusterSets which select a working set of potential ManagedClusters;
3636
5. Then Placements subselect from that working set using label/claim selection.
37-
\n No ManagedCluster will be selected if no ManagedClusterSet is bound to
38-
the placement namespace. User is able to bind a ManagedClusterSet to a namespace
39-
by creating a ManagedClusterSetBinding in that namespace if they have a
40-
RBAC rule to CREATE on the virtual subresource of `managedclustersets/bind`.
41-
\n A slice of PlacementDecisions with label cluster.open-cluster-management.io/placement={placement
37+
\n A ManagedCluster will not be selected if no ManagedClusterSet is bound
38+
to the placement namespace. A user is able to bind a ManagedClusterSet to
39+
a namespace by creating a ManagedClusterSetBinding in that namespace if
40+
they have an RBAC rule to CREATE on the virtual subresource of `managedclustersets/bind`.
41+
\n A slice of PlacementDecisions with the label cluster.open-cluster-management.io/placement={placement
4242
name} will be created to represent the ManagedClusters selected by this
4343
placement. \n If a ManagedCluster is selected and added into the PlacementDecisions,
4444
other components may apply workload on it; once it is removed from the PlacementDecisions,

cluster/v1beta1/0000_03_clusters.open-cluster-management.io_placementdecisions.crd.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@ spec:
1515
- name: v1beta1
1616
schema:
1717
openAPIV3Schema:
18-
description: "PlacementDecision indicates a decision from a placement PlacementDecision
19-
should has a label cluster.open-cluster-management.io/placement={placement
20-
name} to reference a certain placement. \n If a placement has spec.numberOfClusters
21-
specified, the total number of decisions contained in status.decisions of
22-
PlacementDecisions should always be NumberOfClusters; otherwise, the total
23-
number of decisions should be the number of ManagedClusters which match
24-
the placement requirements. \n Some of the decisions might be empty when
25-
there are no enough ManagedClusters meet the placement requirements."
18+
description: "PlacementDecision indicates a decision from a placement. PlacementDecision
19+
must have a cluster.open-cluster-management.io/placement={placement name}
20+
label to reference a certain placement. \n If a placement has spec.numberOfClusters
21+
specified, the total number of decisions contained in the status.decisions
22+
of PlacementDecisions must be the same as NumberOfClusters. Otherwise, the
23+
total number of decisions must equal the number of ManagedClusters that
24+
match the placement requirements. \n Some of the decisions might be empty
25+
when there are not enough ManagedClusters to meet the placement requirements."
2626
properties:
2727
apiVersion:
2828
description: 'APIVersion defines the versioned schema of this representation

cluster/v1beta1/types_placement.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@ import (
2626
// of potential ManagedClusters;
2727
// 5. Then Placements subselect from that working set using label/claim selection.
2828
//
29-
// No ManagedCluster will be selected if no ManagedClusterSet is bound to the placement
30-
// namespace. User is able to bind a ManagedClusterSet to a namespace by creating a
31-
// ManagedClusterSetBinding in that namespace if they have a RBAC rule to CREATE on the virtual
29+
// A ManagedCluster will not be selected if no ManagedClusterSet is bound to the placement
30+
// namespace. A user is able to bind a ManagedClusterSet to a namespace by creating a
31+
// ManagedClusterSetBinding in that namespace if they have an RBAC rule to CREATE on the virtual
3232
// subresource of `managedclustersets/bind`.
3333
//
34-
// A slice of PlacementDecisions with label cluster.open-cluster-management.io/placement={placement name}
34+
// A slice of PlacementDecisions with the label cluster.open-cluster-management.io/placement={placement name}
3535
// will be created to represent the ManagedClusters selected by this placement.
3636
//
3737
// If a ManagedCluster is selected and added into the PlacementDecisions, other components may

cluster/v1beta1/types_placementdecision.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,15 @@ import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
77
// +kubebuilder:resource:scope="Namespaced"
88
// +kubebuilder:subresource:status
99

10-
// PlacementDecision indicates a decision from a placement
11-
// PlacementDecision should has a label cluster.open-cluster-management.io/placement={placement name}
12-
// to reference a certain placement.
10+
// PlacementDecision indicates a decision from a placement.
11+
// PlacementDecision must have a cluster.open-cluster-management.io/placement={placement name} label to reference a certain placement.
1312
//
1413
// If a placement has spec.numberOfClusters specified, the total number of decisions contained in
15-
// status.decisions of PlacementDecisions should always be NumberOfClusters; otherwise, the total
16-
// number of decisions should be the number of ManagedClusters which match the placement requirements.
14+
// the status.decisions of PlacementDecisions must be the same as NumberOfClusters. Otherwise, the
15+
// total number of decisions must equal the number of ManagedClusters that
16+
// match the placement requirements.
1717
//
18-
// Some of the decisions might be empty when there are no enough ManagedClusters meet the placement
19-
// requirements.
18+
// Some of the decisions might be empty when there are not enough ManagedClusters to meet the placement requirements.
2019
type PlacementDecision struct {
2120
metav1.TypeMeta `json:",inline"`
2221
metav1.ObjectMeta `json:"metadata,omitempty"`

0 commit comments

Comments
 (0)