Skip to content

Commit cb2efea

Browse files
committed
Turn off UMF_DEVELOPER_MODE in CI Sanitizers jobs
The UMF_DEVELOPER_MODE option turns on various additional debug checks that should be turned off in all Valgrind and Sanitizers builds, because we do not want to look for races in additional debug checks. Signed-off-by: Lukasz Dorau <[email protected]>
1 parent f5841df commit cb2efea

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/reusable_sanitizers.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
-DUMF_BUILD_LEVEL_ZERO_PROVIDER=ON
5454
-DUMF_BUILD_CUDA_PROVIDER=ON
5555
-DUMF_FORMAT_CODE_STYLE=OFF
56-
-DUMF_DEVELOPER_MODE=ON
56+
-DUMF_DEVELOPER_MODE=OFF
5757
-DUMF_BUILD_LIBUMF_POOL_JEMALLOC=ON
5858
-DUMF_USE_ASAN=${{matrix.sanitizers.asan}}
5959
-DUMF_USE_UBSAN=${{matrix.sanitizers.ubsan}}
@@ -125,7 +125,7 @@ jobs:
125125
-DCMAKE_PREFIX_PATH="${{env.VCPKG_PATH}}"
126126
-DUMF_BUILD_SHARED_LIBRARY=OFF
127127
-DUMF_FORMAT_CODE_STYLE=OFF
128-
-DUMF_DEVELOPER_MODE=ON
128+
-DUMF_DEVELOPER_MODE=OFF
129129
-DUMF_USE_ASAN=${{matrix.sanitizers.asan}}
130130
-DUMF_BUILD_EXAMPLES=ON
131131
-DUMF_BUILD_LEVEL_ZERO_PROVIDER=OFF

.github/workflows/weekly.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454
-DUMF_BUILD_LEVEL_ZERO_PROVIDER=ON
5555
-DUMF_BUILD_CUDA_PROVIDER=ON
5656
-DUMF_FORMAT_CODE_STYLE=OFF
57-
-DUMF_DEVELOPER_MODE=ON
57+
-DUMF_DEVELOPER_MODE=OFF
5858
-DUMF_BUILD_LIBUMF_POOL_JEMALLOC=ON
5959
-DUMF_USE_ASAN=${{matrix.sanitizers.asan}}
6060
-DUMF_USE_UBSAN=${{matrix.sanitizers.ubsan}}

0 commit comments

Comments
 (0)