Enable running umfIpcTest tests when free() is not supported

Some memory providers (currently the devdax and the file providers)
do not support the free() operation (free() always returns
the UMF_RESULT_ERROR_NOT_SUPPORTED error).

Add the UMF_TEST_PROVIDER_FREE_NOT_SUPPORTED define
and the get_umf_result_of_free macro() to ipcFixtures.hpp
to enable running umfIpcTest tests when free() is not supported.

Signed-off-by: Lukasz Dorau <[email protected]>

Author: ldorau

test/ipcFixtures.hpp

@@ -20,6 +20,12 @@
 #include <numeric>
 #include <tuple>
 
+#ifdef UMF_TEST_PROVIDER_FREE_NOT_SUPPORTED
+#define get_umf_result_of_free(expected_result) UMF_RESULT_ERROR_NOT_SUPPORTED
+#else
+#define get_umf_result_of_free(expected_result) (expected_result)
+#endif
+
 class MemoryAccessor {
   public:
     virtual void fill(void *ptr, size_t size, const void *pattern,
@@ -172,7 +178,7 @@ TEST_P(umfIpcTest, GetIPCHandleInvalidArgs) {
     EXPECT_EQ(ret, UMF_RESULT_ERROR_INVALID_ARGUMENT);
 
     ret = umfFree(ptr);
-    EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
+    EXPECT_EQ(ret, get_umf_result_of_free(UMF_RESULT_SUCCESS));
 }
 
 TEST_P(umfIpcTest, BasicFlow) {
@@ -227,7 +233,19 @@ TEST_P(umfIpcTest, BasicFlow) {
     EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
 
     ret = umfPoolFree(pool.get(), ptr);
-    EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
+    EXPECT_EQ(ret, get_umf_result_of_free(UMF_RESULT_SUCCESS));
+
+    // Test if umfCloseIPCHandle() did not corrupt the pool
+    // and if umfPoolMalloc() works correctly after umfCloseIPCHandle().
+    ptr = (int *)umfPoolMalloc(pool.get(), SIZE);
+    EXPECT_NE(ptr, nullptr);
+
+    // use the allocated memory - fill it with a 0xAB pattern
+    const uint32_t pattern = 0xAB;
+    memAccessor->fill(ptr, SIZE, &pattern, sizeof(pattern));
+
+    ret = umfPoolFree(pool.get(), ptr);
+    EXPECT_EQ(ret, get_umf_result_of_free(UMF_RESULT_SUCCESS));
 
     pool.reset(nullptr);
     EXPECT_EQ(stat.getCount, 1);
@@ -291,7 +309,7 @@ TEST_P(umfIpcTest, GetPoolByOpenedHandle) {
 
     for (size_t i = 0; i < NUM_ALLOCS; ++i) {
         umf_result_t ret = umfFree(ptrs[i]);
-        EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
+        EXPECT_EQ(ret, get_umf_result_of_free(UMF_RESULT_SUCCESS));
     }
 }
 
@@ -317,7 +335,7 @@ TEST_P(umfIpcTest, AllocFreeAllocTest) {
     EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
 
     ret = umfPoolFree(pool.get(), ptr);
-    EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
+    EXPECT_EQ(ret, get_umf_result_of_free(UMF_RESULT_SUCCESS));
 
     ptr = umfPoolMalloc(pool.get(), SIZE);
     ASSERT_NE(ptr, nullptr);
@@ -339,7 +357,19 @@ TEST_P(umfIpcTest, AllocFreeAllocTest) {
     EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
 
     ret = umfPoolFree(pool.get(), ptr);
-    EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
+    EXPECT_EQ(ret, get_umf_result_of_free(UMF_RESULT_SUCCESS));
+
+    // Test if umfCloseIPCHandle() did not corrupt the pool
+    // and if umfPoolMalloc() works correctly after umfCloseIPCHandle().
+    ptr = umfPoolMalloc(pool.get(), SIZE);
+    EXPECT_NE(ptr, nullptr);
+
+    // use the allocated memory - fill it with a 0xAB pattern
+    const uint32_t pattern = 0xAB;
+    memAccessor->fill(ptr, SIZE, &pattern, sizeof(pattern));
+
+    ret = umfPoolFree(pool.get(), ptr);
+    EXPECT_EQ(ret, get_umf_result_of_free(UMF_RESULT_SUCCESS));
 
     pool.reset(nullptr);
     EXPECT_EQ(stat.allocCount, stat.getCount);
@@ -391,7 +421,7 @@ TEST_P(umfIpcTest, openInTwoPools) {
     EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
 
     ret = umfPoolFree(pool1.get(), ptr);
-    EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
+    EXPECT_EQ(ret, get_umf_result_of_free(UMF_RESULT_SUCCESS));
 
     pool1.reset(nullptr);
     pool2.reset(nullptr);
@@ -442,7 +472,7 @@ TEST_P(umfIpcTest, ConcurrentGetPutHandles) {
 
     for (void *ptr : ptrs) {
         umf_result_t ret = umfPoolFree(pool.get(), ptr);
-        EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
+        EXPECT_EQ(ret, get_umf_result_of_free(UMF_RESULT_SUCCESS));
     }
 
     pool.reset(nullptr);
@@ -504,7 +534,7 @@ TEST_P(umfIpcTest, ConcurrentOpenCloseHandles) {
 
     for (void *ptr : ptrs) {
         umf_result_t ret = umfPoolFree(pool.get(), ptr);
-        EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
+        EXPECT_EQ(ret, get_umf_result_of_free(UMF_RESULT_SUCCESS));
     }
 
     pool.reset(nullptr);