Skip to content

Commit 5a14584

Browse files
committed
chrome 120 run
1 parent 3064694 commit 5a14584

File tree

12 files changed

+3478
-3702
lines changed

12 files changed

+3478
-3702
lines changed

startLocalServerAndUpdateBuild.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
# private file to copy the zip file from my VPS
22
set -e
3+
git pull
34
echo "running zip on js-framework-benchmark"
45
ssh $VPS_HOST "cd js-framework-benchmark && npm run zip"
56
scp $VPS_HOST:/home/stefan/js-framework-benchmark/build.zip .
67
unzip -o build.zip
78
ssh $VPS_HOST "ls -l js-framework-benchmark/build.zip"
89
ls -l build.zip
9-
npm start
10+
npm start

webdriver-ts-results/src/App.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const App = () => {
4444

4545
const testEnvironmentInfo = (
4646
<p>
47-
The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 14.1), Chrome 119.0.6045.105 (arm64) using
47+
The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 14.1.2), Chrome 120.0.6099.62 (arm64) using
4848
the puppeteer benchmark driver with reduced tracing.
4949
</p>
5050
);

webdriver-ts-results/src/Common.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ export enum DisplayMode {
1313
export enum CpuDurationMode {
1414
Total = "total",
1515
Script = "script",
16-
Render = "paint",
17-
BrowserOnly = "browser only",
16+
Render = "paint"
1817
}
1918

2019
export enum FrameworkType {

webdriver-ts-results/src/components/ResultTable.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,6 @@ const ResultTable = ({ type }: Props) => {
5656
Report bugs in issue <a href="https://github.com/krausest/js-framework-benchmark/issues/1233">1233</a>.
5757
</h3>
5858
)}
59-
{cpuDurationMode === CpuDurationMode.BrowserOnly && (
60-
<h3>Warning: This is an experimental view that shows the difference between total duration and script duration. Don&apos;t rely on those values yet and don&apos;t report them until they are official.
61-
I guess this view mode just makes no sense.
62-
</h3>
63-
)}
6459
{cpuDurationMode === CpuDurationMode.Render && (
6560
<h3>Warning: This is an experimental view that shows the difference between total duration and script duration. Don&apos;t rely on those values yet and don&apos;t report them until they are official.
6661
Report bugs in issue <a href="https://github.com/krausest/js-framework-benchmark/issues/1233">1233</a>.

webdriver-ts-results/src/components/selection/ModeSelectionPanel/DurationModeSelector.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const DurationModeSelector = ({ cpuDurationMode, onChange }: Props) => {
1111
<>
1212
<div className="mode-selector">
1313
<label htmlFor="durationMode">
14-
(Experimental) Duration measurement mode:
14+
Duration measurement mode:
1515
</label>
1616
<select
1717
id="durationMode"
@@ -23,7 +23,6 @@ const DurationModeSelector = ({ cpuDurationMode, onChange }: Props) => {
2323
<option value={CpuDurationMode.Total}>total duration</option>
2424
<option value={CpuDurationMode.Script}>only JS duration</option>
2525
<option value={CpuDurationMode.Render}>only render duration</option>
26-
<option value={CpuDurationMode.BrowserOnly}>Browser only duration</option>
2726
</select>
2827
</div>
2928
</>

webdriver-ts-results/src/reducer.ts

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -38,31 +38,6 @@ const results: Result[] = rawResults.map((result) => {
3838
};
3939
values[key] = vals;
4040
}
41-
if (result.v[CpuDurationMode.Total] && result.v[CpuDurationMode.Script] && result.v[CpuDurationMode.Render]) {
42-
if (result.v[CpuDurationMode.Total].length !== result.v[CpuDurationMode.Script].length) {
43-
const vals = {
44-
mean: NaN,
45-
median: NaN,
46-
standardDeviation: NaN,
47-
values: [NaN],
48-
};
49-
debugger;
50-
values[CpuDurationMode.BrowserOnly] = vals;
51-
} else {
52-
let r = [];
53-
for (let i = 0; i < result.v[CpuDurationMode.Total].length; i++) {
54-
r.push(result.v[CpuDurationMode.Total][i] - result.v[CpuDurationMode.Script][i]);
55-
}
56-
const vals = {
57-
mean: jStat.mean(r),
58-
median: jStat.median(r),
59-
standardDeviation: jStat.stdev(r, true),
60-
values: r,
61-
};
62-
values[CpuDurationMode.BrowserOnly] = vals;
63-
}
64-
// if (result.f==='miso-v1.4.0-keyed' || result.f==='vanillajs-keyed') debugger;
65-
}
6641

6742
return { framework: result.f, benchmark: result.b, results: values };
6843
});

webdriver-ts-results/src/results.ts

Lines changed: 3459 additions & 3651 deletions
Large diffs are not rendered by default.

webdriver-ts/results.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

webdriver-ts/src/benchmarksCommon.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export interface SizeInfoJSON {
3131
size_uncompressed: number,
3232
size_compressed: number,
3333
fp: number,
34-
fcp: number,
3534
}
3635

3736
export interface SizeBenchmarkInfo extends BenchmarkInfoBase {

webdriver-ts/src/benchmarksSize.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,20 @@ export const benchFP: benchmarksCommon.SizeBenchmarkInfo = {
3535
fn: (sizeInfo) => Number(sizeInfo.fp.toFixed(1)),
3636
};
3737

38-
export const benchFCP: benchmarksCommon.SizeBenchmarkInfo = {
39-
id: "44_first-contentful-paint",
40-
label: "first contentful paint",
41-
description: () =>
42-
"first contentful paint",
43-
type: BenchmarkType.SIZE,
44-
fn: (sizeInfo) => Number(sizeInfo.fcp.toFixed(1)),
45-
};
38+
// export const benchFCP: benchmarksCommon.SizeBenchmarkInfo = {
39+
// id: "44_first-contentful-paint",
40+
// label: "first contentful paint",
41+
// description: () =>
42+
// "first contentful paint",
43+
// type: BenchmarkType.SIZE,
44+
// fn: (sizeInfo) => Number(sizeInfo.fcp.toFixed(1)),
45+
// };
4646

4747
export const subbenchmarks = [
4848
benchUncompressedSize,
4949
benchCompressedSize,
5050
benchFP,
51-
benchFCP,
51+
// benchFCP,
5252
];
5353

5454
export class BenchmarkSize implements BenchmarkImpl {

webdriver-ts/src/forkedBenchmarkRunnerSize.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ async function runSizeBenchmark(
7171
let sizeInfo = (await sizeInfoResponse.json()) as SizeInfoJSON;
7272
console.log("sizeInfo", sizeInfo);
7373
sizeInfo.fp = paintEvents.find((e: any) => e.name === "first-paint").startTime;
74-
sizeInfo.fcp = paintEvents.find((e: any) => e.name === "first-contentful-paint").startTime;
74+
// sizeInfo.fcp = paintEvents.find((e: any) => e.name === "first-contentful-paint").startTime;
7575

7676
results = benchmarks.subbenchmarks.map((b) => ({
7777
benchmark: b,

webdriver-ts/src/parseTrace.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ import { computeResultsCPU, computeResultsJS, computeResultsPaint, parseCPUTrace
55

66
async function debugSingle() {
77
let values: number[] = [];
8-
for (let i = 0; i < 15; i++) {
8+
// for (let i = 0; i < 15; i++) {
99
// const trace = `traces/anansi-v0.14.0-keyed_01_run1k_${i}.json`;
1010
// const trace = `traces/alpine-v3.12.0-keyed_07_create10k_${i}.json`;
1111
// const trace = `traces/alpine-v3.12.0-keyed_07_create10k_0.jsontraces/1more-v0.1.18-keyed_01_run1k_0.json`;
1212
// const trace = `traces/alpine-v3.12.0-keyed_07_create10k_0.json`;
1313
// const trace = `traces/arrowjs-v1.0.0-alpha.9-keyed_07_create10k_0.json`;
1414
// const trace = `traces/better-react-v1.1.3-keyed_04_select1k_1.json`;
15-
const trace = `traces/malina-v0.7.3-keyed_01_run1k_${i}.json`;
15+
const trace = `traces/openui5-v1.120.0-keyed_02_replace1k_0.json`;
1616
// const trace = `traces/vanillajs-keyed_01_run1k_0.json`;
1717
console.log("analyzing trace", trace);
1818
const cpuTrace = await computeResultsCPU(trace);
@@ -23,7 +23,7 @@ async function debugSingle() {
2323
let resultPaint = await computeResultsPaint(cpuTrace, config, trace);
2424
console.log("resultPaint", resultPaint);
2525
// console.log(trace, await computeResultsJS(cpuTrace, config, trace, DurationMeasurementMode.LAST_PAINT))
26-
}
26+
// }
2727
console.log(values);
2828
console.log(stats(values));
2929
}

0 commit comments

Comments
 (0)