Skip to content

Commit 44249b7

Browse files
authored
Merge branch 'master' into improve-cli
2 parents 69f52c2 + f3e11e2 commit 44249b7

File tree

122 files changed

+51106
-21913
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

122 files changed

+51106
-21913
lines changed

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,6 +520,10 @@ You can set an optional different URL if needed or specify that your DOM uses a
520520
521521
## 4.4 Submitting your implementation
522522
523+
Please take a look at https://github.com/krausest/js-framework-benchmark/wiki/Process-for-merging-a-pull-request for informations how pull requests are merged.
524+
525+
526+
523527
Contributions are very welcome. Please use the following rules:
524528
525529
- Name your directory frameworks/[keyed|non-keyed]/[FrameworkName]
@@ -531,7 +535,7 @@ Contributions are very welcome. Please use the following rules:
531535
- Webdriver-ts must be able to run the perf tests for the contribution. This means that all buttons (like "Create 1,000 rows") must have the correct id e.g. like in vanillajs. Using shadow DOM is a real pain for webdriver. The closer you can get to polymer the higher the chances I can make that contribution work.
532536
- Don't change the ids in the index.html, since the automated benchmarking relies on those ids.
533537
- Please push only files in your framework folder (not index.html or results.json)
534-
- **Please make sure your implementation is validated by the test tool.** cd to webdriver-ts and invoke it with `npm run isKeyed [keyed|non-keyed]/[FrameworkName]`. It'll print an error if your framework behaves other as specified. It'll print a big ERROR explaining if it isn't happy with the implementation. Some common errors include:
538+
- **Please make sure your implementation is validated by the test tool.** cd to the root directory and perform a check `npm run rebuild-ci [keyed|non-keyed]/[FrameworkName]`. It'll print an error if your framework doesn't build, the benchmark can't be run or behaves other as specified. It'll print a big ERROR explaining if it isn't happy with the implementation. Some common errors include:
535539
- Your package.json is missing some required fields
536540
- Incorrect classification (Keyed/NonKeyed)
537541
- You have gzipped files in /dist (unfortunately the web server prefers these when they exist)

cli/zip.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,15 @@ function addFrameworksToZip(frameworkType, frameworkDir, frameworkName) {
5656
if (frameworkName === "halogen") {
5757
addLocalFileIfExists(`${frameworkDir}/output/bundle.js`, `${zipFrameworkPath}/output`);
5858
} else if (frameworkName === "dojo") {
59-
addLocalFolderIfExists(`${frameworkDir}/output/dist`, `${zipFrameworkPath}/output/dist`);
59+
addLocalFolderIfExists(
60+
`${frameworkDir}/output/dist`,
61+
`${zipFrameworkPath}/output/dist`,
62+
);
63+
} else if (frameworkName === "s2") {
64+
addLocalFolderIfExists(
65+
`${frameworkDir}/node_modules/s2-engine/dist`,
66+
`${zipFrameworkPath}/node_modules/s2-engine/dist`,
67+
);
6068
} else if (frameworkName === "stem") {
6169
addLocalFolderIfExists(
6270
`${frameworkDir}/node_modules/babel-polyfill/dist`,

0 commit comments

Comments
 (0)