[FIX] spreadsheet: batch process spreadsheet_revision.commands

Some dbs have `spreadsheet_revision` records with over 10 millions characters
in `commands`. If the number of record is high, this leads to memory errors.
We use a named cursor so the fetching is done in postgres and data are
processed in smaller batches by the upgrade process.

Author: vval-odoo

src/util/spreadsheet/misc.py

@@ -1,32 +1,33 @@
-from .. import json
+from .. import json, pg
 
 
 def iter_commands(cr, like_all=(), like_any=()):
     if not (bool(like_all) ^ bool(like_any)):
         raise ValueError("Please specify `like_all` or `like_any`, not both")
-    cr.execute(
-        """
-        SELECT id,
-               commands
-          FROM spreadsheet_revision
-         WHERE commands LIKE {}(%s::text[])
-        """.format("ALL" if like_all else "ANY"),
-        [list(like_all or like_any)],
-    )
-    for revision_id, data in cr.fetchall():
-        data_loaded = json.loads(data)
-        if "commands" not in data_loaded:
-            continue
-        data_old = json.dumps(data_loaded, sort_keys=True)
+    with pg.named_cursor(cr, itersize=1) as ncr:
+        ncr.execute(
+            """
+            SELECT id,
+                commands
+            FROM spreadsheet_revision
+            WHERE commands LIKE {}(%s::text[])
+            """.format("ALL" if like_all else "ANY"),
+            [list(like_all or like_any)],
+        )
+        for revision_id, data in ncr:
+            data_loaded = json.loads(data)
+            if "commands" not in data_loaded:
+                continue
+            data_old = json.dumps(data_loaded, sort_keys=True)
 
-        changed = yield data_loaded["commands"]
-        if changed is None:
-            changed = data_old != json.dumps(data_loaded, sort_keys=True)
+            changed = yield data_loaded["commands"]
+            if changed is None:
+                changed = data_old != json.dumps(data_loaded, sort_keys=True)
 
-        if changed:
-            cr.execute(
-                "UPDATE spreadsheet_revision SET commands=%s WHERE id=%s", [json.dumps(data_loaded), revision_id]
-            )
+            if changed:
+                cr.execute(
+                    "UPDATE spreadsheet_revision SET commands=%s WHERE id=%s", [json.dumps(data_loaded), revision_id]
+                )
 
 
 def process_commands(cr, callback, *args, **kwargs):