From e85aa439d7b5a9d67e84d419259339c6eb0249c3 Mon Sep 17 00:00:00 2001 From: Jamie Tanna Date: Wed, 30 Apr 2025 17:11:16 +0100 Subject: [PATCH 1/4] build: build against Go 1.23 and 1.24 --- .github/workflows/ci.yml | 2 ++ .github/workflows/generate.yml | 2 ++ .github/workflows/lint.yml | 2 ++ .github/workflows/tidy.yml | 2 ++ 4 files changed, 8 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3467674..a3c5ece 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,6 +12,8 @@ jobs: - "1.20" - "1.21" - "1.22" + - "1.23" + - "1.24" steps: - name: Check out source code uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 diff --git a/.github/workflows/generate.yml b/.github/workflows/generate.yml index 1552de8..bc92045 100644 --- a/.github/workflows/generate.yml +++ b/.github/workflows/generate.yml @@ -12,6 +12,8 @@ jobs: - "1.20" - "1.21" - "1.22" + - "1.23" + - "1.24" steps: - name: Check out source code uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 33d68cf..54feae1 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -12,6 +12,8 @@ jobs: - "1.20" - "1.21" - "1.22" + - "1.23" + - "1.24" steps: - name: Check out source code uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 diff --git a/.github/workflows/tidy.yml b/.github/workflows/tidy.yml index fff71a2..5754e8c 100644 --- a/.github/workflows/tidy.yml +++ b/.github/workflows/tidy.yml @@ -12,6 +12,8 @@ jobs: - "1.20" - "1.21" - "1.22" + - "1.23" + - "1.24" steps: - name: Check out source code uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 From d2c62a9c73f38a386378ea52c92fbfc0d7029c07 Mon Sep 17 00:00:00 2001 From: Jamie Tanna Date: Wed, 30 Apr 2025 17:13:27 +0100 Subject: [PATCH 2/4] build: indicate which versions of Go are supported vs "supported" But we won't really indicate /what/ "supported" means at this time. --- .github/workflows/ci.yml | 2 ++ .github/workflows/generate.yml | 2 ++ .github/workflows/lint.yml | 2 ++ .github/workflows/tidy.yml | 2 ++ 4 files changed, 8 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a3c5ece..f14bf6c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,9 +9,11 @@ jobs: # perform matrix testing to give us an earlier insight into issues with different versions of supported major versions of Go matrix: version: + # versions of Go that this module can still be built with (and therefore are "supported" by this project) - "1.20" - "1.21" - "1.22" + # actively supported versions of Go - "1.23" - "1.24" steps: diff --git a/.github/workflows/generate.yml b/.github/workflows/generate.yml index bc92045..9ce1219 100644 --- a/.github/workflows/generate.yml +++ b/.github/workflows/generate.yml @@ -9,9 +9,11 @@ jobs: # perform matrix testing to give us an earlier insight into issues with different versions of supported major versions of Go matrix: version: + # versions of Go that this module can still be built with (and therefore are "supported" by this project) - "1.20" - "1.21" - "1.22" + # actively supported versions of Go - "1.23" - "1.24" steps: diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 54feae1..49f0366 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -9,9 +9,11 @@ jobs: # perform matrix testing to give us an earlier insight into issues with different versions of supported major versions of Go matrix: version: + # versions of Go that this module can still be built with (and therefore are "supported" by this project) - "1.20" - "1.21" - "1.22" + # actively supported versions of Go - "1.23" - "1.24" steps: diff --git a/.github/workflows/tidy.yml b/.github/workflows/tidy.yml index 5754e8c..3183667 100644 --- a/.github/workflows/tidy.yml +++ b/.github/workflows/tidy.yml @@ -9,9 +9,11 @@ jobs: # perform matrix testing to give us an earlier insight into issues with different versions of supported major versions of Go matrix: version: + # versions of Go that this module can still be built with (and therefore are "supported" by this project) - "1.20" - "1.21" - "1.22" + # actively supported versions of Go - "1.23" - "1.24" steps: From 94d0dd64f6b7b34c08799fbaeac1fbbe952c0fe5 Mon Sep 17 00:00:00 2001 From: Jamie Tanna Date: Wed, 30 Apr 2025 17:21:49 +0100 Subject: [PATCH 3/4] sq --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f14bf6c..582bd48 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,6 +2,8 @@ name: Build project on: [ push, pull_request ] jobs: build: + # allow triggering on a push to the repo, or a PR build, not both events + if: github.event_name == 'push' || github.event.pull_request.head.sha != github.sha name: Build runs-on: ubuntu-latest strategy: From 68c2253dcdf3a33a1a89a7416d9efe717233bafb Mon Sep 17 00:00:00 2001 From: Jamie Tanna Date: Wed, 30 Apr 2025 17:22:27 +0100 Subject: [PATCH 4/4] sq