Feature/3/update to latest interface (#5)

* (#3) Adjust to latest interface

* (#3) Mock jimp package

* (#3) Use npm pack result in e2e test to avoid wrong module resolution

* (#3) Run pretest setup before Docker e2e tests

* (#3) Run pretest setup before Docker e2e tests

* (#3) Change working directory instead of using --prefix on npm to avoid path errors on install

* (#3) Use dedicated install script for flexible installation

* (#3) Limit Docker tests to e2e tests

* (#3) Run install in build script

* (#3) Use npm cit on build script

* (#3) Revert using npm cit

* (#3) Disable Docker E2E tests until problems have been resolved

* (#3) Refined E2E setup

* (#3) Fixed tests

* (#3) Refined result image

* (#3) Removed screen tests from plugin

* (#3) Lowered matching confidence for drag & drop test

* (#3) Add support for BGR and RGB color modes

* (#3) Limit node version for CI runs to 16

* (#3) Limit node version for CI runs to 14

Author: s1hofmann

.github/workflows/ci.yaml

@@ -37,10 +37,7 @@ jobs:
     strategy:
       matrix:
         os: [ ubuntu-latest, windows-latest, macos-latest ]
-        node: [ 14, 16 ]
-        exclude:
-          - os: ubuntu-latest
-            node: 14
+        node: [ 14 ]
     runs-on: ${{matrix.os}}
     steps:
       - name: Set up Git repository

.github/workflows/snapshot_release.yaml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       matrix:
         os: [ ubuntu-latest, windows-latest, macos-latest ]
-        node: [ 16 ]
+        node: [ 14 ]
     runs-on: ${{matrix.os}}
     steps:
       - name: Set up Git repository
@@ -48,7 +48,7 @@ jobs:
       - name: Set up node
         uses: actions/setup-node@v2
         with:
-          node-version: 16
+          node-version: 14
           registry-url: 'https://registry.npmjs.org'
       - name: Install
         run: npm ci

.github/workflows/tagged_release.yaml

@@ -9,7 +9,7 @@ jobs:
     strategy:
       matrix:
         os: [ ubuntu-latest, windows-latest, macos-latest ]
-        node: [ 16 ]
+        node: [ 14 ]
     runs-on: ${{matrix.os}}
     steps:
       - name: Set up Git repository
@@ -45,7 +45,7 @@ jobs:
       - name: Set up node
         uses: actions/setup-node@v2
         with:
-          node-version: 16
+          node-version: 14
           registry-url: 'https://registry.npmjs.org'
       - name: Install
         run: npm ci

e2e/plugin-test/index.e2e.spec.ts

@@ -70,6 +70,7 @@ describe("E2E tests", () => {
 
     it("drag & drop", async () => {
         screen.config.resourceDirectory = "./e2e/assets";
+        screen.config.confidence = 0.94;
 
         const expected = new Region(34, 574, 75, 107);
         const maxDiff = 1;

lib/image-processor.class.ts

@@ -1,5 +1,5 @@
 import * as cv from "opencv4nodejs-prebuilt";
-import {Image, Region} from "@nut-tree/nut-js";
+import {ColorMode, Image, Region} from "@nut-tree/nut-js";
 
 function determineROI(img: Image, roi: Region): cv.Rect {
     return new cv.Rect(
@@ -22,7 +22,12 @@ export const fromImageWithAlphaChannel = async (
     img: Image,
     roi?: Region,
 ): Promise<cv.Mat> => {
-    const mat = await new cv.Mat(img.data, img.height, img.width, cv.CV_8UC4).cvtColorAsync(cv.COLOR_BGRA2BGR);
+    let mat: cv.Mat;
+    if (img.colorMode === ColorMode.RGB) {
+        mat = await new cv.Mat(img.data, img.height, img.width, cv.CV_8UC4).cvtColorAsync(cv.COLOR_RGBA2BGR);
+    } else {
+        mat = await new cv.Mat(img.data, img.height, img.width, cv.CV_8UC4).cvtColorAsync(cv.COLOR_BGRA2BGR);
+    }
     if (roi) {
         return mat.getRegion(determineROI(img, roi));
     } else {
@@ -43,7 +48,12 @@ export const fromImageWithoutAlphaChannel = async (
     img: Image,
     roi?: Region,
 ): Promise<cv.Mat> => {
-    const mat = new cv.Mat(img.data, img.height, img.width, cv.CV_8UC3);
+    let mat: cv.Mat;
+    if (img.colorMode === ColorMode.RGB) {
+        mat = await new cv.Mat(img.data, img.height, img.width, cv.CV_8UC3).cvtColorAsync(cv.COLOR_RGB2BGR);
+    } else {
+        mat = new cv.Mat(img.data, img.height, img.width, cv.CV_8UC3);
+    }
     if (roi) {
         return mat.getRegion(determineROI(img, roi));
     } else {