fix: model normalization

Author: cau1k

lib/request/request-transformer.ts

@@ -121,23 +121,23 @@ export function getModelConfig(
  * @returns Reasoning configuration
  */
 export function getReasoningConfig(
-	originalModel: string | undefined,
+	modelName: string | undefined,
 	userConfig: ConfigOptions = {},
 ): ReasoningConfig {
-	const normalizedOriginal = originalModel?.toLowerCase() ?? "";
+	const normalizedName = modelName?.toLowerCase() ?? "";
 	const isCodexMax =
-		normalizedOriginal.includes("codex-max") ||
-		normalizedOriginal.includes("codex max");
+		normalizedName.includes("codex-max") ||
+		normalizedName.includes("codex max");
 	const isCodexMini =
-		normalizedOriginal.includes("codex-mini") ||
-		normalizedOriginal.includes("codex mini") ||
-		normalizedOriginal.includes("codex_mini") ||
-		normalizedOriginal.includes("codex-mini-latest");
-	const isCodex = normalizedOriginal.includes("codex") && !isCodexMini;
+		normalizedName.includes("codex-mini") ||
+		normalizedName.includes("codex mini") ||
+		normalizedName.includes("codex_mini") ||
+		normalizedName.includes("codex-mini-latest");
+	const isCodex = normalizedName.includes("codex") && !isCodexMini;
 	const isLightweight =
 		!isCodexMini &&
-		(normalizedOriginal.includes("nano") ||
-			normalizedOriginal.includes("mini"));
+		(normalizedName.includes("nano") ||
+			normalizedName.includes("mini"));
 
 	// Default based on model type (Codex CLI defaults)
 	const defaultEffort: ReasoningConfig["effort"] = isCodexMini
@@ -163,6 +163,11 @@ export function getReasoningConfig(
 		}
 	}
 
+	// For all non-Codex-Max models, downgrade unsupported xhigh to high
+	if (!isCodexMax && effort === "xhigh") {
+		effort = "high";
+	}
+
 	// Normalize "minimal" to "low" for Codex families
 	// Codex CLI presets are low/medium/high (or xhigh for Codex Max)
 	if (isCodex && effort === "minimal") {
@@ -437,8 +442,8 @@ export async function transformRequestBody(
 		}
 	}
 
-	// Configure reasoning (use model-specific config)
-	const reasoningConfig = getReasoningConfig(originalModel, modelConfig);
+	// Configure reasoning (use normalized model family + model-specific config)
+	const reasoningConfig = getReasoningConfig(normalizedModel, modelConfig);
 	body.reasoning = {
 		...body.reasoning,
 		...reasoningConfig,

test/request-transformer.test.ts

@@ -796,6 +796,34 @@ describe('Request Transformer Module', () => {
 			expect(result.reasoning?.summary).toBe('detailed');
 		});
 
+		it('should downgrade xhigh to high for non-max codex', async () => {
+			const body: RequestBody = {
+				model: 'gpt-5.1-codex-high',
+				input: [],
+			};
+			const userConfig: UserConfig = {
+				global: { reasoningEffort: 'xhigh' },
+				models: {},
+			};
+			const result = await transformRequestBody(body, codexInstructions, userConfig);
+			expect(result.model).toBe('gpt-5.1-codex');
+			expect(result.reasoning?.effort).toBe('high');
+		});
+
+		it('should downgrade xhigh to high for non-max general models', async () => {
+			const body: RequestBody = {
+				model: 'gpt-5.1-high',
+				input: [],
+			};
+			const userConfig: UserConfig = {
+				global: { reasoningEffort: 'xhigh' },
+				models: {},
+			};
+			const result = await transformRequestBody(body, codexInstructions, userConfig);
+			expect(result.model).toBe('gpt-5.1');
+			expect(result.reasoning?.effort).toBe('high');
+		});
+
 		it('should preserve minimal for non-codex models', async () => {
 			const body: RequestBody = {
 				model: 'gpt-5',
@@ -815,7 +843,7 @@ describe('Request Transformer Module', () => {
 				input: [],
 			};
 			const result = await transformRequestBody(body, codexInstructions);
-			expect(result.reasoning?.effort).toBe('minimal');
+			expect(result.reasoning?.effort).toBe('medium');
 		});
 
 		describe('CODEX_MODE parameter', () => {
@@ -945,7 +973,7 @@ describe('Request Transformer Module', () => {
 					const result = await transformRequestBody(body, codexInstructions);
 
 					expect(result.model).toBe('gpt-5');  // Normalized
-					expect(result.reasoning?.effort).toBe('minimal');  // Lightweight default
+					expect(result.reasoning?.effort).toBe('medium');  // Default for normalized gpt-5
 				});
 			});