Skip to content

Commit 7009262

Browse files
authored
chore: add sessionreducer sum example to CI (#114)
Signed-off-by: a3hadi <a3hadi@protonmail.com>
1 parent 16c1c10 commit 7009262

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

.github/workflows/build-push.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ on:
88

99
jobs:
1010
docker_publish:
11+
# run it only on numaproj/numaflow-go repository
12+
# forked repositories normally don't have the proper permission setup.
13+
if: ${{ github.repository }} == "numaproj/numaflow-go"
1114
name: Build, Tag, and Push Image
1215
runs-on: ubuntu-latest
1316

@@ -17,9 +20,9 @@ jobs:
1720
"pkg/mapper/examples/even_odd", "pkg/mapper/examples/flatmap", "pkg/mapper/examples/forward_message",
1821
"pkg/mapper/examples/retry", "pkg/mapper/examples/tickgen", "pkg/mapstreamer/examples/flatmap_stream",
1922
"pkg/reducer/examples/counter", "pkg/reducer/examples/sum", "pkg/reducestreamer/examples/counter",
20-
"pkg/reducestreamer/examples/sum", "pkg/sessionreducer/examples/counter", "pkg/sideinput/examples/simple-sideinput/udf",
21-
"pkg/sideinput/examples/simple-sideinput", "pkg/sinker/examples/log", "pkg/sourcer/examples/simple_source",
22-
"pkg/sourcetransformer/examples/assign_event_time", "pkg/sourcetransformer/examples/event_time_filter"
23+
"pkg/reducestreamer/examples/sum", "pkg/sessionreducer/examples/counter", "pkg/sessionreducer/examples/sum",
24+
"pkg/sideinput/examples/simple-sideinput/udf", "pkg/sideinput/examples/simple-sideinput", "pkg/sinker/examples/log",
25+
"pkg/sourcer/examples/simple_source", "pkg/sourcetransformer/examples/assign_event_time", "pkg/sourcetransformer/examples/event_time_filter"
2326
]
2427

2528
steps:

development.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,9 @@ files to reflect this new version:
4444
```
4545
After running the above, create a PR for the changes that the script made. Once merged, it will trigger the Docker Publish workflow.
4646
As a result, the correct SDK version will always be printed in the server information logs,
47-
and the example images will always be using the latest changes (due to the local references).
47+
and the example images will always be using the latest changes (due to the local references).
48+
49+
### Adding a New Example
50+
51+
If you add a new example, in order for it to be used by the Docker Publish workflow, add its path
52+
to the `dockerfile_paths` matrix in `build-push.yaml`.

0 commit comments

Comments
 (0)