Explicit not equals

sgryphon · nuclearcat · commit e15cc725f145 · 2022-11-27T18:06:21.000+02:00
diff --git a/cores/esp32/IPAddress.cpp b/cores/esp32/IPAddress.cpp
@@ -113,6 +113,12 @@ bool IPAddress::operator==(const IPAddress& addr) const
         && (memcmp(addr._address.bytes, _address.bytes, sizeof(_address.bytes)) == 0);
 }
 
+bool IPAddress::operator!=(const IPAddress& addr) const
+{
+    return (addr._type != _type)
+        || (memcmp(addr._address.bytes, _address.bytes, sizeof(_address.bytes)) != 0);
+}
+
 bool IPAddress::operator==(const uint8_t* addr) const
 {
     // IPv4 only comparison to byte pointer
diff --git a/cores/esp32/IPAddress.h b/cores/esp32/IPAddress.h
@@ -75,7 +75,7 @@ class IPAddress: public Printable
     }
 
     bool operator==(const IPAddress& addr) const;
-    bool operator!=(const IPAddress& addr) const { return !(*this == addr); };
+    bool operator!=(const IPAddress& addr) const;
     bool operator==(const uint8_t* addr) const;
 
     // Overloaded index operator to allow getting and setting individual octets of the address

Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,12 @@ bool IPAddress::operator==(const IPAddress& addr) const`
`113`	`113`	`&& (memcmp(addr._address.bytes, _address.bytes, sizeof(_address.bytes)) == 0);`
`114`	`114`	`}`
`115`	`115`
	`116`	`+bool IPAddress::operator!=(const IPAddress& addr) const`
	`117`	`+{`
	`118`	`+ return (addr._type != _type)`
	`119`	`+ \|\| (memcmp(addr._address.bytes, _address.bytes, sizeof(_address.bytes)) != 0);`
	`120`	`+}`
	`121`	`+`
`116`	`122`	`bool IPAddress::operator==(const uint8_t* addr) const`
`117`	`123`	`{`
`118`	`124`	`// IPv4 only comparison to byte pointer`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ class IPAddress: public Printable`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`bool operator==(const IPAddress& addr) const;`
`78`		`- bool operator!=(const IPAddress& addr) const { return !(*this == addr); };`
	`78`	`+ bool operator!=(const IPAddress& addr) const;`
`79`	`79`	`bool operator==(const uint8_t* addr) const;`
`80`	`80`
`81`	`81`	`// Overloaded index operator to allow getting and setting individual octets of the address`