Skip to content

Commit 8aef509

Browse files
authored
fix: dont conclude checks if they were never set (#446)
1 parent 9440c4f commit 8aef509

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

.github/workflows/ci-release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
run: npm run postlint --ignore-scripts -ws -iwr --if-present
6262
- name: Conclude Check
6363
uses: LouisBrunner/[email protected]
64-
if: always()
64+
if: steps.create-check.outputs.check-id && always()
6565
with:
6666
token: ${{ secrets.GITHUB_TOKEN }}
6767
conclusion: ${{ job.status }}
@@ -142,7 +142,7 @@ jobs:
142142
run: npm test --ignore-scripts -ws -iwr --if-present
143143
- name: Conclude Check
144144
uses: LouisBrunner/[email protected]
145-
if: always()
145+
if: steps.create-check.outputs.check-id && always()
146146
with:
147147
token: ${{ secrets.GITHUB_TOKEN }}
148148
conclusion: ${{ job.status }}

lib/content/ci-release-yml.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
{{> stepLintYml jobRunFlags=allFlags }}
2828
- name: Conclude Check
2929
uses: LouisBrunner/[email protected]
30-
if: always()
30+
if: steps.create-check.outputs.check-id && always()
3131
with:
3232
token: $\{{ secrets.GITHUB_TOKEN }}
3333
conclusion: $\{{ job.status }}
@@ -42,7 +42,7 @@ jobs:
4242
{{> stepTestYml jobRunFlags=allFlags }}
4343
- name: Conclude Check
4444
uses: LouisBrunner/[email protected]
45-
if: always()
45+
if: steps.create-check.outputs.check-id && always()
4646
with:
4747
token: $\{{ secrets.GITHUB_TOKEN }}
4848
conclusion: $\{{ job.status }}

tap-snapshots/test/apply/source-snapshots.js.test.cjs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ jobs:
452452
run: npm run postlint --ignore-scripts
453453
- name: Conclude Check
454454
uses: LouisBrunner/[email protected]
455-
if: always()
455+
if: steps.create-check.outputs.check-id && always()
456456
with:
457457
token: \${{ secrets.GITHUB_TOKEN }}
458458
conclusion: \${{ job.status }}
@@ -521,7 +521,7 @@ jobs:
521521
run: npm test --ignore-scripts
522522
- name: Conclude Check
523523
uses: LouisBrunner/[email protected]
524-
if: always()
524+
if: steps.create-check.outputs.check-id && always()
525525
with:
526526
token: \${{ secrets.GITHUB_TOKEN }}
527527
conclusion: \${{ job.status }}
@@ -2102,7 +2102,7 @@ jobs:
21022102
run: npm run postlint --ignore-scripts -ws -iwr --if-present
21032103
- name: Conclude Check
21042104
uses: LouisBrunner/[email protected]
2105-
if: always()
2105+
if: steps.create-check.outputs.check-id && always()
21062106
with:
21072107
token: \${{ secrets.GITHUB_TOKEN }}
21082108
conclusion: \${{ job.status }}
@@ -2171,7 +2171,7 @@ jobs:
21712171
run: npm test --ignore-scripts -ws -iwr --if-present
21722172
- name: Conclude Check
21732173
uses: LouisBrunner/[email protected]
2174-
if: always()
2174+
if: steps.create-check.outputs.check-id && always()
21752175
with:
21762176
token: \${{ secrets.GITHUB_TOKEN }}
21772177
conclusion: \${{ job.status }}
@@ -3775,7 +3775,7 @@ jobs:
37753775
run: npm run postlint --ignore-scripts -ws -iwr --if-present
37763776
- name: Conclude Check
37773777
uses: LouisBrunner/[email protected]
3778-
if: always()
3778+
if: steps.create-check.outputs.check-id && always()
37793779
with:
37803780
token: \${{ secrets.GITHUB_TOKEN }}
37813781
conclusion: \${{ job.status }}
@@ -3844,7 +3844,7 @@ jobs:
38443844
run: npm test --ignore-scripts -ws -iwr --if-present
38453845
- name: Conclude Check
38463846
uses: LouisBrunner/[email protected]
3847-
if: always()
3847+
if: steps.create-check.outputs.check-id && always()
38483848
with:
38493849
token: \${{ secrets.GITHUB_TOKEN }}
38503850
conclusion: \${{ job.status }}

0 commit comments

Comments
 (0)